From leeym@utopia.leeym.com  Fri Sep 10 18:15:48 2004
Return-Path: <leeym@utopia.leeym.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 404DC16A4CE; Fri, 10 Sep 2004 18:15:48 +0000 (GMT)
Received: from utopia.leeym.com (utopia.leeym.com [211.21.137.52])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id E1B0E43D49; Fri, 10 Sep 2004 18:15:47 +0000 (GMT)
	(envelope-from leeym@utopia.leeym.com)
Received: from localhost (localhost [127.0.0.1])
	by utopia.leeym.com (Postfix) with ESMTP id 02CED3EAD8B;
	Sat, 11 Sep 2004 02:15:47 +0800 (CST)
Received: from utopia.leeym.com ([127.0.0.1])
 by localhost (utopia.leeym.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 04209-10; Sat, 11 Sep 2004 02:15:43 +0800 (CST)
Received: by utopia.leeym.com (Postfix, from userid 1000)
	id 999093EAD72; Sat, 11 Sep 2004 02:15:43 +0800 (CST)
Message-Id: <20040910181543.999093EAD72@utopia.leeym.com>
Date: Sat, 11 Sep 2004 02:15:43 +0800 (CST)
From: Yen-Ming Lee <leeym@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: marcus@FreeBSD.org
Subject: [PATCH] devel/portlint: check USE_GETTEXT
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         71564
>Category:       ports
>Synopsis:       [PATCH] devel/portlint: check USE_GETTEXT
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    marcus
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Sep 10 18:20:23 GMT 2004
>Closed-Date:    Tue Oct 12 04:30:17 GMT 2004
>Last-Modified:  Tue Oct 12 04:30:17 GMT 2004
>Originator:     Yen-Ming Lee
>Release:        FreeBSD 5.3-BETA3 i386
>Organization:
FreeBSD Taiwan
>Environment:
System: FreeBSD utopia.leeym.com 5.3-BETA3 FreeBSD 5.3-BETA3 #4: Fri Sep 10 05:12:41 CST 2004
>Description:

- check if *.mo files installed without defining USE_GETTEXT
  (use bundled libintl may install other useless reference files: ports/71531)

Port maintainer (marcus@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.63
>How-To-Repeat:
>Fix:

--- portlint-2.6.7.patch begins here ---
Index: src/portlint.pl
===================================================================
RCS file: /home/pcvs/ports/devel/portlint/src/portlint.pl,v
retrieving revision 1.63
diff -u -u -r1.63 portlint.pl
--- src/portlint.pl	1 Sep 2004 04:13:32 -0000	1.63
+++ src/portlint.pl	10 Sep 2004 18:07:01 -0000
@@ -174,7 +174,7 @@
 	MASTER_SITES WRKDIR WRKSRC NO_WRKSUBDIR PATCHDIR SCRIPTDIR FILESDIR
 	PKGDIR COMMENT DESCR PLIST PKGCATEGORY PKGINSTALL PKGDEINSTALL
 	PKGREQ PKGMESSAGE MD5_FILE .CURDIR INSTALLS_SHLIB USE_LIBTOOL_VER
-	INDEXFILE PKGORIGIN CONFLICTS PKG_VERSION PKGINSTALLVER
+	INDEXFILE PKGORIGIN CONFLICTS PKG_VERSION PKGINSTALLVER USE_GETTEXT
 );
 
 my $cmd = join(' -V ', "make $makeenv MASTER_SITE_BACKUP=''", @varlist);
@@ -753,6 +753,11 @@
 
 		if ($_ =~ /^share\/examples\//) {
 			&perror("WARN: $file [$.]: consider using EXAMPLESDIR macro");
+		}
+
+		if ($_ =~ /\.mo$/ && $makevar{USE_GETTEXT} eq '') {
+			&perror("WARN: $file [$.]: installing GNU message catalogs, ".
+				"please define USE_GETTEXT as appropriate.");
 		}
 
 		if ($_ =~ m#man/([^/]+/)?man([$manchapters])/([^\.]+\.[$manchapters])(\.gz)?$#) {
--- portlint-2.6.7.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->marcus 
Responsible-Changed-By: leeym 
Responsible-Changed-When: Sat Sep 11 03:41:11 GMT 2004 
Responsible-Changed-Why:  
Over to the MAINTAINER. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=71564 
State-Changed-From-To: open->closed 
State-Changed-By: marcus 
State-Changed-When: Tue Oct 12 04:13:52 GMT 2004 
State-Changed-Why:  
Not all ports that install .mo files need to define USE_GETTEXT.  Gettext 
can simply be a BUILD_DEPENDS to generate the .mo files (e.g. i18n KDE and OpenOffice ports). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=71564 
>Unformatted:
