From leeym@utopia.leeym.com  Mon Aug 30 18:17:05 2004
Return-Path: <leeym@utopia.leeym.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 0261D16A4CE; Mon, 30 Aug 2004 18:17:05 +0000 (GMT)
Received: from utopia.leeym.com (utopia.leeym.com [211.21.137.52])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id ACF1243D5D; Mon, 30 Aug 2004 18:17:04 +0000 (GMT)
	(envelope-from leeym@utopia.leeym.com)
Received: from localhost (localhost [127.0.0.1])
	by utopia.leeym.com (Postfix) with ESMTP id CE4B63EAD65;
	Tue, 31 Aug 2004 02:17:03 +0800 (CST)
Received: from utopia.leeym.com ([127.0.0.1])
 by localhost (utopia.leeym.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 63007-08; Tue, 31 Aug 2004 02:16:58 +0800 (CST)
Received: by utopia.leeym.com (Postfix, from userid 1000)
	id 568783EAD5F; Tue, 31 Aug 2004 02:16:58 +0800 (CST)
Message-Id: <20040830181658.568783EAD5F@utopia.leeym.com>
Date: Tue, 31 Aug 2004 02:16:58 +0800 (CST)
From: Yen-Ming Lee <leeym@utopia.leeym.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc: marcus@FreeBSD.org
Subject: [PATCH] devel/portlint: minor fix to avoid misjudged WARN
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         71159
>Category:       ports
>Synopsis:       [PATCH] devel/portlint: minor fix to avoid misjudged WARN
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    marcus
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Aug 30 18:20:20 GMT 2004
>Closed-Date:    Wed Sep 01 04:14:04 GMT 2004
>Last-Modified:  Wed Sep 01 04:14:04 GMT 2004
>Originator:     Yen-Ming Lee
>Release:        FreeBSD 5.2.1-RELEASE-p9 i386
>Organization:
>Environment:
System: FreeBSD utopia.leeym.com 5.2.1-RELEASE-p9 FreeBSD 5.2.1-RELEASE-p9 #167: Tue Jul 27 05:17:58 CST 2004
>Description:

- minor fix for "possible direct use of command" to avoid misjudged warnings
  (such as install v.s. install-info)
- bump PORTREVISION

Port maintainer (marcus@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.63
>How-To-Repeat:
>Fix:

--- portlint-2.6.6_1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/devel/portlint/Makefile,v
retrieving revision 1.81
diff -u -u -r1.81 Makefile
--- Makefile	27 Jun 2004 20:58:47 -0000	1.81
+++ Makefile	30 Aug 2004 18:13:57 -0000
@@ -9,6 +9,7 @@
 
 PORTNAME=	portlint
 PORTVERSION=	2.6.6
+PORTREVISION=	1
 CATEGORIES=	devel
 MASTER_SITES=	# none
 DISTFILES=	# none
Index: src/portlint.pl
===================================================================
RCS file: /home/pcvs/ports/devel/portlint/src/portlint.pl,v
retrieving revision 1.62
diff -u -u -r1.62 portlint.pl
--- src/portlint.pl	27 Jun 2004 20:58:47 -0000	1.62
+++ src/portlint.pl	30 Aug 2004 18:13:58 -0000
@@ -1301,7 +1301,7 @@
 	foreach my $i (keys %cmdnames) {
 		# XXX This is a hack.  Really, we should break $j up into individual
 		# lines, and go through each one.
-		while ($j =~ /^(.*$i.*)$/gm) {
+		while ($j =~ /^(.*\W?$i\s.*)$/gm) {
 			my $curline = $1;
 			my $lineno = &linenumber($`);
 			if ($curline =~ /(^|\s+)[\@\-]{0,2}$i\b/
--- portlint-2.6.6_1.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->marcus 
Responsible-Changed-By: vs 
Responsible-Changed-When: Tue Aug 31 09:09:42 GMT 2004 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=71159 

From: Oliver Eikemeier <eikemeier@fillmore-labs.com>
To: Yen-Ming Lee <leeym@utopia.leeym.com>
Cc: FreeBSD-gnats-submit@FreeBSD.org, marcus@FreeBSD.org
Subject: Re: ports/71159: [PATCH] devel/portlint: minor fix to avoid misjudged WARN
Date: Tue, 31 Aug 2004 14:05:13 +0200

 Yen-Ming Lee wrote:
 
 > - minor fix for "possible direct use of command" to avoid misjudged 
 > warnings
 >   (such as install v.s. install-info)
 
 > -		while ($j =~ /^(.*$i.*)$/gm) {
 > +		while ($j =~ /^(.*\W?$i\s.*)$/gm) {
 
 Maybe this should be
 @@ -1304,7 +1305,7 @@
   		while ($j =~ /^(.*$i.*)$/gm) {
   			my $curline = $1;
   			my $lineno = &linenumber($`);
 -			if ($curline =~ /(^|\s+)[\@\-]{0,2}$i\b/
 +			if ($curline =~ /(?:^|\s)[\@\-]{0,2}$i(?:$|\s)/
   				&& $curline !~ /^[A-Z]+_TARGET[?+]?=[^\n]+$i/m
   				&& $curline !~ /^IGNORE(.)?=[^\n]+$i/m
   				&& $curline !~ /^BROKEN(.)?=[^\n]+$i/m
 ?
 
 -Oliver
 

From: Yen-Ming Lee <leeym@FreeBSD.org>
To: Oliver Eikemeier <eikemeier@fillmore-labs.com>
Cc: FreeBSD-gnats-submit@FreeBSD.org, marcus@FreeBSD.org
Subject: Re: ports/71159: [PATCH] devel/portlint: minor fix to avoid misjudged WARN
Date: Tue, 31 Aug 2004 21:06:12 +0800

 --+QahgC5+KEYLbs62
 Content-Type: text/plain; charset=big5
 Content-Disposition: inline
 
 On Tue, Aug 31, 2004 at 02:05:13PM +0200, Oliver Eikemeier wrote:
 > Yen-Ming Lee wrote:
 > 
 > >- minor fix for "possible direct use of command" to avoid misjudged 
 > >warnings
 > >  (such as install v.s. install-info)
 > 
 > >-		while ($j =~ /^(.*$i.*)$/gm) {
 > >+		while ($j =~ /^(.*\W?$i\s.*)$/gm) {
 > 
 > Maybe this should be
 > @@ -1304,7 +1305,7 @@
 >  		while ($j =~ /^(.*$i.*)$/gm) {
 >  			my $curline = $1;
 >  			my $lineno = &linenumber($`);
 > -			if ($curline =~ /(^|\s+)[\@\-]{0,2}$i\b/
 > +			if ($curline =~ /(?:^|\s)[\@\-]{0,2}$i(?:$|\s)/
 >  				&& $curline !~ 
 >  				/^[A-Z]+_TARGET[?+]?=[^\n]+$i/m
 >  				&& $curline !~ /^IGNORE(.)?=[^\n]+$i/m
 >  				&& $curline !~ /^BROKEN(.)?=[^\n]+$i/m
 > ?
 > 
 > -Oliver
 
 Yeah, your patch looks better :-)
 
 -- 
 Yen-Ming Lee [utf7:+Z05fZWYO] | KeyID:0x5EB52E51 | Taipei, Taiwan
 
 --+QahgC5+KEYLbs62
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.5 (FreeBSD)
 
 iQCVAwUBQTR3w8nMx0NetS5RAQHX1wP9EiRxoSac1+9OJz7bCH+Ni5ZyvmY2947M
 i58AwrN1y7xAapBtn8HLauZK/I8j0/gyzcXcMVJ5h1zbK2LQGanaHXVelc4lG3lN
 g2GDu1h/kKYvh6ZafzYKdkRDr1nVOy2uSr0GnTPxreAy7DuMxVyTwx2/dQ6Ym08F
 eAQNcIJGaCg=
 =I1K0
 -----END PGP SIGNATURE-----
 
 --+QahgC5+KEYLbs62--
State-Changed-From-To: open->closed 
State-Changed-By: marcus 
State-Changed-When: Wed Sep 1 04:13:47 GMT 2004 
State-Changed-Why:  
Eik's patch was committed.  Thanks for reporting! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=71159 
>Unformatted:
