From nobody@FreeBSD.org  Sat Aug 21 23:55:58 2004
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A201716A4CE
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 21 Aug 2004 23:55:58 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9745D43D1D
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 21 Aug 2004 23:55:58 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.11/8.12.11) with ESMTP id i7LNtwOn075004
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 21 Aug 2004 23:55:58 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.11/8.12.11/Submit) id i7LNtw58075003;
	Sat, 21 Aug 2004 23:55:58 GMT
	(envelope-from nobody)
Message-Id: <200408212355.i7LNtw58075003@www.freebsd.org>
Date: Sat, 21 Aug 2004 23:55:58 GMT
From: SANETO Takanori <sanewo@ba2.so-net.ne.jp>
To: freebsd-gnats-submit@FreeBSD.org
Subject: oinkmaster use tar options incompatible to bsdtar
X-Send-Pr-Version: www-2.3

>Number:         70806
>Category:       ports
>Synopsis:       oinkmaster use tar options incompatible to bsdtar
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Aug 22 00:00:43 GMT 2004
>Closed-Date:    Sun Aug 29 03:44:13 GMT 2004
>Last-Modified:  Sun Aug 29 03:44:13 GMT 2004
>Originator:     SANETO Takanori
>Release:        5.2-CURRENT as of Aug 16
>Organization:
an individual
>Environment:
FreeBSD muse.sanewo.ddo.jp 5.2-CURRENT FreeBSD 5.2-CURRENT #321: Mon Aug 16 23:41:11 JST 2004     root@muse.sanewo.ddo.jp:/export/usr/obj/usr/src/sys/MUSE  i386
>Description:
      oinkmaster uses option "tPf" to tar. It is OK for gtar, but bsdtar does not permit -P to be used with -t.
On -CURRENT, /usr/bin/tar is bsdtar by default (as of Jul 17), this is problem.
>How-To-Repeat:
      Run oinkmaster and you will get following error:

Loading /usr/local/etc/oinkmaster.conf
Downloading file from http://www.snort.org/dl/rules/snortrules-snapshot-2_1.tar.gz... done.
tar: Option -P is not permitted in mode -t

/usr/local/bin/oinkmaster: Error: could not list files in tar archive (is it broken?)

>Fix:
      Following fix solved the problem:

diff -u -r1.7 Makefile
--- Makefile    2 Jul 2004 07:54:15 -0000       1.7
+++ Makefile    21 Aug 2004 23:27:18 -0000
@@ -29,6 +29,7 @@

 post-patch:
        @${REINPLACE_CMD} -e 's,/usr/bin/perl,${PERL},g' \
+               -e 's,system("tar",system("gtar",g' \
                ${WRKSRC}/oinkmaster.pl

 do-install:

>Release-Note:
>Audit-Trail:

From: Tim Kientzle <kientzle@freebsd.org>
To: freebsd-gnats-submit@freebsd.org, sanewo@ba2.so-net.ne.jp
Cc:  
Subject: Re: ports/70806: oinkmaster use tar options incompatible to bsdtar
Date: Wed, 25 Aug 2004 23:29:01 -0700

 You might also just remove the -P option.
 In gtar, -P has no effect when used with -t.
 
 $ gtar -cPf - /etc | gtar -tf - | head
 /etc/
 /etc/defaults/
 /etc/defaults/rc.conf
 /etc/defaults/pccard.conf
 
 $ gtar -cPf - /etc | gtar -tPf - | head
 /etc/
 /etc/defaults/
 /etc/defaults/rc.conf
 /etc/defaults/pccard.conf
 

From: "SANETO Takanori" <sanewo@ba2.so-net.ne.jp>
To: <freebsd-gnats-submit@FreeBSD.org>
Cc: "Tim Kientzle" <kientzle@freebsd.org>
Subject: Re: ports/70806: oinkmaster use tar options incompatible to bsdtar
Date: Sat, 28 Aug 2004 12:35:07 +0900

 Just removing P from tar options sounds reasonable.
 
 I'll ask the author of oinkmaster use "tf" instead of "tPf".
 
 

From: "SANETO Takanori" <sanewo@ba2.so-net.ne.jp>
To: <freebsd-gnats-submit@FreeBSD.org>
Cc:  
Subject: Re: ports/70806: oinkmaster use tar options incompatible to bsdtar
Date: Sun, 29 Aug 2004 08:36:32 +0900

 Oinkmaster's author (Andreas) kindly accepted the change ("tPF" -> "tf") and
 oinkmaster-1.1 will include it.
 For the time being, following patch will do:
 
 Index: security/oinkmaster/Makefile
 ===================================================================
 RCS file: /export/cvsup/cvs/ports/security/oinkmaster/Makefile,v
 retrieving revision 1.7
 diff -u -u -r1.7 Makefile
 --- security/oinkmaster/Makefile        2 Jul 2004 07:54:15 -0000       1.7
 +++ security/oinkmaster/Makefile        28 Aug 2004 02:50:28 -0000
 @@ -29,6 +29,7 @@
 
  post-patch:
         @${REINPLACE_CMD} -e 's,/usr/bin/perl,${PERL},g' \
 +               -e 's,"tPf","tf",' \
                 ${WRKSRC}/oinkmaster.pl
 
  do-install:
 
 
State-Changed-From-To: open->closed 
State-Changed-By: linimon 
State-Changed-When: Sun Aug 29 03:44:03 GMT 2004 
State-Changed-Why:  
Committed, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=70806 
>Unformatted:
