From sw@gegenunendlich.de  Sat Aug 21 15:15:27 2004
Return-Path: <sw@gegenunendlich.de>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C098F16A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 21 Aug 2004 15:15:27 +0000 (GMT)
Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.190])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9CC6143D31
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 21 Aug 2004 15:15:26 +0000 (GMT)
	(envelope-from sw@gegenunendlich.de)
Received: from [212.227.126.208] (helo=mrelayng.kundenserver.de)
	by moutng.kundenserver.de with esmtp (Exim 3.35 #1)
	id 1ByXaX-0000lj-00; Sat, 21 Aug 2004 17:15:25 +0200
Received: from [80.142.211.175] (helo=kyuzo.dunkelkammer.void)
	by mrelayng.kundenserver.de with asmtp (TLSv1:EDH-RSA-DES-CBC3-SHA:168)
	(Exim 3.35 #1)
	id 1ByXaW-00058L-00; Sat, 21 Aug 2004 17:15:25 +0200
Received: by kyuzo.dunkelkammer.void (Postfix, from userid 1002)
	id D43263B3A; Sat, 21 Aug 2004 17:15:22 +0200 (CEST)
Message-Id: <20040821151522.D43263B3A@kyuzo.dunkelkammer.void>
Date: Sat, 21 Aug 2004 17:15:22 +0200 (CEST)
From: Stefan Walter <sw@gegenunendlich.de>
To: FreeBSD-gnats-submit@freebsd.org
Cc: hendrik@scholz.net
Subject: [PATCH] multimedia/transcode: fix modfps filter
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         70774
>Category:       ports
>Synopsis:       [PATCH] multimedia/transcode: fix modfps filter
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pav
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Aug 21 15:20:04 GMT 2004
>Closed-Date:    Mon Oct 11 23:12:25 GMT 2004
>Last-Modified:  Mon Oct 11 23:12:25 GMT 2004
>Originator:     Stefan Walter
>Release:        FreeBSD 5.2-CURRENT i386
>Organization:
Infinity Approximation Task Force
>Environment:
System: FreeBSD kyuzo.dunkelkammer.void 5.2-CURRENT FreeBSD 5.2-CURRENT #0: Wed Jul 28 20:21:17 CEST 2004
>Description:
Transcode's modfps filter is currently not usable, as there is no
lrint() function on FreeBSD. When trying to use the filter ('-J
modfps'), you get the following warning:

[transcode] warning : loading filter module /usr/local/lib/transcode/filter_modfps.so failed
[transcode] warning : /usr/local/lib/transcode/filter_modfps.so: Undefined symbol "lrint"

The attached patch works around the problem and makes it possible to use
the filter. It is acquired from NetBSD's pkgsrc:
http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/multimedia/transcode/patches/patch-av?rev=1.1&content-type=text/x-cvsweb-markup

(Tested exclusively on a FreeBSD-CURRENT that's a few weeks old, with
gcc 3.3.3.)

Port maintainer (hendrik@scholz.net) is cc'd.

Generated with FreeBSD Port Tools 0.50
>How-To-Repeat:
>Fix:

--- transcode-0.6.12_1.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/multimedia/transcode.old/files/patch-filter:filter_modfps.c /usr/ports/multimedia/transcode/files/patch-filter:filter_modfps.c
--- /usr/ports/multimedia/transcode.old/files/patch-filter:filter_modfps.c	Thu Jan  1 01:00:00 1970
+++ /usr/ports/multimedia/transcode/files/patch-filter:filter_modfps.c	Sat Aug 21 14:12:41 2004
@@ -0,0 +1,16 @@
+--- filter/filter_modfps.c.old	Sat Aug 21 13:11:20 2004
++++ filter/filter_modfps.c	Sat Aug 21 13:13:33 2004
+@@ -77,6 +77,13 @@
+ #include "framebuffer.h"
+ #include "optstr.h"
+ 
++#if !defined(HAVE_LRINTF)
++static inline long int lrint(double x)
++{
++    return (long)(rint(x));
++}
++#endif
++
+ static int show_results=0;
+ 
+ /*-------------------------------------------------
--- transcode-0.6.12_1.patch ends here ---

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: pav 
State-Changed-When: Sat Aug 21 19:40:46 GMT 2004 
State-Changed-Why:  
Asked maintainer for approval. 


Responsible-Changed-From-To: freebsd-ports-bugs->pav 
Responsible-Changed-By: pav 
Responsible-Changed-When: Sat Aug 21 19:40:46 GMT 2004 
Responsible-Changed-Why:  
Handle. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=70774 

From: Pav Lucistnik <pav@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org, sw@gegenunendlich.de,
	hendrik@scholz.net
Cc:  
Subject: Re: ports/70774: [PATCH] multimedia/transcode: fix modfps filter
Date: Sat, 21 Aug 2004 21:40:42 +0200

 Dear maintainer of FreeBSD port multimedia/transcode, please take a look
 at
 
 http://www.freebsd.org/cgi/query-pr.cgi?q=70774
 
 Do you approve this patch?
 
 -- 
 Pav Lucistnik <pav@oook.cz>
               <pav@FreeBSD.org>
 
 Adding horrible bugs to the source is a venal sin.
State-Changed-From-To: feedback->closed 
State-Changed-By: pav 
State-Changed-When: Mon Oct 11 23:12:11 GMT 2004 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=70774 
>Unformatted:
