From juhis@tykki.lan.juhis.ath.cx  Sun Aug 15 18:18:35 2004
Return-Path: <juhis@tykki.lan.juhis.ath.cx>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6F91716A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 15 Aug 2004 18:18:35 +0000 (GMT)
Received: from fep19.inet.fi (fep19.inet.fi [194.251.242.244])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 72B2143D2D
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 15 Aug 2004 18:18:34 +0000 (GMT)
	(envelope-from juhis@tykki.lan.juhis.ath.cx)
Received: from manmutt.juhis.ath.cx ([80.222.44.164]) by fep19.inet.fi
          with ESMTP
          id <20040815181833.EXVH18165.fep19.inet.fi@manmutt.juhis.ath.cx>
          for <FreeBSD-gnats-submit@freebsd.org>;
          Sun, 15 Aug 2004 21:18:33 +0300
Received: from tykki.juhis.ath.cx (tykki.lan.juhis.ath.cx [172.16.0.2])
	by manmutt.juhis.ath.cx (Postfix) with ESMTP id C500DDD83
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 15 Aug 2004 21:18:31 +0300 (EEST)
Received: by tykki.juhis.ath.cx (Postfix, from userid 2001)
	id 8435A17041; Sun, 15 Aug 2004 21:18:43 +0300 (EEST)
Message-Id: <20040815181843.8435A17041@tykki.juhis.ath.cx>
Date: Sun, 15 Aug 2004 21:18:43 +0300 (EEST)
From: Juha-Matti Tilli <juhis@nallukka.net>
Reply-To: Juha-Matti Tilli <juhis@nallukka.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] vlc incorrectly marked BROKEN on FreeBSD 5.2.1
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         70494
>Category:       ports
>Synopsis:       [PATCH] vlc incorrectly marked BROKEN on FreeBSD 5.2.1
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    dinoex
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Aug 15 18:20:23 GMT 2004
>Closed-Date:    Thu Aug 19 21:33:17 CEST 2004
>Last-Modified:  Thu Aug 19 21:33:17 CEST 2004
>Originator:     Juha-Matti Tilli
>Release:        FreeBSD 5.2.1-RELEASE-p9 i386
>Organization:
>Environment:
System: FreeBSD tykki.juhis.ath.cx 5.2.1-RELEASE-p9 FreeBSD 5.2.1-RELEASE-p9 #0: Wed Aug 11 22:18:25 EEST 2004 root@tykki:/usr/obj/usr/src/sys/TYKKI i386

% grep "define __FreeBSD_version" /usr/include/sys/param.h 
#define __FreeBSD_version 502010        /* Master, propagated to newvers */

>Description:
vlc is marked BROKEN on FreeBSD 5.2.1 due to conflicts with new threads
architecture, but not on 5.2. There were no thread-related changes between 5.2
and 5.2.1, and vlc works perfectly on 5.2.1.

>How-To-Repeat:
# cd /usr/ports/multimedia/vlc; make
===>  vlc-0.7.2_1 is marked as broken: conflicts with new threads architecture.

>Fix:
--- Makefile.orig	Sun Aug 15 20:55:04 2004
+++ Makefile	Sun Aug 15 20:55:31 2004
@@ -322,7 +322,7 @@
 		lib/vlc/libmemcpymmxext.a
 .endif
 
-.if ${OSVERSION} >= 502010
+.if ${OSVERSION} >= 502102
 BROKEN=		"conflicts with new threads architecture"
 .endif
 .if ${ARCH} == "alpha" && ${OSVERSION} < 500000
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->dinoex 
Responsible-Changed-By: vs 
Responsible-Changed-When: Mon Aug 16 08:27:39 GMT 2004 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=70494 
State-Changed-From-To: open->analyzed 
State-Changed-By: dinoex 
State-Changed-When: Tue Aug 17 06:01:05 CEST 2004 
State-Changed-Why:  
In testing. 
dependency gtk2 don't build on CURRENT 

http://www.freebsd.org/cgi/query-pr.cgi?pr=70494 
State-Changed-From-To: analyzed->feedback 
State-Changed-By: dinoex 
State-Changed-When: Tue Aug 17 07:55:25 CEST 2004 
State-Changed-Why:  
vlc still dumps core on CURREMT 

Core was generated by `vlc'. 
Program terminated with signal 10, Bus error. 
(gdb) bt 
#0  0x284147fb in pthread_testcancel () from /usr/lib/libpthread.so.1 
#1  0x2840e017 in pthread_mutexattr_init () from /usr/lib/libpthread.so.1 
#2  0x2840c7bb in pthread_mutexattr_init () from /usr/lib/libpthread.so.1 
#3  0x08217000 in ?? () 

/usr/local/bin/vlc: 
libintl.so.6 => /usr/local/lib/libintl.so.6 (0x28128000) 
libavcodec.so => /usr/local/lib/libavcodec.so (0x28133000) 
libm.so.2 => /lib/libm.so.2 (0x28300000) 
libstdc++.so.4 => /usr/lib/libstdc++.so.4 (0x2831a000) 
libpthread.so.1 => /usr/lib/libpthread.so.1 (0x283f6000) 
libc.so.5 => /lib/libc.so.5 (0x2841c000) 
libiconv.so.3 => /usr/local/lib/libiconv.so.3 (0x28508000) 
libz.so.2 => /lib/libz.so.2 (0x285fe000) 
libfaad.so.0 => /usr/local/lib/libfaad.so.0 (0x2860f000) 
libvorbis.so.3 => /usr/local/lib/libvorbis.so.3 (0x28654000) 
libvorbisenc.so.2 => /usr/local/lib/libvorbisenc.so.2 (0x28684000) 
libogg.so.5 => /usr/local/lib/libogg.so.5 (0x2876d000) 

Which libs and option have you installed? 
Do you use /etc/libmap.conf? 


Please add teh output of: 
$ ldd /usr/local/bin/vlc 
$ ls -l /usr/local/lib/ 

/usr/ports/multimedia/vlc$ make -V PTHREAD_LIBS 
/usr/ports/multimedia/vlc$ make -V PTHREAD_CFLAGS 


http://www.freebsd.org/cgi/query-pr.cgi?pr=70494 
State-Changed-From-To: feedback->closed 
State-Changed-By: dinoex 
State-Changed-When: Thu Aug 19 21:32:42 CEST 2004 
State-Changed-Why:  
committed, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=70494 
>Unformatted:
