From never@mile.mirotel.net  Thu Aug 12 13:07:27 2004
Return-Path: <never@mile.mirotel.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9F8E316A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 12 Aug 2004 13:07:27 +0000 (GMT)
Received: from mile.mirotel.net (mile.mirotel.net [194.125.225.114])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D187643D2D
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 12 Aug 2004 13:07:26 +0000 (GMT)
	(envelope-from never@mile.mirotel.net)
Received: from mile.mirotel.net (localhost.mirotel.net [127.0.0.1])
	by mile.mirotel.net (8.12.10/8.12.10) with ESMTP id i7CD7OF3003051
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 12 Aug 2004 16:07:24 +0300 (EEST)
	(envelope-from never@mile.mirotel.net)
Received: (from never@localhost)
	by mile.mirotel.net (8.12.10/8.12.10/Submit) id i7CD7Ohr003050;
	Thu, 12 Aug 2004 16:07:24 +0300 (EEST)
	(envelope-from never)
Message-Id: <200408121307.i7CD7Ohr003050@mile.mirotel.net>
Date: Thu, 12 Aug 2004 16:07:24 +0300 (EEST)
From: Alexandr Kovalenko <never@nevermind.kiev.ua>
Reply-To: Alexandr Kovalenko <never@nevermind.kiev.ua>
To: FreeBSD-gnats-submit@freebsd.org
Cc: koma2@lovepeers.org
Subject: sysutils/portupgrade incorrectly give info on port's brokenness
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         70365
>Category:       ports
>Synopsis:       sysutils/portupgrade incorrectly give info on port's brokenness
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    sem
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Aug 12 13:10:25 GMT 2004
>Closed-Date:    Sun Jun 04 17:23:32 GMT 2006
>Last-Modified:  Sun Jun 04 17:23:32 GMT 2006
>Originator:     Alexandr Kovalenko
>Release:        FreeBSD 5.2.1-RELEASE-p7 i386
>Organization:
Mirotel ISP, http://mirotel.net/
>Environment:
System: FreeBSD xxx.mirotel.net 5.2.1-RELEASE-p7 FreeBSD 5.2.1-RELEASE-p7 #0: Mon May 24 13:01:55 EEST 2004 root@xxx.mirotel.net:/usr/obj/usr/src/sys/xxx i386

>Description:
portupgrade does not clean ports' working dir before trying to detect
BROKENness of FORBIDDENness of port. This causes a problem of incorrect
messages about brokenness in some cases.
For example - I've built samba-2.2.8a on 4.8 some time ago with option
WITH_ACL_SUPPORT turned on and didn't 'make clean'. There was no check for
FreeBSD version.

.if defined(WITH_ACL_SUPPORT)
.if ${OSVERSION} < 500018
BROKEN= "ACL support requires a recent FreeBSD 5.0-CURRENT"
.else
CONFIGURE_ARGS+=        --with-acl-support
.endif
.endif

Previous build left Makefile.inc with this option turned on. Portupgrade tries
to detect port's state do not clean it first and this causes not upgraded
version of samba to leave on system.

P.S. Sorry for my poor English

>How-To-Repeat:
Comment out check for FreeBSD version in ports/net/samba for WITH_ACL_SUPPORT
option. Build and install samba with WITH_ACL_SUPPORT option turned on.
Run portupgrade -Fv samba
>Fix:

Either:
1. Do make clean in port manually
2. Make portupgrade to clean before BROKENness check.
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->knu 
Responsible-Changed-By: vs 
Responsible-Changed-When: Thu Aug 12 15:36:09 GMT 2004 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=70365 
State-Changed-From-To: open->feedback 
State-Changed-By: daichi 
State-Changed-When: Wed Jun 22 05:47:42 GMT 2005 
State-Changed-Why:  
Over to new maintainer. 


Responsible-Changed-From-To: knu->daichi 
Responsible-Changed-By: daichi 
Responsible-Changed-When: Wed Jun 22 05:47:42 GMT 2005 
Responsible-Changed-Why:  
Grab. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=70365 
Responsible-Changed-From-To: daichi->sem 
Responsible-Changed-By: sem 
Responsible-Changed-When: Thu Jun 1 07:59:41 UTC 2006 
Responsible-Changed-Why:  
Take all portupgrade related PRs 

http://www.freebsd.org/cgi/query-pr.cgi?pr=70365 
State-Changed-From-To: feedback->open 
State-Changed-By: sem 
State-Changed-When: Fri Jun 2 10:13:52 UTC 2006 
State-Changed-Why:  
Back to open state 

http://www.freebsd.org/cgi/query-pr.cgi?pr=70365 
State-Changed-From-To: open->suspended 
State-Changed-By: sem 
State-Changed-When: Fri Jun 2 21:09:44 UTC 2006 
State-Changed-Why:  
Running 'make clean' will significatly reduce performance. Makefile.inc 
is supported not many ports and there are another ways to drive 
portupgrade crazy. E.g. /etc/make.conf 

http://www.freebsd.org/cgi/query-pr.cgi?pr=70365 
State-Changed-From-To: suspended->closed 
State-Changed-By: sem 
State-Changed-When: Sun Jun 4 17:23:30 UTC 2006 
State-Changed-Why:  
Closed 

http://www.freebsd.org/cgi/query-pr.cgi?pr=70365 
>Unformatted:
