From paul@kanar.it.ca  Wed Aug 11 05:07:34 2004
Return-Path: <paul@kanar.it.ca>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D62EE16A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 11 Aug 2004 05:07:34 +0000 (GMT)
Received: from kanar.it.ca (rogue.playpal.ca [205.233.216.20])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4B2D243D41
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 11 Aug 2004 05:07:34 +0000 (GMT)
	(envelope-from paul@kanar.it.ca)
Received: from kanar.it.ca (localhost.it.ca [127.0.0.1])
	by kanar.it.ca (8.12.10/8.12.9) with ESMTP id i7B57XMY058051;
	Wed, 11 Aug 2004 01:07:33 -0400 (EDT)
	(envelope-from paul@kanar.it.ca)
Received: (from paul@localhost)
	by kanar.it.ca (8.12.10/8.12.9/Submit) id i7B57X3U058050;
	Wed, 11 Aug 2004 01:07:33 -0400 (EDT)
Message-Id: <200408110507.i7B57X3U058050@kanar.it.ca>
Date: Wed, 11 Aug 2004 01:07:33 -0400 (EDT)
From: Paul Chvostek <paul+fbsd@it.ca>
Reply-To: Paul Chvostek <paul+fbsd@it.ca>
To: FreeBSD-gnats-submit@freebsd.org
Cc: Paul Chvostek <paul+fbsd@it.ca>, freebsd@jdc.parodius.com
Subject: [update] www/suphp: Makefile error - can't compile object files
X-Send-Pr-Version: 3.113
X-GNATS-Notify: vs

>Number:         70286
>Category:       ports
>Synopsis:       [update] www/suphp: Makefile error - can't compile object files
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Aug 11 05:10:32 GMT 2004
>Closed-Date:    Thu Aug 12 14:34:26 GMT 2004
>Last-Modified:  Thu Aug 12 14:34:26 GMT 2004
>Originator:     Paul Chvostek
>Release:        FreeBSD 5.2.1-RELEASE-p5 i386
>Organization:
>Environment:
System: FreeBSD kanar.it.ca 5.2.1-RELEASE-p5 FreeBSD 5.2.1-RELEASE-p5 #3: Thu Apr 15 18:58:14 EDT 2004 paul@kanar.it.ca:/usr/obj/usr/src/sys/kanar i386

>Description:
 This port probably wasn't test-compiled before its last commit.  It sure
 works alot better when you compile the .c files instead of the .o files.

 Note that ports/69662 is still pending.  Applying this patch before
 69662 will require further updates to 69662, but since the older patch
 needs updating anyway, this will at least get the port functional until
 the maintainer has a chance to clean everything else up.

>How-To-Repeat:
	n/a
>Fix:

diff -ruN /usr/ports/www/suphp/Makefile ./Makefile
--- /usr/ports/www/suphp/Makefile	Wed Aug  4 15:53:59 2004
+++ ./Makefile	Wed Aug 11 00:47:41 2004
@@ -7,6 +7,7 @@
 
 PORTNAME=	suphp
 PORTVERSION=	0.5.2
+PORTREVISION=	1
 CATEGORIES=	www
 MASTER_SITES=	http://www.suphp.org/download/
 
diff -ruN /usr/ports/www/suphp/files/patch-src::Makefile.in ./files/patch-src::Makefile.in
--- /usr/ports/www/suphp/files/patch-src::Makefile.in	Sat Jul 17 17:19:54 2004
+++ ./files/patch-src::Makefile.in	Wed Aug 11 00:46:17 2004
@@ -13,7 +13,7 @@
 -	$(CC) $(LDFLAGS) $(DEFS) -o suphp \
 -	 suphp.o filesystem.o check.o error.o log.o compat.o
 +suphp: ${OBJS}
-+	$(CC) $(LDFLAGS) $(DEFS) -o suphp ${OBJS}
++	$(CC) $(LDFLAGS) $(DEFS) -o suphp ${SRCS}
  
  suphp.mod:
  	@if test "$(APXS)" != "/notfound/"; then \
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: vs 
State-Changed-When: Wed Aug 11 13:16:12 GMT 2004 
State-Changed-Why:  
Forwarded PR to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=70286 

From: "Volker Stolz" <vs@freebsd.org>
To: freebsd-gnats-submit@freebsd.org, paul+fbsd@it.ca,
	freebsd@jdc.parodius.com
Cc:  
Subject: Re: ports/70286: [update] www/suphp: Makefile error - can't compile object files
Date: Wed, 11 Aug 2004 15:15:54 +0200

 Dear maintainer, please take the following PR into account.
 
 Volker

From: Jeremy Chadwick <freebsd@jdc.parodius.com>
To: Volker Stolz <vs@freebsd.org>
Cc: freebsd-gnats-submit@freebsd.org, paul+fbsd@it.ca
Subject: Re: ports/70286: [update] www/suphp: Makefile error - can't compile object files
Date: Wed, 11 Aug 2004 22:16:26 -0700

 I have examined the PR, and initially responded with a statement
 that said PR 70286 was correct.  However, I was wrong in making
 this statement.
 
 PR 70286 should be closed, as it's incorrect.  We do not need to
 change ${OBJS} to ${SRCS}.  The line in question links all of the .o
 files files together to make the suphp binary for Apache.  The .o files
 are compiled via directives at the very end of src/Makefile; ${OBJS}
 relies on ${SRCS}, and calls $(CC) on each .c file in ${SRCS}.
 
 It would make more sense to use `ld' to link the .o files together
 and make a binary.  However, this opens up a HUGE new can of worms:
 we'd have to link to libc (-lc), which sounds great, but isn't: Apache
 can be threaded, and therefore on those systems it should be linked
 with -lpthreads or -lc_r (deprecated).  The original suphp Makefile
 and configure framework doesn't check for this, which is something to
 take up with the original suphp author.  This might explain some of
 the "weirdness" going on with people using suphp with Apache 2.x who
 don't use the prefork MPM.  As I said though, that's a whole different
 can of worms...
 
 Also in addition, please close PR #69662 -- I will be submitting a
 brand new and fresh PR in a few minutes that will provide everything
 necessary (including a proper unified diff for everything).
 
 Thanks!
 
 -- 
 | Jeremy Chadwick                                 jdc at parodius.com |
 | Parodius Networking                        http://www.parodius.com/ |
 | UNIX Systems Administrator                   Mountain View, CA, USA |
 | Making life hard for others since 1977.                             |
 
 On Wed, Aug 11, 2004 at 03:15:54PM +0200, Volker Stolz wrote:
 > Dear maintainer, please take the following PR into account.
 > 
 > Volker
State-Changed-From-To: feedback->patched 
State-Changed-By: vs 
State-Changed-When: Thu Aug 12 13:30:27 GMT 2004 
State-Changed-Why:  
Maintainer believes this has been fixed in ports/70345. Does this solve 
your problem? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=70286 
State-Changed-From-To: patched->closed 
State-Changed-By: vs 
State-Changed-When: Thu Aug 12 14:34:02 GMT 2004 
State-Changed-Why:  
Resolved by maintainer update. Thanks for  your submission! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=70286 
>Unformatted:
