From ahze@gentoo.ahze.net  Fri Aug  6 00:48:08 2004
Return-Path: <ahze@gentoo.ahze.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6BD3E16A4DA
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  6 Aug 2004 00:48:08 +0000 (GMT)
Received: from imf18aec.mail.bellsouth.net (imf18aec.mail.bellsouth.net [205.152.59.66])
	by mx1.FreeBSD.org (Postfix) with ESMTP id EE02B43D3F
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  6 Aug 2004 00:48:07 +0000 (GMT)
	(envelope-from ahze@gentoo.ahze.net)
Received: from gentoo.ahze.net ([68.209.163.3])
          by imf18aec.mail.bellsouth.net
          (InterMail vM.5.01.06.08 201-253-122-130-108-20031117) with ESMTP
          id <20040806004806.RYZQ1786.imf18aec.mail.bellsouth.net@gentoo.ahze.net>;
          Thu, 5 Aug 2004 20:48:06 -0400
Received: (from root@localhost)
	by gentoo.ahze.net (8.12.11/8.13.1/Submit) id i760m5As035169;
	Thu, 5 Aug 2004 20:48:05 -0400 (EDT)
	(envelope-from ahze)
Message-Id: <200408060048.i760m5As035169@gentoo.ahze.net>
Date: Thu, 5 Aug 2004 20:48:05 -0400 (EDT)
From: Michael Johnson <ahze@ahze.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc: dom@helenmarks.co.uk
Subject: [PATCH] devel/distcc: [enable ipv6]
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         70059
>Category:       ports
>Synopsis:       [PATCH] devel/distcc: [enable ipv6]
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug 06 00:50:06 GMT 2004
>Closed-Date:    Wed Aug 18 07:42:13 GMT 2004
>Last-Modified:  Wed Aug 18 07:42:13 GMT 2004
>Originator:     Michael Johnson
>Release:        FreeBSD 5.2-CURRENT i386
>Organization:
>Environment:
System: FreeBSD gentoo.ahze.net 5.2-CURRENT FreeBSD 5.2-CURRENT #59: Wed Aug  4 20:56:05 EDT
>Description:
- add option to enable ipv6

Port maintainer (dom@helenmarks.co.uk) is cc'd.

Generated with FreeBSD Port Tools 0.50
>How-To-Repeat:
>Fix:

--- distcc-2.16.patch begins here ---
Index: Makefile
===================================================================
RCS file: /usr/opt/cvs/freebsd-src/ports/devel/distcc/Makefile,v
retrieving revision 1.42
diff -u -r1.42 Makefile
--- Makefile	28 Jul 2004 18:32:05 -0000	1.42
+++ Makefile	6 Aug 2004 00:45:11 -0000
@@ -7,7 +7,7 @@
 
 PORTNAME=	distcc
 PORTVERSION=	2.16
-CATEGORIES=	devel
+CATEGORIES=	devel ipv6
 MASTER_SITES=	http://distcc.samba.org/ftp/distcc/
 
 MAINTAINER=	dom@helenmarks.co.uk
@@ -24,7 +24,8 @@
 DISTCCD_PIDFILE=/var/run/distccd.pid
 
 OPTIONS=	GNOME "Build GUI monitor based on GNOME" Off \
-		GTK "Build GUI monitor based on GTK" Off
+		GTK "Build GUI monitor based on GTK" Off \
+		IPV6 "Enable IPV6" off
 
 .include <bsd.port.pre.mk>
 
@@ -42,6 +43,10 @@
 PLIST_SUB+=	WITH_GNOME="@comment "
 .endif
 
+.if defined(WITH_IPV6)
+CONFIGURE_ARGS+=	--enable-rfc2553
+.endif
+
 MAN1=		distcc.1 distccd.1
 DOC_FILES=	AUTHORS INSTALL NEWS README \
 		doc/protocol-1.txt doc/status-1.txt \
--- distcc-2.16.patch ends here ---

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: vs 
State-Changed-When: Wed Aug 11 19:14:47 GMT 2004 
State-Changed-Why:  
Forwarded PR to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=70059 

From: "Volker Stolz" <vs@freebsd.org>
To: freebsd-gnats-submit@freebsd.org, ahze@ahze.net,
	dom@helenmarks.co.uk
Cc:  
Subject: Re: ports/70059: [PATCH] devel/distcc: [enable ipv6]
Date: Wed, 11 Aug 2004 21:15:26 +0300

 Dear maintainer, please review the proposed patch.
 
 Volker

From: dom@helenmarks.co.uk
To: "Volker Stolz" <vs@freebsd.org>
Cc: freebsd-gnats-submit@freebsd.org, ahze@ahze.net
Subject: Re: ports/70059: [PATCH] devel/distcc: [enable ipv6]
Date: Wed, 11 Aug 2004 22:06:29 +0100 (BST)

 > Dear maintainer, please review the proposed patch.
 >
 > Volker
 >
 
 Please commit it.
 
 Thank you,
 Dominic

From: "Volker Stolz" <vs@freebsd.org>
To: freebsd-gnats-submit@freebsd.org, ahze@ahze.net,
	dom@helenmarks.co.uk
Cc:  
Subject: Re: ports/70059: [PATCH] devel/distcc: [enable ipv6]
Date: Thu, 12 Aug 2004 16:56:00 +0200

 Looks like IPv6 won't work on 4.X:
 
 ===>  Building for distcc-2.16
 cc -I/usr/local/include -DHAVE_CONFIG_H -D_GNU_SOURCE -I./src  
 -DSYSCONFDIR="\"/usr/local/etc\""  
 -DPKGDATADIR="\"/usr/local/share/distcc\"" -Isrc -I./lzo -O -pipe -g  -W  
 -Wall -Wimplicit -Wshadow -Wpointer-arith -Wcast-align -Wwrite-strings  
 -Waggregate-return -Wstrict-prototypes -Wmissing-prototypes  
 -Wnested-externs -o src/backoff.o -c src/backoff.c
 In file included from src/backoff.c:43:
 src/distcc.h:157: #error You can't use RFC2553 because you don't have a  
 sockaddr_storage type
 gmake: *** [src/backoff.o] Error 1
 *** Error code 2
 
 Unluckily, there's no way to hide the option since we'd have to include  
 bsd.port.pre.mk before
 setting the OPTIONS to test OSVERSION. But bsd.port.pre.mk must be  
 included after OPTIONS for
 them to work. I'll adapt the comment. How about:
 
 IPV6 "Enable IPV6 (will fail on 4.X)" off
 
 Volker

From: dom@helenmarks.co.uk
To: "Volker Stolz" <vs@freebsd.org>
Cc: freebsd-gnats-submit@freebsd.org, ahze@ahze.net,
	dom@helenmarks.co.uk
Subject: Re: ports/70059: [PATCH] devel/distcc: [enable ipv6]
Date: Thu, 12 Aug 2004 17:29:49 +0100 (BST)

 > Looks like IPv6 won't work on 4.X:
 >
 > ===>  Building for distcc-2.16
 > cc -I/usr/local/include -DHAVE_CONFIG_H -D_GNU_SOURCE -I./src
 > -DSYSCONFDIR="\"/usr/local/etc\""
 > -DPKGDATADIR="\"/usr/local/share/distcc\"" -Isrc -I./lzo -O -pipe -g  -W
 > -Wall -Wimplicit -Wshadow -Wpointer-arith -Wcast-align -Wwrite-strings
 > -Waggregate-return -Wstrict-prototypes -Wmissing-prototypes
 > -Wnested-externs -o src/backoff.o -c src/backoff.c
 > In file included from src/backoff.c:43:
 > src/distcc.h:157: #error You can't use RFC2553 because you don't have a
 > sockaddr_storage type
 > gmake: *** [src/backoff.o] Error 1
 > *** Error code 2
 >
 > Unluckily, there's no way to hide the option since we'd have to include
 > bsd.port.pre.mk before
 > setting the OPTIONS to test OSVERSION. But bsd.port.pre.mk must be
 > included after OPTIONS for
 > them to work. I'll adapt the comment. How about:
 >
 > IPV6 "Enable IPV6 (will fail on 4.X)" off
 >
 > Volker
 >
 
 Fine by me, it's lucky you have some 4.x machines :-)
 
 Thanks,
 Dominic
 

From: michael johnson <ahze@ahze.net>
To: dom@helenmarks.co.uk, freebsd-gnats-submit@freebsd.org,
	Volker Stolz <vs@freebsd.org>
Cc:  
Subject: Re: ports/70059: [PATCH] devel/distcc: [enable ipv6]
Date: Thu, 12 Aug 2004 20:00:15 -0400

 I'm just shooting ideas up, but how about maybe something like the 
 following,..
 
 OPTIONS=	# leave blank to enable work around bsd.port.pre.mk
 
 .include <bsd.port.pre.mk>
 
 .if ${OSVERSION} > 500000
 OPTIONS=	IPV6 "etc etc" off
 .endif
 
 
 Michael
 
 
 On Aug 12, 2004, at 10:56 AM, Volker Stolz wrote:
 
 > Looks like IPv6 won't work on 4.X:
 >
 > ===>  Building for distcc-2.16
 > cc -I/usr/local/include -DHAVE_CONFIG_H -D_GNU_SOURCE -I./src 
 > -DSYSCONFDIR="\"/usr/local/etc\"" 
 > -DPKGDATADIR="\"/usr/local/share/distcc\"" -Isrc -I./lzo -O -pipe -g  
 > -W -Wall -Wimplicit -Wshadow -Wpointer-arith -Wcast-align 
 > -Wwrite-strings -Waggregate-return -Wstrict-prototypes 
 > -Wmissing-prototypes -Wnested-externs -o src/backoff.o -c 
 > src/backoff.c
 > In file included from src/backoff.c:43:
 > src/distcc.h:157: #error You can't use RFC2553 because you don't have 
 > a sockaddr_storage type
 > gmake: *** [src/backoff.o] Error 1
 > *** Error code 2
 >
 > Unluckily, there's no way to hide the option since we'd have to 
 > include bsd.port.pre.mk before
 > setting the OPTIONS to test OSVERSION. But bsd.port.pre.mk must be 
 > included after OPTIONS for
 > them to work. I'll adapt the comment. How about:
 >
 > IPV6 "Enable IPV6 (will fail on 4.X)" off
 >
 > Volker
 >
 
State-Changed-From-To: feedback->closed 
State-Changed-By: vs 
State-Changed-When: Wed Aug 18 07:41:21 GMT 2004 
State-Changed-Why:  
Committed, thanks! I didn't try the OPTIONS-hack, though: 
Such things tend to blow up in your face sooner or later. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=70059 
>Unformatted:
