From ahze@gentoo.ahze.net  Fri Jul 30 23:40:49 2004
Return-Path: <ahze@gentoo.ahze.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2219C16A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 30 Jul 2004 23:40:49 +0000 (GMT)
Received: from imf23aec.mail.bellsouth.net (imf23aec.mail.bellsouth.net [205.152.59.71])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4C1FF43D2F
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 30 Jul 2004 23:40:48 +0000 (GMT)
	(envelope-from ahze@gentoo.ahze.net)
Received: from gentoo.ahze.net ([68.209.163.3])
          by imf23aec.mail.bellsouth.net
          (InterMail vM.5.01.06.08 201-253-122-130-108-20031117) with ESMTP
          id <20040730234040.OLSX1787.imf23aec.mail.bellsouth.net@gentoo.ahze.net>;
          Fri, 30 Jul 2004 19:40:40 -0400
Received: (from root@localhost)
	by gentoo.ahze.net (8.12.11/8.12.11/Submit) id i6UNeedV083408;
	Fri, 30 Jul 2004 19:40:40 -0400 (EDT)
	(envelope-from ahze)
Message-Id: <200407302340.i6UNeedV083408@gentoo.ahze.net>
Date: Fri, 30 Jul 2004 19:40:40 -0400 (EDT)
From: Michael Johnson <ahze@ahze.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc: hendrik@scholz.net
Subject: [PATCH] multimedia/transcode: [add jpeg-mmx support]
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         69832
>Category:       ports
>Synopsis:       [PATCH] multimedia/transcode: [add jpeg-mmx support]
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ahze
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jul 30 23:50:27 GMT 2004
>Closed-Date:    Wed Nov 17 22:12:17 GMT 2004
>Last-Modified:  Wed Nov 17 22:12:17 GMT 2004
>Originator:     Michael Johnson
>Release:        FreeBSD 5.2-CURRENT i386
>Organization:
>Environment:
System: FreeBSD gentoo.ahze.net 5.2-CURRENT FreeBSD 5.2-CURRENT #58: Fri Jul 23 20:15:17 EDT 2004
>Description:
- add jpeg-mmx support with knob


pr-69829 needs to commited first.

Port maintainer (hendrik@scholz.net) is cc'd.

Generated with FreeBSD Port Tools 0.50
>How-To-Repeat:
>Fix:

--- transcode-0.6.12_1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /usr/opt/cvs/freebsd-src/ports/multimedia/transcode/Makefile,v
retrieving revision 1.43
diff -u -r1.43 Makefile
--- Makefile	26 Jun 2004 04:31:27 -0000	1.43
+++ Makefile	30 Jul 2004 23:35:12 -0000
@@ -107,6 +107,11 @@
 WITH_DIVX5=	yes
 .endif
 
+.if exists(${LOCALBASE}/lib/libjpeg-mmx.so.62)
+WITH_JPEGMMX=	yes
+WITH_NASM=	yes
+.endif
+
 .if defined(WITH_LIBTHEORA)
 LIB_DEPENDS+=	theora.0:${PORTSDIR}/graphics/libtheora
 .else
@@ -245,6 +250,14 @@
 .else
 .endif
 
+.if defined(WITH_JPEGMMX)
+LIB_DEPENDS+=	jpeg-mmx.62:${PORTSDIR}/graphics/jpeg-mmx
+
+PLIST_SUB+=	WITH_JPEGMMX=""
+.else
+PLIST_SUB+=	WITH_JPEGMMX="@comment "
+.endif
+
 pre-everything::
 .if !defined(WITH_OPTIMIZED_CFLAGS)
 	@${ECHO_MSG}
@@ -333,6 +346,10 @@
 	@${ECHO_MSG}
 	@${ECHO_MSG} "You can enable experimental DivX 5 support by defining WITH_DIVX5."
 .endif
+.if !defined(WITH_JPEGMMX)
+	@${ECHO_MSG}
+	@${ECHO_MSG} "You can enable JPEG with MMX by defining WITH_JPEGMMX."
+.endif
 
 post-patch:
 .if ${OSVERSION} <= 500027
Index: pkg-plist
===================================================================
RCS file: /usr/opt/cvs/freebsd-src/ports/multimedia/transcode/pkg-plist,v
retrieving revision 1.19
diff -u -r1.19 pkg-plist
--- pkg-plist	20 Jun 2004 20:03:47 -0000	1.19
+++ pkg-plist	30 Jul 2004 23:33:55 -0000
@@ -71,6 +71,7 @@
 lib/transcode/filter_denoise3d.so
 lib/transcode/filter_detectclipping.so
 lib/transcode/filter_detectsilence.so
+%%WITH_JPEGMMX%%lib/transcode/filter_dilyuvmmx.so
 lib/transcode/filter_divxkey.so
 lib/transcode/filter_doublefps.so
 lib/transcode/filter_dnr.so
--- transcode-0.6.12_1.patch ends here ---

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: vs 
State-Changed-When: Mon Aug 30 09:53:33 GMT 2004 
State-Changed-Why:  
Forwarded PR to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=69832 

From: "Volker Stolz" <vs@freebsd.org>
To: freebsd-gnats-submit@freebsd.org, ahze@ahze.net,
	hendrik@scholz.net
Cc:  
Subject: Re: ports/69832: [PATCH] multimedia/transcode: [add jpeg-mmx support]
Date: Mon, 30 Aug 2004 11:53:13 +0200

 Dear maintainer, please review the proposed patch!
 
 Volker

From: Hendrik Scholz <hscholz@raisdorf.net>
To: Volker Stolz <vs@freebsd.org>
Cc: freebsd-gnats-submit@freebsd.org, ahze@ahze.net,
	hendrik@scholz.net
Subject: Re: ports/69832: [PATCH] multimedia/transcode: [add jpeg-mmx support]
Date: Mon, 30 Aug 2004 13:55:35 +0200

 Hi!
 
 Volker Stolz wrote:
 > Dear maintainer, please review the proposed patch!
 
 I've just tested it. Works.
 
 Thanks,
 	Hendrik
 
 -- 
 Hendrik Scholz - <hscholz@raisdorf.net> - http://www.wormulon.net/
 drag me, drop me - treat me like an object
State-Changed-From-To: feedback->suspended 
State-Changed-By: vs 
State-Changed-When: Mon Aug 30 12:08:56 GMT 2004 
State-Changed-Why:  
Suspend until ports/69829 is committed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=69832 

From: Michael Johnson <ahze@ahze.net>
To: freebsd-gnats-submit@FreeBSD.org
Cc: Hendrik Scholz <hscholz@raisdorf.net>,
	michael johnson <ahze@ahze.net>, Volker Stolz <vs@freebsd.org>
Subject: Re: ports/69832: [PATCH] multimedia/transcode: [add jpeg-mmx support]
Date: Mon, 30 Aug 2004 09:40:03 -0400

 Hi,
 
 I see a problem with my patch.
 
 in the part that reads
 
 .if exists(${LOCALBASE}/lib/libjpeg-mmx.so.62)
 WITH_JPEGMMX=  yes
 WITH_NASM=     yes
 .endif
 
 it probably should be the following because you can define WITH_JPEGMMX 
 and not have nasm installed.
 
 .if exists(${LOCALBASE}/lib/libjpeg-mmx.so.62)
 WITH_JPEGMMX= 	yes
 .endif
 
 .if defined(WITH_JPEGMMX)
 WITH_NASM=	yes
 .endif
 
 Michael
 

From: Hendrik Scholz <hscholz@raisdorf.net>
To: Michael Johnson <ahze@ahze.net>
Cc: freebsd-gnats-submit@FreeBSD.org, Volker Stolz <vs@freebsd.org>
Subject: Re: ports/69832: [PATCH] multimedia/transcode: [add jpeg-mmx support]
Date: Mon, 30 Aug 2004 15:51:28 +0200

 Hi!
 
 Michael Johnson wrote:
 > it probably should be the following because you can define WITH_JPEGMMX 
 > and not have nasm installed.
 
 JPEGMMX has NASM as build depends and is only for i386.
 With WITH_JPEGMMX turned on it turns transcode into a i386 only port.
 WITH_NASM implies ONLY_FOR_ARCHES=i386 so it's been taken care of as of now.
 
 You are right about the fact that one can build transcode without having
 nasm installed but still having WITH_JPEGMMX (probably installed as 
 binary package).
 
 Your second part makes sense but I'd add ONLY_FOR_ARCHES= i386:
 
 .if exists(${LOCALBASE}/lib/libjpeg-mmx.so.62)
 WITH_JPEGMMX=     yes
 ONLY_FOR_ARCHES=	i386
 .endif
 
 Hendrik
 
 -- 
 Hendrik Scholz - <hscholz@raisdorf.net> - http://www.wormulon.net/
 drag me, drop me - treat me like an object

From: Ceri Davies <ceri@FreeBSD.org>
To: FreeBSD Gnats Submit <freebsd-gnats-submit@FreeBSD.org>
Cc:  
Subject: Re: ports/69832: [PATCH] multimedia/transcode: [add jpeg-mmx support]
Date: Fri, 29 Oct 2004 10:44:21 +0100

 Adding to audit trail, from misfiled PR ports/72843:
 
 Date: Mon, 18 Oct 2004 22:02:39 +0200
 From: Hendrik Scholz <hscholz@raisdorf.net>
 Message-Id: <4174215F.1030600@raisdorf.net>
 References: <200410162319.i9GNJYfE066651@blueheron.ahze.net>
 
  Hi!
  
  Michael Johnson wrote:
  > make WITH_FFMPEG=yes WITH_OPTIMIZED_CFLAGS=yes 
  
  I couldn't reproduce the problem. I've compiled transcode on 
  5.3-BETA7/i386 and even with -O3 it compiled fine.
  Do you have any additional options in /etc/make.conf?
  
  I've tested the patch ... it doesn't harm anything but I never got any 
  reports on similar problems so I'm not sure if it's a general problem.
  
  Thanks,
  	Hendrik
  
  -- 
  Hendrik Scholz - <hscholz@raisdorf.net> - http://www.wormulon.net/
  drag me, drop me - treat me like an object
 

From: Ceri Davies <ceri@FreeBSD.org>
To: FreeBSD Gnats Submit <freebsd-gnats-submit@FreeBSD.org>
Cc:  
Subject: Re: ports/69832: [PATCH] multimedia/transcode: [add jpeg-mmx support]
Date: Fri, 29 Oct 2004 10:47:25 +0100

 Adding to audit trail, from misfiled PR ports/72846:
 
 Date: Mon, 18 Oct 2004 16:18:11 -0400
 From: Michael Johnson <ahze@ahze.net>
 Message-Id: <D53478A5-2142-11D9-9C89-000A958C81C6@ahze.net>
 References: <200410162319.i9GNJYfE066651@blueheron.ahze.net> <4174215F.1030600@raisdorf.net>
 
  Hi Hendrik!
  
  After seeing what you wrote I did farther tests and figured out that
  I built ffmpeg with OUT WITH_OPTIMIZED_CFLAGS defined
  and transcode with WITH_OPTIMIZED_CFLAGS defined
  and that seems to be the problem.
  
    since this is such a rare case I dont think we need to do anything
    to transcode at all and just close this pr.
  
  Michael
  

From: Ceri Davies <ceri@FreeBSD.org>
To: FreeBSD Gnats Submit <freebsd-gnats-submit@FreeBSD.org>
Cc:  
Subject: Re: ports/69832: [PATCH] multimedia/transcode: [add jpeg-mmx support]
Date: Fri, 29 Oct 2004 10:48:42 +0100

 Adding to audit trail, from misfiled PR ports/72847:
 
 Date: Mon, 18 Oct 2004 16:21:38 -0400
 From: Michael Johnson <ahze@ahze.net>
 Message-Id: <50E04292-2143-11D9-9C89-000A958C81C6@ahze.net>
 References: <200410162319.i9GNJYfE066651@blueheron.ahze.net> <4174215F.1030600@raisdorf.net>
 
  oh, and btw, everything works  with the following
  
  define WITH_OPTIMIZED_CFLAGS on ffmpeg and transcode
  
  or
  
  define WITH_OPTIMIZED_CFLAGS on ffmpeg and not transcode
  
  but fails with
  
  define WITH_OPTIMIZED_CLFAGS on transcode and not ffmpeg
  
  Michael
  
Responsible-Changed-From-To: freebsd-ports-bugs->ahze 
Responsible-Changed-By: ahze 
Responsible-Changed-When: Fri Oct 29 12:49:16 GMT 2004 
Responsible-Changed-Why:  
handle 

http://www.freebsd.org/cgi/query-pr.cgi?pr=69832 
State-Changed-From-To: suspended->feedback  
State-Changed-By: ahze 
State-Changed-When: Sat Oct 30 21:50:31 GMT 2004 
State-Changed-Why:  
Asked maintainer for feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=69832 

From: Michael Johnson <ahze@ahze.net>
To: freebsd-gnats-submit@FreeBSD.org
Cc: hendrik@scholz.net
Subject: Re: ports/69832: [PATCH] multimedia/transcode: [add jpeg-mmx support]
Date: Sat, 30 Oct 2004 17:50:22 -0400

 --Apple-Mail-32-606738514
 Content-Transfer-Encoding: 7bit
 Content-Type: text/plain; charset=US-ASCII; format=flowed
 
 Please see http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/69832
 do you approve this patch?
 
 Michael
 
 --Apple-Mail-32-606738514
 content-type: application/pgp-signature; x-mac-type=70674453;
 	name=PGP.sig
 content-description: This is a digitally signed message part
 content-disposition: inline; filename=PGP.sig
 content-transfer-encoding: 7bit
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.4 (Darwin)
 
 iD8DBQFBhAyen4uqfTwEb9YRAlISAJ990GkIJliwsUDQsqSTHBbmX1Co1QCgmWlD
 nfgExP5OEnZdxRPolXA1Al0=
 =vE3n
 -----END PGP SIGNATURE-----
 
 --Apple-Mail-32-606738514--
 

From: Hendrik Scholz <hscholz@raisdorf.net>
To: Michael Johnson <ahze@ahze.net>
Cc: freebsd-gnats-submit@FreeBSD.org, hendrik@scholz.net
Subject: Re: ports/69832: [PATCH] multimedia/transcode: [add jpeg-mmx support]
Date: Sun, 31 Oct 2004 18:24:18 +0100

 Hi!
 
 Yes, approved.
 
 Thanks,
 	Hendrik
 
 -- 
 Hendrik Scholz - <hscholz@raisdorf.net> - http://www.wormulon.net/
 drag me, drop me - treat me like an object
State-Changed-From-To: feedback->closed  
State-Changed-By: ahze 
State-Changed-When: Wed Nov 17 22:12:05 GMT 2004 
State-Changed-Why:  
Committed 

http://www.freebsd.org/cgi/query-pr.cgi?pr=69832 
>Unformatted:
