From jdc@pentarou.parodius.com  Mon Jul 26 16:54:20 2004
Return-Path: <jdc@pentarou.parodius.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7708916A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 26 Jul 2004 16:54:20 +0000 (GMT)
Received: from mail.parodius.com (mail.parodius.com [64.62.145.229])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6376143D46
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 26 Jul 2004 16:54:20 +0000 (GMT)
	(envelope-from jdc@pentarou.parodius.com)
Received: from pentarou.parodius.com (jdc@localhost [127.0.0.1])
	by mail.parodius.com (8.12.11/8.12.11) with ESMTP id i6QGrrVs068983
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 26 Jul 2004 09:53:53 -0700 (PDT)
	(envelope-from jdc@pentarou.parodius.com)
Received: (from jdc@localhost)
	by pentarou.parodius.com (8.12.11/8.12.11/Submit) id i6QGrriu068982;
	Mon, 26 Jul 2004 09:53:53 -0700 (PDT)
	(envelope-from jdc)
Message-Id: <200407261653.i6QGrriu068982@pentarou.parodius.com>
Date: Mon, 26 Jul 2004 09:53:53 -0700 (PDT)
From: Jeremy Chadwick <freebsd@jdc.parodius.com>
Reply-To: Jeremy Chadwick <freebsd@jdc.parodius.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: suphp 0.5.2 -- Sanity check for older FreeBSD 4.x systems
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         69624
>Category:       ports
>Synopsis:       suphp 0.5.2 -- Sanity check for older FreeBSD 4.x systems
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 26 17:00:39 GMT 2004
>Closed-Date:    Tue Jul 27 07:49:15 GMT 2004
>Last-Modified:  Tue Jul 27 07:49:15 GMT 2004
>Originator:     Jeremy Chadwick
>Release:        FreeBSD 4.10-PRERELEASE i386
>Organization:
Parodius Networking
>Environment:
System: FreeBSD pentarou.parodius.com 4.10-PRERELEASE FreeBSD 4.10-PRERELEASE #0: Wed May 5 03:33:17 PDT 2004 root@pentarou.parodius.com:/usr/obj/usr/src/sys/PENTAROU i386
>Description:
	I've been getting a lot of Email recently from FreeBSD users who are
	trying to use this port on systems which lack the -C capability of
	make(1) (i.e. systems  before FreeBSD 4.9-RELEASE).  4.9-RELEASE added a
	proper and working -C flag for make(1), which is what this port relies on.
	This was addressed in PR bin/50981 (and subsequently some others).

	Below patch adds a sanity check to ensure that people are using a version
	of FreeBSD that's at least a little more up-to-date.  Folks can upgrade
	make(1) by itself if necessary, but generally speaking, one should update
	to 4.10 anyways.
>How-To-Repeat:
	Run "make" on a system which lacks make -C.
>Fix:
	Apply below patch to ports/www/suphp/Makefile.


--- Makefile.orig	Thu Jul 15 15:13:36 2004
+++ Makefile	Mon Jul 26 09:49:04 2004
@@ -58,6 +58,14 @@
 
 .include <bsd.port.pre.mk>
 
+##
+## Sanity check; -C flag for make(1) was added in 4.8, but was not
+## fully fixed until shortly before 4.9-RELEASE.  We need -C !
+##
+.if ${OSVERSION} < 490000
+BROKEN=	Please upgrade to FreeBSD 4.9-RELEASE or higher \(see PR bin/50981\).
+.endif
+
 .if exists(${LOCALBASE}/include/apache2/apr.h) || defined(WITH_APACHE2)
 APACHE_PORT=	www/apache2
 PLIST_SUB+=	MODULEDIR="libexec/apache2/"
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: vs 
State-Changed-When: Tue Jul 27 07:48:56 GMT 2004 
State-Changed-Why:  
Committed, thanks! What a pity that there's no workaround, though. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=69624 
>Unformatted:
