From roth@secure.socket.ch  Mon Jul 19 14:16:19 2004
Return-Path: <roth@secure.socket.ch>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id F214716A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 19 Jul 2004 14:16:19 +0000 (GMT)
Received: from secure.socket.ch (secure.socket.ch [212.254.206.213])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1C80A43D49
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 19 Jul 2004 14:16:19 +0000 (GMT)
	(envelope-from roth@secure.socket.ch)
Received: from secure.socket.ch (localhost [127.0.0.1])
	by secure.socket.ch (8.12.10/8.12.5) with ESMTP id i6JEGH2I010272
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 19 Jul 2004 16:16:17 +0200 (CEST)
	(envelope-from roth@secure.socket.ch)
Received: (from roth@localhost)
	by secure.socket.ch (8.12.10/8.12.5/Submit) id i6JEGCC8010271;
	Mon, 19 Jul 2004 16:16:12 +0200 (CEST)
Message-Id: <200407191416.i6JEGCC8010271@secure.socket.ch>
Date: Mon, 19 Jul 2004 16:16:12 +0200 (CEST)
From: Tobias Roth <ports@fsck.ch>
Reply-To: Tobias Roth <ports@fsck.ch>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] missing dependency for www/linux-flashplugin
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         69299
>Category:       ports
>Synopsis:       [PATCH] missing dependency for www/linux-flashplugin
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 19 14:20:18 GMT 2004
>Closed-Date:    Thu Dec 23 10:49:04 GMT 2004
>Last-Modified:  Thu Dec 23 10:49:04 GMT 2004
>Originator:     Tobias Roth
>Release:        FreeBSD 5.2-CURRENT i386
>Organization:
>Environment:
System: FreeBSD localhost 5.2-CURRENT FreeBSD 5.2-CURRENT #10: Wed May 26 19:30:57 CEST 2004 toor@localhost:/usr/obj/usr/src/sys/FOOBAR i386

>Description:
www/linux-flashplugin misses the dependency devel/linuxthreads.

>How-To-Repeat:
install www/linux-flashplugin, possibly together with www/linuxpluginwrapper,
and make sure you do not have devel/linuxthreads. run your browser and
verify that the plugin does not work. then install devel/linuxthreads and
verify that everthing works fine now.

>Fix:
--- Makefile.orig       Mon Jul 19 15:59:46 2004
+++ Makefile    Mon Jul 19 16:04:19 2004
@@ -17,6 +17,14 @@
 MAINTAINER=    ports@brandon.dvalentine.com
 COMMENT=       The official Macromedia Flash Player for Linux Mozilla and Netscape 6+
 
+.include <bsd.port.pre.mk>
+
+.if ${OSVERSION} >= 500035
+LIB_DEPENDS=   lthread.3:${PORTSDIR}/devel/linuxthreads
+.else
+LIB_DEPENDS=   lthread.2:${PORTSDIR}/devel/linuxthreads
+.endif
+
 ONLY_FOR_ARCHS=        i386
 USE_LINUX=     yes
 
@@ -47,4 +55,4 @@
        @${INSTALL_DATA} ${WRKSRC}/readme.htm ${DOCSDIR}
 .endif
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: vs 
State-Changed-When: Mon Jul 19 20:13:27 GMT 2004 
State-Changed-Why:  
Forwarded PR to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=69299 

From: "Volker Stolz" <vs@freebsd.org>
To: freebsd-gnats-submit@freebsd.org, ports@fsck.ch,
	ports@brandon.dvalentine.com
Cc:  
Subject: Re: ports/69299: [PATCH] missing dependency for www/linux-flashplugin
Date: Mon, 19 Jul 2004 22:11:41 +0300

 Dear maintainer, please review the proposed patch!
 
 Volker

From: "Brandon D. Valentine" <ports@brandon.dvalentine.com>
To: Volker Stolz <vs@freebsd.org>
Cc: freebsd-gnats-submit@freebsd.org, ports@fsck.ch
Subject: Re: ports/69299: [PATCH] missing dependency for www/linux-flashplugin
Date: Wed, 21 Jul 2004 10:31:59 -0500

 On Mon, Jul 19, 2004 at 10:11:41PM +0300, Volker Stolz wrote:
 > Dear maintainer, please review the proposed patch!
 
 There is no such dependency on devel/linuxthreads.
 
   506 dallben:/home/bandix% pkg_info -r `pkg_glob linuxpluginwrapper`
   Information for linuxpluginwrapper-20040310_1:
   
   Depends on:
   Dependency: pkgconfig-0.15.0_1
   Dependency: perl-5.8.4
   Dependency: freetype2-2.1.7_3
   Dependency: linux_base-7.1_7
   Dependency: expat-1.95.7
   Dependency: imake-4.3.0_2
   Dependency: fontconfig-2.2.3,1
   Dependency: XFree86-libraries-4.3.0_7
   Dependency: open-motif-2.2.2_2
   Dependency: acroread-5.08
   Dependency: linux-flashplugin-6.0r79
   507 dallben:/home/bandix% pkg_info | grep linuxthreads
   508 dallben:/home/bandix%
   
 Plugin works just fine in Mozilla.  It is my belief that the submitter
 has misconfigured his libmap.conf(5), not following the recommendations
 of linuxpluginwrapper's pkg-message.  Unless the submitter can provide
 some proof (i.e. ldd output) supporting his claim of a linuxthreads
 dependency, I am going to reject this patch.
 
 Thanks,
 
 Brandon D. Valentine
 -- 
 brandon@dvalentine.com                           http://www.geekpunk.net
 Pseudo-Random Googlism:  beer is now a health food
Responsible-Changed-From-To: freebsd-ports-bugs->vs 
Responsible-Changed-By: vs 
Responsible-Changed-When: Thu Jul 22 07:18:55 GMT 2004 
Responsible-Changed-Why:  
I'll see this PR through. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=69299 

From: "Brandon D. Valentine" <ports@brandon.dvalentine.com>
To: Volker Stolz <vs@freebsd.org>
Cc: freebsd-gnats-submit@freebsd.org, ports@fsck.ch
Subject: Re: ports/69299: [PATCH] missing dependency for www/linux-flashplugin
Date: Mon, 2 Aug 2004 15:12:51 -0500

 On Wed, Jul 21, 2004 at 10:31:59AM -0500, Brandon D. Valentine wrote:
 > On Mon, Jul 19, 2004 at 10:11:41PM +0300, Volker Stolz wrote:
 > > Dear maintainer, please review the proposed patch!
 > 
 > There is no such dependency on devel/linuxthreads.
 >   
 > It is my belief that the submitter has misconfigured his
 > libmap.conf(5), not following the recommendations of
 > linuxpluginwrapper's pkg-message.  Unless the submitter can provide
 > some proof (i.e. ldd output) supporting his claim of a linuxthreads
 > dependency, I am going to reject this patch.
 
 I have deduced the source of the submitter's confusion about the
 dependency on linuxthreads.  I thought I'd add it here while the PR is
 still in the feedback state in case someone else is experiencing the
 same problem in the future.
 
 The linux-flashplugin6 binary is linked against libpthread.so.0.  As the
 linuxpluginwrapper port was originally committed it included a
 dependency on linuxthreads in LIB_DEPENDS and the pkg-message told users
 to map libpthread.so.0 to liblthread.so.3 in libmap.conf.  On Feb 29
 2004 nork made a commit updating linuxpluginwrapper to a newer version
 that worked with FreeBSD's libpthread.  In this commit he removed the
 LIB_DEPENDS for linuxthreads and updated the pkg-message telling people:
 
   ** PLEASE CHANGE FOLLOWING LINES FROM /etc/libmap.conf **
   libpthread.so.0			liblthread.so.3
   	to
   libpthread.so.0			pluginwrapper/flash6.so
 
 The PR submitter seems to have missed this change.
 
 HTH,
 
 Brandon D. Valentine
 -- 
 brandon@dvalentine.com                           http://www.geekpunk.net
 Pseudo-Random Googlism:  valentine is an accomplished performer who
                          wears many hats

From: Tobias Roth <ports@fsck.ch>
To: "Brandon D. Valentine" <ports@brandon.dvalentine.com>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/69299: [PATCH] missing dependency for www/linux-flashplugin
Date: Mon, 2 Aug 2004 23:07:39 +0200

 did you even bother to look at the "How-To-Repeat" section? it says that
 with linuxthreads, the plugin works for me. without, it doesn't. and other
 linuxplugin-wrapped plugins do work even without linuxthreads. i know that
 this is not a proof of a missing dependency, but only a strong evidence.
 
 since you are absolutely sure that there is no such dependency, i am
 happy if this PR gets closed. but for future reference, please refrain
 from using remarks such as "the submitter's confusion". i have a name you
 can adress me with, i am not confused and i did not misconfigure anything
 at all.

From: "Brandon D. Valentine" <ports@brandon.dvalentine.com>
To: Tobias Roth <ports@fsck.ch>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/69299: [PATCH] missing dependency for www/linux-flashplugin
Date: Mon, 2 Aug 2004 16:16:56 -0500

 On Mon, Aug 02, 2004 at 11:07:39PM +0200, Tobias Roth wrote:
 > did you even bother to look at the "How-To-Repeat" section? it says that
 > with linuxthreads, the plugin works for me. without, it doesn't. and other
 > linuxplugin-wrapped plugins do work even without linuxthreads. i know that
 > this is not a proof of a missing dependency, but only a strong evidence.
 > 
 > since you are absolutely sure that there is no such dependency, i am
 > happy if this PR gets closed. but for future reference, please refrain
 > from using remarks such as "the submitter's confusion". i have a name you
 > can adress me with, i am not confused and i did not misconfigure anything
 > at all.
 
 Pardon me.  I meant no offense.  I was merely attempting to explain why
 I believe you are seeing the behavior you described in the How-To-Repeat
 section, which I did read.  I believe you have a reference to liblthread
 in your libmap.conf.  If you can confirm that this is not the case then
 we can try to determine another cause of the behavior you observed.
 
 This issue seems to be specific to your installation and I would be
 happy to help you figure out why you are observing this behavior so that
 others can avoid it in the future.
 
 Thanks,
 
 Brandon D. Valentine
 -- 
 brandon@dvalentine.com                           http://www.geekpunk.net
 Pseudo-Random Googlism:  summer is approaching and heat exhaustion
                          becomes a factor that is why it is important to
                          follow the air temperature and the relative
                          humidity

From: Tobias Roth <ports@fsck.ch>
To: "Brandon D. Valentine" <ports@brandon.dvalentine.com>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/69299: [PATCH] missing dependency for www/linux-flashplugin
Date: Wed, 4 Aug 2004 23:19:45 +0200

 ok, i may have overreacted a bit.
 
 are you consent with us continuing this discussion outside the scope of
 the PR until we reach a conclusion?
State-Changed-From-To: feedback->suspended 
State-Changed-By: vs 
State-Changed-When: Mon Aug 9 15:38:41 GMT 2004 
State-Changed-Why:  
Suspend until a solution is found. 


Responsible-Changed-From-To: vs->freebsd-ports-bugs 
Responsible-Changed-By: vs 
Responsible-Changed-When: Mon Aug 9 15:38:41 GMT 2004 
Responsible-Changed-Why:  
Might as well get this off my list while it's suspended. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=69299 

From: Tobias Roth <ports@fsck.ch>
To: freebsd-gnats-submit@freebsd.org
Cc:  
Subject: Re: ports/69299: [PATCH] missing dependency for www/linux-flashplugin
Date: Thu, 23 Dec 2004 11:24:20 +0100

 Please close this PR, the problem is not reproducable for myself anymore.
State-Changed-From-To: suspended->closed 
State-Changed-By: edwin 
State-Changed-When: Thu Dec 23 10:48:45 GMT 2004 
State-Changed-Why:  
Closed on submitters request. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=69299 
>Unformatted:
