From nobody@FreeBSD.org  Thu Jul  8 19:07:21 2004
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9EE0916A4CE
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  8 Jul 2004 19:07:21 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 972D443D46
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  8 Jul 2004 19:07:21 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.11/8.12.11) with ESMTP id i68J7LW1061839
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 8 Jul 2004 19:07:21 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.11/8.12.11/Submit) id i68J7LKq061838;
	Thu, 8 Jul 2004 19:07:21 GMT
	(envelope-from nobody)
Message-Id: <200407081907.i68J7LKq061838@www.freebsd.org>
Date: Thu, 8 Jul 2004 19:07:21 GMT
From: Matthias Buelow <mkb@mukappabeta.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: various anomalies with xemacs port
X-Send-Pr-Version: www-2.3

>Number:         68826
>Category:       ports
>Synopsis:       various anomalies with xemacs port
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    sem
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jul 08 19:10:18 GMT 2004
>Closed-Date:    Wed Jun 15 07:25:32 GMT 2005
>Last-Modified:  Wed Jun 15 07:25:32 GMT 2005
>Originator:     Matthias Buelow
>Release:        FreeBSD 5.2.1-RELEASE-p9 i386
>Organization:
Univ. Wuerzburg
>Environment:
FreeBSD xxx 5.2.1-RELEASE-p9 FreeBSD 5.2.1-RELEASE-p9 #0: Sun Jul  4 05:20:29 CEST 2004     root@xxx:/usr/obj/usr/src/sys/xxx  i386

>Description:
The Xemacs port (# $FreeBSD: ports/editors/xemacs/Makefile,v 1.79 2004/04/13 06:29:58 edwin Exp $) seems to be somewhat broken.  Let me enumerate the weirdness:

 * Buffers tabs are missing.  I cannot get them enabled either.  Normally they should be visible in the default configuration (xemacs -q).  Options menu says they are visible, which they obviously aren't.

 * Buttons are missing in file request dialogs.

 * Unnecessary linking against libXm.  (Not a bug per se but an annoyance, that effects a bug in xemacs).  The only effect I can see that this has (apart from increasing the executable profile) is that, if you set xemacs to white background, you get ugly grey residues on the borders (a known bug in xemacs).  LibXm isn't necessary, one should use Xaw3d instead (but see next).  This should be configurable via make variables so that people who actually want to link against libXm (because they want better visual integration into CDE or sth.) can enable it.

 * Xaw3d doesn't seem to get linked against, even though built with  WITH_XAW3D=yes.  AFAIR Xaw3d is used for the buttons in dialogs.

 * Weird assortment of packages gets pulled into.  Why not just use the sumo package?  At least then all the files are actually available and one doesn't have to wait for each until it falls through to the FreeBSD distfiles site as last option.  Maybe provide an extra xemacs-sumo port. (change request).


>How-To-Repeat:
Install xemacs from this port:

# $FreeBSD: ports/editors/xemacs/Makefile,v 1.79 2004/04/13 06:29:58 edwin Exp $

>Fix:
      
>Release-Note:
>Audit-Trail:

From: Matthias Buelow <mkb@mukappabeta.de>
To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org
Cc:  
Subject: Re: ports/68826: various anomalies with xemacs port
Date: Thu, 08 Jul 2004 21:34:58 +0200

 I apologize for the bad formatting, apparently the send-pr web frontend 
 didn't wrap the lines... ;(
 
 -- 
    Matthias Buelow; mkb@{mukappabeta,informatik.uni-wuerzburg}.de
Responsible-Changed-From-To: freebsd-ports-bugs->gj 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Fri Jul 9 01:24:19 GMT 2004 
Responsible-Changed-Why:  
Over to maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=68826 

From: Matthias Buelow <mkb@mukappabeta.de>
To: freebsd-gnats-submit@FreeBSD.org, mkb@mukappabeta.de
Cc:  
Subject: Re: ports/68826: various anomalies with xemacs port
Date: Wed, 14 Jul 2004 03:20:32 +0200

 To port maintainer:
 
 please make sure you specify --with-widgets for Xemacs configure.
 
 I have checked the problem of the missing buffers tabs and dialog 
 buttons against a vanilla 21.4.15 xemacs which I installed seperately 
 and could reproduce it when --with-widgets was omitted.
 
 I then used --with-athena=3d --with-widgets and got satisfactory 
 results.  If you insist on using Motif for this port by default (which I 
 do not recommend), modify configure options accordingly.
 However, imho, xemacs' own Lucid widgets for menus, scrollbars etc. and 
 Xaw3d for the buffers tab and dialog buttons seems to work aswell as 
 Motif, if not better (no grey-border bug with white background).
 
 -- 
    Matthias Buelow; mkb@{mukappabeta,informatik.uni-wuerzburg}.de
Responsible-Changed-From-To: gj->anray@inet.ua 
Responsible-Changed-By: gj 
Responsible-Changed-When: Tue Dec 14 12:01:32 GMT 2004 
Responsible-Changed-Why:  
Over to the new maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=68826 
Responsible-Changed-From-To: anray@inet.ua->ports@FreeBSD.org 
Responsible-Changed-By: gj 
Responsible-Changed-When: Tue Dec 14 21:22:01 GMT 2004 
Responsible-Changed-Why:  
The new maintainer is ports@. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=68826 
Responsible-Changed-From-To: ports@FreeBSD.org->freebsd-ports-bugs 
Responsible-Changed-By: vs 
Responsible-Changed-When: Thu Dec 16 11:39:21 GMT 2004 
Responsible-Changed-Why:  
It's spelled freebsd-ports-bugs 

http://www.freebsd.org/cgi/query-pr.cgi?pr=68826 

From: Pawel Worach <pawel.worach@telia.com>
To: freebsd-gnats-submit@FreeBSD.org, mkb@mukappabeta.de
Cc:  
Subject: Re: ports/68826: various anomalies with xemacs port
Date: Tue, 28 Dec 2004 20:48:09 +0100

 First step at addressing the buffer tabs and Xaw3d, also fix a typo.
 'make -DMOTIF_STATIC -DWITH_XAW3D' should produce the same result as
 defined above now. Tested both motif and athena (no 3d) builds, they
 look good.
 
 (Can we start here and then I'll continue and clean up the makefile
 variabes and maybe leave just a few like, WITHOUT_X11, WITH_MOTIF,
 WITH_ATHENA, WITH_GTK, WITH_XAW3D ?)
 
 Index: editors/xemacs/Makefile
 ===================================================================
 RCS file: /export/ctm/cvs/ports/editors/xemacs/Makefile,v
 retrieving revision 1.83
 diff -u -u -r1.83 Makefile
 --- editors/xemacs/Makefile     25 Dec 2004 22:27:59 -0000      1.83
 +++ editors/xemacs/Makefile     28 Dec 2004 19:36:22 -0000
 @@ -44,7 +44,8 @@
                  --with-ldap=no \
                  --with-site-lisp \
                  --with-database=berkdb \
 -               ${WITH_XFACE} ${WITH_DIALOGS} ${WITH_OFFIX} ${WITH_GTK}
 +               ${WITH_XFACE} ${WITH_DIALOGS} ${WITH_WIDGETS} \
 +               ${WITH_OFFIX} ${WITH_GTK}
   MAKE_ARGS=     prefix=${PREFIX}
   MAN1=          ctags.1 etags.1 gnuattach.1 gnuclient.1 gnudoit.1 \
                  gnuserv.1 xemacs.1
 @@ -81,7 +82,7 @@
          @${ECHO_MSG} ""
          @${ECHO_MSG} "Set the environment variable WITHOUT_X11 if you "
          @${ECHO_MSG} "do not want to use X11."
 -CONFIG_ARGS+=  --with-png=yes --with-tiff=yes
 +CONFIGURE_ARGS+=       --with-png --with-tiff
   .endif
   .if defined(WITHOUT_X11)
   CONFIGURE_ARGS+=       --without-x11
 @@ -90,10 +91,15 @@
   # hack to avoid shipping binaries linked with Motif
   .if defined(MOTIF_STATIC)
   WITH_DIALOGS=  --with-dialogs=athena
 +WITH_WIDGETS=  --with-widgets=athena
 +.else
 +WITH_DIALOGS=  --with-dialogs=motif
 +WITH_WIDGETS=  --with-widgets=motif
   .endif
 
   .if defined(WITH_XAW3D)
   LIB_DEPENDS+=  Xaw3d.${XAWVER}:${PORTSDIR}/x11-toolkits/Xaw3d
 +CONFIGURE_ARGS+=       --with-athena=3d
   .endif
 
   #.if defined(WANT_GTK)

From: Matthias Buelow <mkb@mukappabeta.de>
To: Pawel Worach <pawel.worach@telia.com>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/68826: various anomalies with xemacs port
Date: Tue, 28 Dec 2004 21:47:18 +0100

 Pawel Worach wrote:
 
 > First step at addressing the buffer tabs and Xaw3d, also fix a typo.
 > 'make -DMOTIF_STATIC -DWITH_XAW3D' should produce the same result as
 > defined above now. Tested both motif and athena (no 3d) builds, they
 > look good.
 > 
 > (Can we start here and then I'll continue and clean up the makefile
 > variabes and maybe leave just a few like, WITHOUT_X11, WITH_MOTIF,
 > WITH_ATHENA, WITH_GTK, WITH_XAW3D ?)
 
 It looks ok from judging with naked-eye check (won't apply here since 
 apparently the patch got somehow mangled thru mail.. whatever).
 
 Another thing: could the dependency on the xemacs-packages port be 
 removed?  Xemacs really has its own packages system, and the 
 xemacs-packages port is a rather arbitrary (and, as I found out, 
 sometimes outdated) assortment.  What would be cool would be: a) plain 
 xemacs port, which doesn't install any packages, and b) xemacs "sumo" 
 packages port, which installs the sumo (i.e. all) package tarball. 
 Anything in between doesn't really make sense, since what packages to 
 include, and what not depends on the personal preferences of the port 
 maintainer.
 
 mkb.

From: Pawel Worach <pawel.worach@telia.com>
To: Matthias Buelow <mkb@mukappabeta.de>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/68826: various anomalies with xemacs port
Date: Wed, 09 Feb 2005 14:56:57 +0100

 Matthias Buelow wrote:
 > Another thing: could the dependency on the xemacs-packages port be 
 > removed?  Xemacs really has its own packages system, and the 
 > xemacs-packages port is a rather arbitrary (and, as I found out, 
 > sometimes outdated) assortment.  What would be cool would be: a) plain 
 > xemacs port, which doesn't install any packages, and b) xemacs "sumo" 
 > packages port, which installs the sumo (i.e. all) package tarball. 
 > Anything in between doesn't really make sense, since what packages to 
 > include, and what not depends on the personal preferences of the port 
 > maintainer.
 
 Most of this has now been taken care of with ports/77291, you can set
 WITHOUT_MOTIF to get a pure Athena build and optionally WITH_XAW3D to use Xaw3d.
 
 Here is a patch to make the packages optional with WITHOUT_XEMACS_PACKAGES
 
 --- Makefile.orig	Wed Feb  9 14:50:31 2005
 +++ Makefile	Wed Feb  9 14:52:17 2005
 @@ -20,8 +20,6 @@
   XEMACS_VER=	21.4.17
   XEMACS_ARCH=	${CONFIGURE_TARGET}
 
 -RUN_DEPENDS+= 
 ${LOCALBASE}/lib/xemacs/xemacs-packages/etc/enriched.doc:${PORTSDIR}/editors/xemacs-packages
 -
   USE_BZIP2=	yes
   STRIP=
   USE_AUTOCONF_VER=213
 @@ -50,6 +48,9 @@
   CONFIGURE_ARGS+=	--with-system-malloc --pdump
   .endif
 
 +.if !defined(WITHOUT_XEMACS_PACKAGES)
 +RUN_DEPENDS+= 
 ${LOCALBASE}/lib/xemacs/xemacs-packages/etc/enriched.doc:${PORTSDIR}/editors/xemacs-packages
 +.endif
   .if !defined(WITHOUT_X11)
   LIB_DEPENDS+=	png.5:${PORTSDIR}/graphics/png \
   		jpeg.9:${PORTSDIR}/graphics/jpeg \
 
 Also would anyone mind if I removed the dependency on faces? It pulls in gtk 1.x 
 and a lot of other crap not everyone wants.
 
 -- 
 Pawel

From: Pawel Worach <pawel.worach@telia.com>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: ports/68826: various anomalies with xemacs port
Date: Wed, 09 Feb 2005 20:26:19 +0100

 This is a multi-part message in MIME format.
 --------------020808090202090907090405
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 7bit
 
 Ok, here is a final diff
 
 - Make packages optional (WITHOUT_XEMACS_PACKAGES).
 - Remove dependency on mail/faces (it is not required for an base
    editor configuration and it pulls in gtk1 and what comes with that.
 - Integrate with the GNOME desktop if installed.
 
 Added files:
 files/xemacs.desktop.in
 
 Sending patch as attachment, hope this doesn't make Gnats upset.
 
 -- 
 Pawel
 
 --------------020808090202090907090405
 Content-Type: text/plain;
  name="xd.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline;
  filename="xd.diff"
 
 ? editors/xemacs/files/xemacs.desktop.in
 Index: editors/xemacs/Makefile
 ===================================================================
 RCS file: /export/ctm/cvs/ports/editors/xemacs/Makefile,v
 retrieving revision 1.85
 diff -u -r1.85 Makefile
 --- editors/xemacs/Makefile	9 Feb 2005 13:19:57 -0000	1.85
 +++ editors/xemacs/Makefile	9 Feb 2005 19:22:47 -0000
 @@ -7,6 +7,7 @@
  
  PORTNAME=	xemacs
  PORTVERSION=	${XEMACS_VER}
 +PORTREVISION=	1
  CATEGORIES+=	editors
  MASTER_SITES=	${MASTER_SITE_XEMACS}
  MASTER_SITE_SUBDIR=	xemacs-${XEMACS_REL}
 @@ -20,9 +21,8 @@
  XEMACS_VER=	21.4.17
  XEMACS_ARCH=	${CONFIGURE_TARGET}
  
 -RUN_DEPENDS+=	${LOCALBASE}/lib/xemacs/xemacs-packages/etc/enriched.doc:${PORTSDIR}/editors/xemacs-packages
 -
  USE_BZIP2=	yes
 +WANT_GNOME=	yes
  STRIP=
  USE_AUTOCONF_VER=213
  CONFIGURE_TARGET=${MACHINE_ARCH}--freebsd
 @@ -41,7 +41,8 @@
  		gnuserv.1 xemacs.1
  ALL_TARGET=	all dist
  
 -PLIST_SUB=	XEMACS_VER=${XEMACS_VER} XEMACS_ARCH=${XEMACS_ARCH}
 +PLIST_SUB=	XEMACS_VER=${XEMACS_VER} XEMACS_ARCH=${XEMACS_ARCH} \
 +		LOCALBASE=${LOCALBASE} X11BASE=${X11BASE}
  
  .include <bsd.port.pre.mk>
  
 @@ -50,11 +51,13 @@
  CONFIGURE_ARGS+=	--with-system-malloc --pdump
  .endif
  
 +.if !defined(WITHOUT_XEMACS_PACKAGES)
 +RUN_DEPENDS+=	${LOCALBASE}/lib/xemacs/xemacs-packages/etc/enriched.doc:${PORTSDIR}/editors/xemacs-packages
 +.endif
  .if !defined(WITHOUT_X11)
  LIB_DEPENDS+=	png.5:${PORTSDIR}/graphics/png \
  		jpeg.9:${PORTSDIR}/graphics/jpeg \
 -		tiff.4:${PORTSDIR}/graphics/tiff \
 -		compface.1:${PORTSDIR}/mail/faces
 +		tiff.4:${PORTSDIR}/graphics/tiff
  CONFIGURE_ARGS+=	--with-png --with-jpeg --with-tiff
  USE_XLIB=	yes
  USE_XPM=	yes
 @@ -76,6 +79,17 @@
  CONFIGURE_ARGS+=	--without-x11
  .endif
  
 +.if !defined(WITHOUT_X11) && ${HAVE_GNOME:Mgnomehier}!=""
 +USE_GNOME+=	gnomehier
 +PLIST_SUB+=	DESKTOP=""
 +.else
 +PLIST_SUB+=	DESKTOP="@comment "
 +.endif
 +
 +post-extract::
 +	@${SED} -e 's|@XEMACS_ICON@|${LOCALBASE}/lib/xemacs-${XEMACS_VER}/etc/xemacs-icon.xpm|' \
 +		<${FILESDIR}/xemacs.desktop.in >${WRKDIR}/xemacs.desktop
 +
  pre-patch:
  .if !defined(WITHOUT_X11)
  .if !defined(WITHOUT_MOTIF) && !defined(MOTIF_STATIC)
 @@ -109,6 +123,10 @@
  .for f in b2m ctags ellcc etags gnuclient xemacs-${XEMACS_VER}
  	${STRIP_CMD} ${PREFIX}/bin/${f}
  .endfor
 +.if !defined(WITHOUT_X11) && ${HAVE_GNOME:Mgnomehier}!=""
 +	${INSTALL_DATA} ${WRKDIR}/xemacs.desktop \
 +		${X11BASE}/share/gnome/applications
 +.endif
  # For some reason install no longer makes ${PREFIX}/lib/xemacs/site-lisp.
  # Do what PLIST does for pkg_add.
  	${MKDIR} ${PREFIX}/lib/xemacs/site-lisp
 Index: editors/xemacs/pkg-plist
 ===================================================================
 RCS file: /export/ctm/cvs/ports/editors/xemacs/pkg-plist,v
 retrieving revision 1.32
 diff -u -r1.32 pkg-plist
 --- editors/xemacs/pkg-plist	25 Dec 2004 22:27:59 -0000	1.32
 +++ editors/xemacs/pkg-plist	9 Feb 2005 19:22:47 -0000
 @@ -1262,6 +1262,9 @@
  lib/xemacs-%%XEMACS_VER%%/lisp/x-win-sun.elc
  lib/xemacs-%%XEMACS_VER%%/lisp/x-win-xfree86.el
  lib/xemacs-%%XEMACS_VER%%/lisp/x-win-xfree86.elc
 +%%DESKTOP%%@cwd %%X11BASE%%
 +%%DESKTOP%%share/gnome/applications/xemacs.desktop
 +%%DESKTOP%%@cwd %%LOCALBASE%%
  @dirrm lib/xemacs-%%XEMACS_VER%%/lisp/term
  @dirrm lib/xemacs-%%XEMACS_VER%%/lisp/mule
  @dirrm lib/xemacs-%%XEMACS_VER%%/lisp
 --- /dev/null	Wed Feb  9 20:22:00 2005
 +++ editors/xemacs/files/xemacs.desktop.in	Wed Feb  9 18:55:42 2005
 @@ -0,0 +1,9 @@
 +[Desktop Entry]
 +Encoding=UTF-8
 +Name=XEmacs
 +Comment=XEmacs Text Editor
 +Exec=xemacs %F
 +Terminal=false
 +Type=Application
 +Icon=@XEMACS_ICON@
 +Categories=Application;Utility;TextEditor;
 
 --------------020808090202090907090405--

From: Matthias Buelow <mkb@mukappabeta.de>
To: Pawel Worach <pawel.worach@telia.com>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/68826: various anomalies with xemacs port
Date: Thu, 10 Feb 2005 21:08:04 +0100

 Pawel Worach wrote:
 
 > Most of this has now been taken care of with ports/77291, you can set
 > WITHOUT_MOTIF to get a pure Athena build and optionally WITH_XAW3D to 
 > use Xaw3d.
 
 thanks.
 
 > Also would anyone mind if I removed the dependency on faces? It pulls in 
 > gtk 1.x and a lot of other crap not everyone wants.
 
 or make it optional.. or (make the responsible maintainer) clean up the 
 faces port so that it doesn't require gtk.
 
 mkb.
 
 

From: Florent Thoumie <flz@xbsd.org>
To: mkb@mukappabeta.de, FreeBSD-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: ports/68826: various anomalies with xemacs port
Date: Mon, 06 Jun 2005 01:42:07 +0200

 	Is there anything left to be done about this PR ?
 
 -- 
 Florent Thoumie
 flz@xbsd.org
 
Responsible-Changed-From-To: freebsd-ports-bugs->sem 
Responsible-Changed-By: sem 
Responsible-Changed-When: Thu Jun 9 12:39:53 GMT 2005 
Responsible-Changed-Why:  
I'll explore it 

http://www.freebsd.org/cgi/query-pr.cgi?pr=68826 
State-Changed-From-To: open->closed 
State-Changed-By: sem 
State-Changed-When: Wed Jun 15 07:25:25 GMT 2005 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=68826 
>Unformatted:
