From josepht@jupiter.xenno.com  Thu Jul  8 02:41:17 2004
Return-Path: <josepht@jupiter.xenno.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CB98716A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  8 Jul 2004 02:41:17 +0000 (GMT)
Received: from jupiter.xenno.com (jupiter.xenno.com [216.12.87.49])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 686C743D49
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  8 Jul 2004 02:41:17 +0000 (GMT)
	(envelope-from josepht@jupiter.xenno.com)
Received: from jupiter.xenno.com (localhost [127.0.0.1])
	by jupiter.xenno.com (8.12.11/8.12.11) with ESMTP id i682fGv2054827
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 7 Jul 2004 22:41:16 -0400 (EDT)
	(envelope-from josepht@jupiter.xenno.com)
Received: (from josepht@localhost)
	by jupiter.xenno.com (8.12.11/8.12.11/Submit) id i682fFjW054826;
	Wed, 7 Jul 2004 22:41:15 -0400 (EDT)
	(envelope-from josepht)
Message-Id: <200407080241.i682fFjW054826@jupiter.xenno.com>
Date: Wed, 7 Jul 2004 22:41:15 -0400 (EDT)
From: Joe Talbott <josepht@xenno.com>
Reply-To: Joe Talbott <josepht@xenno.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] IceWM fix focusing new+maximized windows
X-Send-Pr-Version: 3.113
X-GNATS-Notify: vs

>Number:         68796
>Category:       ports
>Synopsis:       [patch] IceWM fix focusing new+maximized windows
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    vs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jul 08 02:50:22 GMT 2004
>Closed-Date:    Fri Aug 27 11:36:55 GMT 2004
>Last-Modified:  Fri Aug 27 11:36:55 GMT 2004
>Originator:     Joe Talbott
>Release:        FreeBSD 4.10-STABLE i386
>Organization:
none
>Environment:
System: FreeBSD localhost 4.10-STABLE FreeBSD 4.10-STABLE #26: Wed Jun 16 15:26:18 EDT 2004 root@localhost:/usr/obj/usr/src/sys/JUPITER i386

icewm-1.2.14 (x11-wm/icewm)

>Description:

Applications like Mozilla or Firefox that I open maximized don't are raised to the top but don't get focus.  

>How-To-Repeat:

Open Mozilla or Firefox maximized.

>Fix:

--- wmmgr.cc.patch begins here ---
--- wmmgr.cc	Sun May 23 02:18:19 2004
+++ wmmgr.cc.new	Wed Jul  7 15:58:53 2004
@@ -1489,10 +1489,11 @@
         canManualPlace = true;
 
     if (mapClient) {
-        if (frame->getState() == 0 || frame->isRollup()) {
+				 if (!(frame->getState() & (WinStateHidden | WinStateMinimized | WinStateFullscreen)))
+					{
             if (canManualPlace && !opaqueMove)
                 frame->manualPlace();
-        }
+					}
     }
     frame->updateState();
     frame->updateProperties();
@@ -1504,7 +1505,8 @@
     if (frame->affectsWorkArea())
 	updateWorkArea();
     if (mapClient) {
-        if (frame->getState() == 0 || frame->isRollup()) {
+				if (!(frame->getState() & (WinStateHidden | WinStateMinimized)))
+				{
             if (wmState() == wmRUNNING && canActivate)
                 frame->focusOnMap();
             if (canManualPlace && opaqueMove)
--- wmmgr.cc.patch ends here ---


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: vs 
State-Changed-When: Fri Aug 13 14:49:24 GMT 2004 
State-Changed-Why:  
Have you considered reporting this to the developers? There seems to 
be nobody around here using icewm who could verify this and I'm a bit weary 
to commit this untested... 

http://www.freebsd.org/cgi/query-pr.cgi?pr=68796 
Responsible-Changed-From-To: freebsd-ports-bugs->vs 
Responsible-Changed-By: vs 
Responsible-Changed-When: Fri Aug 13 15:02:17 GMT 2004 
Responsible-Changed-Why:  
I'll keep an eye on this. The patch indeed works. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=68796 
State-Changed-From-To: feedback->closed 
State-Changed-By: vs 
State-Changed-When: Fri Aug 27 11:35:24 GMT 2004 
State-Changed-Why:  
Port has been updated to 1.2.16 which contains the fix. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=68796 
>Unformatted:
