From rv@arabica.esil.univ-mrs.fr  Tue Jul  6 12:01:29 2004
Return-Path: <rv@arabica.esil.univ-mrs.fr>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 62A9D16A56F
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  6 Jul 2004 12:01:29 +0000 (GMT)
Received: from arabica.esil.univ-mrs.fr (arabica.esil.univ-mrs.fr [139.124.41.108])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B76ED43D48
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  6 Jul 2004 12:01:28 +0000 (GMT)
	(envelope-from rv@arabica.esil.univ-mrs.fr)
Received: from arabica.esil.univ-mrs.fr (localhost.esil.univ-mrs.fr [127.0.0.1])
	by arabica.esil.univ-mrs.fr (8.12.10/8.12.10) with ESMTP id i66C1Q2r090370;
	Tue, 6 Jul 2004 14:01:26 +0200 (CEST)
	(envelope-from rv@arabica.esil.univ-mrs.fr)
Received: (from rv@localhost)
	by arabica.esil.univ-mrs.fr (8.12.10/8.12.10/Submit) id i66C1QtB090369;
	Tue, 6 Jul 2004 14:01:26 +0200 (CEST)
	(envelope-from rv)
Message-Id: <200407061201.i66C1QtB090369@arabica.esil.univ-mrs.fr>
Date: Tue, 6 Jul 2004 14:01:26 +0200 (CEST)
From: Herve Quiroz <herve.quiroz@esil.univ-mrs.fr>
To: FreeBSD-gnats-submit@freebsd.org
Cc: hsn@netmag.cz
Subject: [PATCH] sysutils/portindex: use the full-path for python executable
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         68723
>Category:       ports
>Synopsis:       [PATCH] sysutils/portindex: use the full-path for python executable
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pav
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jul 06 12:10:21 GMT 2004
>Closed-Date:    Tue Jul 06 15:14:37 GMT 2004
>Last-Modified:  Tue Jul 06 15:14:37 GMT 2004
>Originator:     Herve Quiroz
>Release:        FreeBSD 5.2.1-RELEASE-p5 i386
>Organization:
>Environment:
System: FreeBSD arabica.esil.univ-mrs.fr 5.2.1-RELEASE-p5 FreeBSD 5.2.1-RELEASE-p5 #3: Thu May  6 20:17:47 CEST
>Description:

I use to run portindex in some custom script which is run by cron(8).
Unfortunately, the path of the python(1) executable is missing in portindex
(and other provided shell scripts) and that prevents portindex to be run with
an empty PATH variable.

This patch provides a little "sed magic" to the set of executable to hardcode
the path of python(1) using the provided ${PYTHON_CMD} from bsd.python.mk.

NOTE: bumped PORTREVISION

Port maintainer (hsn@netmag.cz) is cc'd.

Generated with FreeBSD Port Tools 0.50
>How-To-Repeat:

Just try to run 'portindex' with an empty PATH variable.

>Fix:

--- portindex-12_1.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/sysutils/portindex.original/Makefile /usr/ports/sysutils/portindex/Makefile
--- /usr/ports/sysutils/portindex.original/Makefile	Tue Jul  6 13:44:02 2004
+++ /usr/ports/sysutils/portindex/Makefile	Tue Jul  6 13:46:21 2004
@@ -7,6 +7,7 @@
 
 PORTNAME=	portindex
 PORTVERSION=	12
+PORTREVISION=	1
 CATEGORIES=	sysutils
 MASTER_SITES=	http://home.tiscali.cz:8080/~cz210552/distfiles/ \
 		http://www.oook.cz/bsd/distfiles/
@@ -66,7 +67,7 @@
 do-build:
 	${REINPLACE_CMD} -e "s,ports.pck,/var/db/portindex.pck," ${WRKSRC}/freebsdports.py
 .for i in ${EXECUTABLES}
-	${SED} -e "s,%%DATADIR%%,${DATADIR}," ${FILESDIR}/${i}.sh > ${WRKSRC}/${i}
+	${SED} -e "s,%%DATADIR%%,${DATADIR}, ; s,%%PYTHON_CMD%%,${PYTHON_CMD}," ${FILESDIR}/${i}.sh > ${WRKSRC}/${i}
 .endfor
 
 do-install:
diff -ruN --exclude=CVS /usr/ports/sysutils/portindex.original/files/loadindex.sh /usr/ports/sysutils/portindex/files/loadindex.sh
--- /usr/ports/sysutils/portindex.original/files/loadindex.sh	Tue Jul  6 13:44:02 2004
+++ /usr/ports/sysutils/portindex/files/loadindex.sh	Tue Jul  6 13:45:45 2004
@@ -1,2 +1,2 @@
 #! /bin/sh
-exec /usr/bin/env python %%DATADIR%%/loadindex.py $*
+exec /usr/bin/env %%PYTHON_CMD%% %%DATADIR%%/loadindex.py $*
diff -ruN --exclude=CVS /usr/ports/sysutils/portindex.original/files/minorupdates.sh /usr/ports/sysutils/portindex/files/minorupdates.sh
--- /usr/ports/sysutils/portindex.original/files/minorupdates.sh	Tue Jul  6 13:44:02 2004
+++ /usr/ports/sysutils/portindex/files/minorupdates.sh	Tue Jul  6 13:45:49 2004
@@ -1,2 +1,2 @@
 #! /bin/sh
-exec /usr/bin/env python %%DATADIR%%/minorupdates.py $*
+exec /usr/bin/env %%PYTHON_CMD%% %%DATADIR%%/minorupdates.py $*
diff -ruN --exclude=CVS /usr/ports/sysutils/portindex.original/files/portindex.sh /usr/ports/sysutils/portindex/files/portindex.sh
--- /usr/ports/sysutils/portindex.original/files/portindex.sh	Tue Jul  6 13:44:02 2004
+++ /usr/ports/sysutils/portindex/files/portindex.sh	Tue Jul  6 13:44:26 2004
@@ -1,2 +1,2 @@
 #! /bin/sh
-exec /usr/bin/env python %%DATADIR%%/indexer.py $*
+exec /usr/bin/env %%PYTHON_CMD%% %%DATADIR%%/indexer.py $*
diff -ruN --exclude=CVS /usr/ports/sysutils/portindex.original/files/portreadmes.sh /usr/ports/sysutils/portindex/files/portreadmes.sh
--- /usr/ports/sysutils/portindex.original/files/portreadmes.sh	Tue Jul  6 13:44:02 2004
+++ /usr/ports/sysutils/portindex/files/portreadmes.sh	Tue Jul  6 13:45:52 2004
@@ -1,2 +1,2 @@
 #! /bin/sh
-exec /usr/bin/env python %%DATADIR%%/updatereadmes.py $*
+exec /usr/bin/env %%PYTHON_CMD%% %%DATADIR%%/updatereadmes.py $*
diff -ruN --exclude=CVS /usr/ports/sysutils/portindex.original/files/query.sh /usr/ports/sysutils/portindex/files/query.sh
--- /usr/ports/sysutils/portindex.original/files/query.sh	Tue Jul  6 13:44:02 2004
+++ /usr/ports/sysutils/portindex/files/query.sh	Tue Jul  6 13:45:54 2004
@@ -1,2 +1,2 @@
 #! /bin/sh
-exec /usr/bin/env python %%DATADIR%%/query.py $*
+exec /usr/bin/env %%PYTHON_CMD%% %%DATADIR%%/query.py $*
diff -ruN --exclude=CVS /usr/ports/sysutils/portindex.original/files/updateall.sh /usr/ports/sysutils/portindex/files/updateall.sh
--- /usr/ports/sysutils/portindex.original/files/updateall.sh	Tue Jul  6 13:44:02 2004
+++ /usr/ports/sysutils/portindex/files/updateall.sh	Tue Jul  6 13:45:56 2004
@@ -1,2 +1,2 @@
 #! /bin/sh
-exec /usr/bin/env python %%DATADIR%%/updateall.py $*
+exec /usr/bin/env %%PYTHON_CMD%% %%DATADIR%%/updateall.py $*
diff -ruN --exclude=CVS /usr/ports/sysutils/portindex.original/files/updinst.sh /usr/ports/sysutils/portindex/files/updinst.sh
--- /usr/ports/sysutils/portindex.original/files/updinst.sh	Tue Jul  6 13:44:02 2004
+++ /usr/ports/sysutils/portindex/files/updinst.sh	Tue Jul  6 13:45:59 2004
@@ -1,2 +1,2 @@
 #! /bin/sh
-exec /usr/bin/env python %%DATADIR%%/updinst.py $*
+exec /usr/bin/env %%PYTHON_CMD%% %%DATADIR%%/updinst.py $*
--- portindex-12_1.patch ends here ---

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: pav 
State-Changed-When: Tue Jul 6 14:45:41 GMT 2004 
State-Changed-Why:  
Asked maintainer for approval. 


Responsible-Changed-From-To: freebsd-ports-bugs->pav 
Responsible-Changed-By: pav 
Responsible-Changed-When: Tue Jul 6 14:45:41 GMT 2004 
Responsible-Changed-Why:  
Handle. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=68723 

From: Pav Lucistnik <pav@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org, herve.quiroz@esil.univ-mrs.fr,
	hsn@netmag.cz
Cc:  
Subject: Re: ports/68723: [PATCH] sysutils/portindex: use the full-path for
	python executable
Date: Tue, 06 Jul 2004 16:45:38 +0200

 Dear maintainer of FreeBSD port sysutils/portindex, please take a look
 at
 
 http://www.freebsd.org/cgi/query-pr.cgi?q=68723
 
 Do you approve this patch?
 
 -- 
 Pav Lucistnik <pav@oook.cz>
               <pav@FreeBSD.org>
 
 Mischief managed.

From: Herve Quiroz <herve.quiroz@esil.univ-mrs.fr>
To: Pav Lucistnik <pav@FreeBSD.org>
Cc: hsn@netmag.cz, FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/68723: [PATCH] sysutils/portindex: use the full-path for python executable
Date: Tue, 6 Jul 2004 17:09:36 +0200

 --pf9I7BMVVzbSWLtt
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 Pav,
 
 Just in case, I forward you this mail from the maintainer. So you may
 close this PR. I still wonder the reason why the patch is rejected but
 given the lack of additional feedback from the maintainer I assume it is
 not a relevant feature.
 
 Sorry for that.
 
 Herve
 
 --pf9I7BMVVzbSWLtt
 Content-Type: message/rfc822
 Content-Disposition: inline
 
 Received: from jiyu.esil.univ-mrs.fr [139.124.44.249]
 	by localhost with POP3 (fetchmail-6.2.5)
 	for rv@localhost (single-drop); Tue, 06 Jul 2004 16:45:54 +0200 (CEST)
 Received: by jiyu.esil.univ-mrs.fr (mbox hquiroz)
  (with Cubic Circle's cucipop (v1.31 1998/05/13) Tue Jul  6 16:45:53 2004)
 X-From_: hsn@netmag.cz  Tue Jul  6 16:40:49 2004
 Return-Path: <hsn@netmag.cz>
 Delivered-To: hquiroz@esil.univ-mrs.fr
 Received: from localhost (localhost.esil.univ-mrs.fr [127.0.0.1])
 	by jiyu.esil.univ-mrs.fr (Thomson TO7 SMTP mail server) with ESMTP id 44CAB24D55
 	for <herve.quiroz@esil.univ-mrs.fr>; Tue,  6 Jul 2004 16:40:48 +0200 (CEST)
 Received: from sanatana.dharma (ppp1433.ul.tiscali.cz [213.235.70.50])
 	by jiyu.esil.univ-mrs.fr (Thomson TO7 SMTP mail server) with ESMTP id ECE8B24E14
 	for <herve.quiroz@esil.univ-mrs.fr>; Tue,  6 Jul 2004 16:40:27 +0200 (CEST)
 Received: from hsn@localhost
 	by sanatana.dharma (Exim 4.34_0 FreeBSD) id 1BhqWa-000LMH-M7
 	for <herve.quiroz@esil.univ-mrs.fr>; Tue, 06 Jul 2004 16:02:20 +0200
 Date: Tue, 6 Jul 2004 16:02:20 +0200
 From: Radim Kolar <hsn@netmag.cz>
 To: Herve Quiroz <herve.quiroz@esil.univ-mrs.fr>
 Subject: Re: [PATCH] sysutils/portindex: use the full-path for python executable
 Message-ID: <20040706140220.GA80221@sanatana.dharma>
 References: <200407061201.i66C1QtB090369@arabica.esil.univ-mrs.fr>
 Mime-Version: 1.0
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 In-Reply-To: <200407061201.i66C1QtB090369@arabica.esil.univ-mrs.fr>
 User-Agent: Mutt/1.5.6i
 X-Virus-Scanned: by AMaViS perl-10
 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on 
 	arabica.esil.univ-mrs.fr
 X-Spam-Level: 
 X-Spam-Status: No, hits=-1.3 required=5.0 tests=BAYES_20,RCVD_IN_SORBS 
 	autolearn=no version=2.63
 
 patch rejected, close pr.
 
 --pf9I7BMVVzbSWLtt--
State-Changed-From-To: feedback->closed 
State-Changed-By: pav 
State-Changed-When: Tue Jul 6 15:14:23 GMT 2004 
State-Changed-Why:  
Patch rejected by maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=68723 
>Unformatted:
