From eikemeier@fillmore-labs.com  Thu Jul  1 20:27:10 2004
Return-Path: <eikemeier@fillmore-labs.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0F74D16A4CE
	for <FreeBSD-gnats-submit@FreeBSD.org>; Thu,  1 Jul 2004 20:27:10 +0000 (GMT)
Received: from fillmore.dyndns.org (port-212-202-50-15.dynamic.qsc.de [212.202.50.15])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C6C5E43D1D
	for <FreeBSD-gnats-submit@FreeBSD.org>; Thu,  1 Jul 2004 20:27:09 +0000 (GMT)
	(envelope-from eikemeier@fillmore-labs.com)
Received: from dhcp-4.local ([172.16.0.4])
	by fillmore.dyndns.org with esmtp (Exim 4.34 (FreeBSD))
	id 1Bg88A-000Ebf-CL
	for FreeBSD-gnats-submit@FreeBSD.org; Thu, 01 Jul 2004 22:26:05 +0200
Message-Id: <40E458BB.7020502@fillmore-labs.com>
Date: Thu, 01 Jul 2004 20:32:27 +0200
From: Oliver Eikemeier <eikemeier@fillmore-labs.com>
To: FreeBSD-gnats-submit@FreeBSD.org
Subject: bsd.autotools.mk should not use `.error'

>Number:         68568
>Category:       ports
>Synopsis:       bsd.autotools.mk should not use `.error'
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    ade
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jul 01 20:30:31 GMT 2004
>Closed-Date:    Thu Jul 01 21:13:27 GMT 2004
>Last-Modified:  Thu Jul 01 21:13:27 GMT 2004
>Originator:     Oliver Eikemeier
>Release:        FreeBSD 4.10-STABLE i386
>Organization:
Fillmore Labs - http://www.fillmore-labs.com
>Environment:
System: FreeBSD nuuk.fillmore-labs.com 4.10-STABLE

>Description:

bsd.autotools.mk uses `.error' in multiple places:

  135:. error USE_${i} deprecated: replace with USE_${i}_VER=...
  138:. error WANT_${i} deprecated: replace with WANT_${i}_VER=...
  165:. error Unknown AUTOMAKE version: ${WANT_AUTOMAKE_VER}
  210:.error Incompatible autoheader ${USE_AUTOHEADER_VER} and autoconf ${USE_AUTOCONF_VER}
  215:.error Incompatible autoheader ${WANT_AUTOHEADER_VER} and autoconf ${WANT_AUTOCONF_VER}
  232:. error Unknown AUTOCONF version: ${WANT_AUTOCONF_VER}
  282:. error Unknown LIBTOOL version: ${WANT_LIBTOOL_VER}

This has the ill effect that a misconfigured port breaks all port tools,
like INDEX building, pkg_version, portupgrade, chkversion and others.

I assume that tools that should report these misconfigurations, like
portsmon, are affected too.

Most port tools use make -V to extract information fro the ports,
so FreshPorts can do make -VPKGNAME -VBROKEN and could display that
port PKGNAME is broken because BROKEN.

Common practice in the ports tree is to set BROKEN in this case.

>How-To-Repeat:
>Fix:

Replace `.error' with `BROKEN='

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->ade 
Responsible-Changed-By: eik 
Responsible-Changed-When: Thu Jul 1 22:31:30 CEST 2004 
Responsible-Changed-Why:  
Over to maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=68568 
State-Changed-From-To: open->closed 
State-Changed-By: ade 
State-Changed-When: Thu Jul 1 21:13:17 GMT 2004 
State-Changed-Why:  
Done. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=68568 
>Unformatted:
