From jylefort@brutele.be  Wed Jun 23 22:39:43 2004
Return-Path: <jylefort@brutele.be>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4F3C916A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 23 Jun 2004 22:39:43 +0000 (GMT)
Received: from gateway.lefort.net (212.68.242.203.brutele.be [212.68.242.203])
	by mx1.FreeBSD.org (Postfix) with ESMTP id ADD0D43D3F
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 23 Jun 2004 22:39:42 +0000 (GMT)
	(envelope-from jylefort@brutele.be)
Received: from jsite.lefort.net (jsite.lefort.net [192.168.1.2])
	by gateway.lefort.net (Postfix) with ESMTP id 5E1B654C7
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 24 Jun 2004 00:39:33 +0200 (CEST)
Received: by jsite.lefort.net (Postfix, from userid 1000)
	id 084D522E28; Thu, 24 Jun 2004 00:39:33 +0200 (CEST)
Message-Id: <20040623223933.084D522E28@jsite.lefort.net>
Date: Thu, 24 Jun 2004 00:39:33 +0200 (CEST)
From: Jean-Yves Lefort <jylefort@brutele.be>
Reply-To: Jean-Yves Lefort <jylefort@brutele.be>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: bsd.gnome.mk locale patch is incomplete
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         68256
>Category:       ports
>Synopsis:       bsd.gnome.mk locale patch is incomplete
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    gnome
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jun 23 22:40:17 GMT 2004
>Closed-Date:    Sun Jun 27 17:33:18 GMT 2004
>Last-Modified:  Sun Jun 27 17:33:18 GMT 2004
>Originator:     Jean-Yves Lefort
>Release:        FreeBSD 4.10-RELEASE i386
>Organization:
>Environment:
System: FreeBSD jsite.lefort.net 4.10-RELEASE FreeBSD 4.10-RELEASE #0: Thu May 27 14:42:30 CEST 2004 jylefort@jsite.lefort.net:/usr/obj/usr/src/sys/JSITE i386
>Description:
The gnomehack component of bsd.gnome.mk fixes the locale path in the
Makefile.in files.

However, for most programs the locale path also needs to be patched in
the configure scripts, since it's the place from where the path is
hardwired into the program.

Failing to do so results in a program trying to find its translations
in the wrong location, and the problem is likely to stay unnoticed.

The attached patch fixes the issue.

WARNING: some ports already fix that themselves by the mean of a
configure patch. These ports will break if this patch is committed,
therefore I suggest to mail the maintainers of all the ports using
USE_GNOME=gnomehack and having a configure patch, asking them to fix
their port(s).
>How-To-Repeat:
>Fix:
--- bsd.gnome.mk.orig	Thu Jun 24 00:02:27 2004
+++ bsd.gnome.mk	Thu Jun 24 00:02:34 2004
@@ -59,7 +59,9 @@
 				 s|[(]libdir[)]/bonobo/servers|(prefix)/libdata/bonobo/servers|g' ; \
 			${FIND} ${WRKSRC} -name "configure" | ${XARGS} ${REINPLACE_CMD} -e \
 				's|-lpthread|${PTHREAD_LIBS}|g ; \
-				 s|DATADIRNAME=lib|DATADIRNAME=share|g'
+				 s|DATADIRNAME=lib|DATADIRNAME=share|g ; \
+				 s|{datadir}/locale|{prefix}/share/locale|g ; \
+				 s|{libdir}/locale|{prefix}/share/locale|g'
 
 lthack_PRE_PATCH=	${FIND} ${WRKSRC} -name "configure" | ${XARGS} ${REINPLACE_CMD} -e \
 				'/^LIBTOOL_DEPS="$$ac_aux_dir\/ltmain.sh"$$/s|$$|; $$ac_aux_dir/ltconfig $$LIBTOOL_DEPS;|'
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gnome 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Wed Jun 23 22:43:34 GMT 2004 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=68256 
State-Changed-From-To: open->feedback 
State-Changed-By: marcus 
State-Changed-When: Thu Jun 24 01:14:07 GMT 2004 
State-Changed-Why:  
Can you produce a list of ports that will be broken with this patch?  That 
will make contacting the maintainers easier.  Thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=68256 

From: Jean-Yves Lefort <jylefort@brutele.be>
To: freebsd-gnats-submit@FreeBSD.org
Cc: Joe Marcus Clarke <marcus@FreeBSD.org>
Subject: Re: ports/68256: bsd.gnome.mk locale patch is incomplete
Date: Thu, 24 Jun 2004 19:40:20 +0200

 I did a "make patch" on all the ports using gnomehack and having a
 configure patch. It failed for the following ports:
 
 audio/beast
 audio/streamtuner
 databases/gnomedb
 net/gnomba
 sysutils/gnomecontrolcenter2
 
 Since the number of ports is low and the fixes are trivial, I suggest
 you just fix them and apply the bsd.gnome.mk patch.
State-Changed-From-To: feedback->closed 
State-Changed-By: marcus 
State-Changed-When: Sun Jun 27 17:33:06 GMT 2004 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=68256 
>Unformatted:
