From conrads@cox.net  Mon Jun 14 05:13:09 2004
Return-Path: <conrads@cox.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 176F116A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 14 Jun 2004 05:13:09 +0000 (GMT)
Received: from lakermmtao09.cox.net (lakermmtao09.cox.net [68.230.240.30])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 86D0043D1D
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 14 Jun 2004 05:13:08 +0000 (GMT)
	(envelope-from conrads@cox.net)
Received: from ip68-11-70-23.no.no.cox.net ([68.11.70.23])
          by lakermmtao09.cox.net
          (InterMail vM.6.01.03.02 201-2131-111-104-20040324) with ESMTP
          id <20040614051302.CFKI10317.lakermmtao09.cox.net@ip68-11-70-23.no.no.cox.net>
          for <FreeBSD-gnats-submit@freebsd.org>;
          Mon, 14 Jun 2004 01:13:02 -0400
Received: from ip68-11-70-23.no.no.cox.net (localhost.no.no.cox.net [127.0.0.1])
	by ip68-11-70-23.no.no.cox.net (8.12.11/8.12.11) with ESMTP id i5E5D4gF023597
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 14 Jun 2004 00:13:04 -0500 (CDT)
	(envelope-from conrads@ip68-11-70-23.no.no.cox.net)
Received: (from conrads@localhost)
	by ip68-11-70-23.no.no.cox.net (8.12.11/8.12.11/Submit) id i5E5D4gE023596;
	Mon, 14 Jun 2004 00:13:04 -0500 (CDT)
	(envelope-from conrads)
Message-Id: <200406140513.i5E5D4gE023596@ip68-11-70-23.no.no.cox.net>
Date: Mon, 14 Jun 2004 00:13:04 -0500 (CDT)
From: "Conrad J. Sabatier" <conrads@cox.net>
Reply-To: "Conrad J. Sabatier" <conrads@cox.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: devel/perforce version information missing
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         67920
>Category:       ports
>Synopsis:       devel/perforce version information missing
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 14 05:20:01 GMT 2004
>Closed-Date:    Wed Jun 16 20:31:48 GMT 2004
>Last-Modified:  Wed Jun 16 20:31:48 GMT 2004
>Originator:     Conrad J. Sabatier
>Release:        FreeBSD 5.2-CURRENT amd64
>Organization:
none
>Environment:
System: FreeBSD ip68-11-70-23.no.no.cox.net 5.2-CURRENT FreeBSD 5.2-CURRENT #2: Sun Jun 13 17:37:14 CDT 2004 conrads@ip68-11-70-23.no.no.cox.net:/usr/obj/usr/src/sys/CUSTOM amd64


>Description:

/usr/ports/devel/perforce/Makefile needs to have version info filled in.
The current Makefile contains the following lines:

PORTNAME=       perforce
PORTVERSION=    ${VERSION}
PORTREVISION=   ${REVISION}
PORTEPOCH=      1

This causes a warning to be issued when doing a 'portsdb -u' and/or
'make index', as the first field of the resulting line in INDEX-5 is 
bogus:

perforce-,1|/usr/ports/devel/perforce|/usr/local|Perforce client and server|/usr/ports/devel/perforce/pkg-descr|marshall@chezmarshall.com|devel|||http://www.perforce.com/

# portsdb -uf
[Updating the portsdb <format:bdb1_btree> in /usr/ports ... - 11065 port 
entries found 
.........1000.........2000..../usr/ports/INDEX-5:2446:perforce-,1: ,1: Not 
in due form: '<version>[_<revision>][,<epoch>]'.

>How-To-Repeat:

Do a 'portsdb -u' and/or 'make index'.

>Fix:

Maintainer should add correct version info to the port's Makefile.
>Release-Note:
>Audit-Trail:

From: Pav Lucistnik <pav@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org, conrads@cox.net,
	marshall@chezmarshall.com
Cc:  
Subject: Re: ports/67920: devel/perforce version information missing
Date: Wed, 16 Jun 2004 21:28:46 +0200

 I propose this patch to silence warning about malformed version string
 on unsupported architectures:
 
 Index: Makefile
 ===================================================================
 RCS file: /home/pcvs/ports/devel/perforce/Makefile,v
 retrieving revision 1.30
 diff -a -u -r1.30 Makefile
 --- Makefile	26 May 2004 16:24:27 -0000	1.30
 +++ Makefile	16 Jun 2004 19:26:39 -0000
 @@ -43,6 +43,7 @@
  SBIN_FILES=	p4d
  REL_NOTES=	http://www.perforce.com/perforce/doc.991/user/relnotes.txt
  .else
 +VERSION=	0
  IGNORE=		"Unsupported platform, sorry."
  .endif
  
 Is maintainer fine with this?
 
 -- 
 Pav Lucistnik <pav@oook.cz>
               <pav@FreeBSD.org>
 
 Linux is a happy free-for-all chaos.

From: David Marshall <marshall@chezmarshall.com>
To: pav@FreeBSD.org, freebsd-gnats-submit@FreeBSD.org,
	conrads@cox.net
Cc:  
Subject: Re: ports/67920: devel/perforce version information missing
Date: Wed, 16 Jun 2004 13:17:30 -0700

 OK with me.  Thank you for taking care of this.  I don't know enough about 
 other architectures to have realized that this was a problem.
 
 Have a nice day.
 
 --On Wednesday, June 16, 2004 21:28 +0200 Pav Lucistnik <pav@FreeBSD.org> 
 wrote:
 
 > I propose this patch to silence warning about malformed version string
 > on unsupported architectures:
 >
 > Index: Makefile
 > ===================================================================
 > RCS file: /home/pcvs/ports/devel/perforce/Makefile,v
 > retrieving revision 1.30
 > diff -a -u -r1.30 Makefile
 > --- Makefile	26 May 2004 16:24:27 -0000	1.30
 > +++ Makefile	16 Jun 2004 19:26:39 -0000
 > @@ -43,6 +43,7 @@
 >  SBIN_FILES=	p4d
 >  REL_NOTES=	http://www.perforce.com/perforce/doc.991/user/relnotes.txt
 >  .else
 > +VERSION=	0
 >  IGNORE=		"Unsupported platform, sorry."
 >  .endif
 >
 > Is maintainer fine with this?
 >
 > --
 > Pav Lucistnik <pav@oook.cz>
 >               <pav@FreeBSD.org>
 >
 > Linux is a happy free-for-all chaos.
 
 
 
 
State-Changed-From-To: open->closed 
State-Changed-By: pav 
State-Changed-When: Wed Jun 16 20:31:39 GMT 2004 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=67920 
>Unformatted:
