From cyrille.lefevre@laposte.net  Fri Jun 11 14:33:48 2004
Return-Path: <cyrille.lefevre@laposte.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5A81016A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 11 Jun 2004 14:33:48 +0000 (GMT)
Received: from ioskeha.hittite.isp.9tel.net (ioskeha.hittite.isp.9tel.net [62.62.156.27])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E4E3D43D2F
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 11 Jun 2004 14:33:47 +0000 (GMT)
	(envelope-from cyrille.lefevre@laposte.net)
Received: from mail.gits.dyndns.org (74-118-118-80.kaptech.net [80.118.118.74])
	by ioskeha.hittite.isp.9tel.net (Postfix) with ESMTP id 9F46417BA91
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 11 Jun 2004 16:33:07 +0200 (CEST)
Received: from gits.gits.invalid (IDENT:75p8cgu0ohwfevfr@localhost [127.0.0.1])
	by mail.gits.dyndns.org (8.12.11/8.12.11) with ESMTP id i5BEW0HR076402
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 11 Jun 2004 16:32:01 +0200 (CEST)
	(envelope-from cyrille.lefevre@laposte.net)
Received: by gits.gits.invalid (tmda-sendmail, from uid 0);
	Fri, 11 Jun 2004 16:31:59 +0200 (CEST)
Message-Id: <20040611143146.GA985@gits.dyndns.org>
Date: Fri, 11 Jun 2004 16:31:46 +0200
From: Cyrille Lefevre <cyrille.lefevre@laposte.net>
Reply-To: Cyrille Lefevre <cyrille.lefevre@laposte.net>
To: FreeBSD-gnats-submit@freebsd.org
Subject: Maintainer update: net/isc-dhcp3-server (UNIQUENAME fix)
X-Send-Pr-Version: 3.113

>Number:         67834
>Category:       ports
>Synopsis:       Maintainer update: net/isc-dhcp3-server (UNIQUENAME fix)
>Confidential:   no
>Severity:       critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jun 11 14:40:14 GMT 2004
>Closed-Date:    Fri Jun 18 07:41:12 GMT 2004
>Last-Modified:  Fri Jun 18 07:41:12 GMT 2004
>Originator:     Cyrille Lefevre
>Release:        FreeBSD 5.2-CURRENT i386
>Organization:
ACME
>Environment:
System: FreeBSD gits 5.2-CURRENT FreeBSD 5.2-CURRENT #29: Mon May 31 01:35:59 CEST 2004 root@gits:/disk3/freebsd/current/obj/disk3/freebsd/current/src/sys/CUSTOM i386

>Description:
if options are sets for one of the sub-ports, the others sub-ports
don't ask for the options.

Makefile
PORTREVISION does not need to be bumped, IMHO
UNIQUENAME initialized to $PKGBASE
>How-To-Repeat:
cd ports/net/isc-dhcp3-client
make
(the options dialog is shown)
cd ports/net/isc-dhcp3-server
make
(the options dialog isn't shown)
>Fix:
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/net/isc-dhcp3-server/Makefile,v
retrieving revision 1.95
diff -u -I$Id.*$ -I$.+BSD.*$ -r1.95 Makefile
--- Makefile	1 Jun 2004 13:34:27 -0000	1.95
+++ Makefile	11 Jun 2004 14:28:50 -0000
@@ -24,6 +24,7 @@
 
 SUBSYS?=	server
 
+UNIQUENAME=	${PKGBASE}
 .if ${SUBSYS} == client
 OPTIONS=	INTERFACE_POLLING "interface polling support" on
 .endif
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: vs 
State-Changed-When: Thu Jun 17 11:59:53 GMT 2004 
State-Changed-Why:  
Doesn't work as advertised? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=67834 

From: "Volker Stolz" <vs@freebsd.org>
To: freebsd-gnats-submit@freebsd.org, cyrille.lefevre@laposte.net
Cc:  
Subject: Re: ports/67834: Maintainer update: net/isc-dhcp3-server (UNIQUENAME fix)
Date: Thu, 17 Jun 2004 13:59:22 +0200

 Somehow doesn't work:
 
 isc-dhcp3-server@menelaos [13:58:01]> make -V PKGBASE
 isc-dhcp3-server
 
 Patching file Makefile using Plan A...
 Hunk #1 succeeded at 24.
 Hmm...  Ignoring the trailing garbage.
 done
 isc-dhcp3-server@menelaos [13:57:08]> make
 ===> Using wrong configuration file /var/db/ports//options
 *** Error code 1
 
 Stop in /usr/ports/net/isc-dhcp3-server.
 
 Volker

From: Cyrille Lefevre <cyrille.lefevre@laposte.net>
To: Volker Stolz <vs@FreeBSD.org>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/67834: Maintainer update: net/isc-dhcp3-server (UNIQUENAME
	fix)
Date: Thu, 17 Jun 2004 15:53:12 +0200 (CEST)

 On Jun 17, 2004 01:59:22 pm +0200, Volker Stolz wrote:
 > Somehow doesn't work:
 > 
 > isc-dhcp3-server@menelaos [13:58:01]> make -V PKGBASE
 > isc-dhcp3-server
 > 
 > Patching file Makefile using Plan A...
 > Hunk #1 succeeded at 24.
 > Hmm...  Ignoring the trailing garbage.
 > done
 > isc-dhcp3-server@menelaos [13:57:08]> make
 > ===> Using wrong configuration file /var/db/ports//options
 > *** Error code 1
 > 
 > Stop in /usr/ports/net/isc-dhcp3-server.
 
 ok, PKGBASE is not yet know when needed.
 
 Index: Makefile
 ===================================================================
 RCS file: /home/ncvs/ports/net/isc-dhcp3-server/Makefile,v
 retrieving revision 1.95
 diff -u -I$Id.*$ -I$.+BSD.*$ -r1.95 Makefile
 --- Makefile	1 Jun 2004 13:34:27 -0000	1.95
 +++ Makefile	17 Jun 2004 13:49:08 -0000
 @@ -24,6 +24,7 @@
  
  SUBSYS?=	server
  
 +UNIQUENAME=	${PKGNAMEPREFIX}${PORTNAME}${PKGNAMESUFFIX}	# ${PKGBASE}
  .if ${SUBSYS} == client
  OPTIONS=	INTERFACE_POLLING "interface polling support" on
  .endif
 
 Cyrille.
 -- 
 Cyrille Lefevre
 -- 
 mailto:cyrille.lefevre@laposte.net
State-Changed-From-To: feedback->closed 
State-Changed-By: vs 
State-Changed-When: Fri Jun 18 07:40:57 GMT 2004 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=67834 
>Unformatted:
