From fmysh@quad.dyndns.org  Sun May 30 17:24:36 2004
Return-Path: <fmysh@quad.dyndns.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4D7BF16A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 30 May 2004 17:24:36 -0700 (PDT)
Received: from prime.quad.dyndns.org (12.57.138.210.xn.2iij.net [210.138.57.12])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9CE8843D2F
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 30 May 2004 17:24:35 -0700 (PDT)
	(envelope-from fmysh@quad.dyndns.org)
Received: from localhost (localhost [127.0.0.1])
	by prime.quad.dyndns.org (Postfix) with ESMTP id 743B2F233E;
	Mon, 31 May 2004 09:24:34 +0900 (JST)
Received: from prime.quad.dyndns.org ([127.0.0.1])
 by localhost (prime.quad.dyndns.org [127.0.0.1]) (amavisd-new, port 10024)
 with LMTP id 95569-09; Mon, 31 May 2004 09:24:33 +0900 (JST)
Received: by prime.quad.dyndns.org (Postfix, from userid 1001)
	id 1DB58F2303; Mon, 31 May 2004 09:24:33 +0900 (JST)
Message-Id: <20040531002433.1DB58F2303@prime.quad.dyndns.org>
Date: Mon, 31 May 2004 09:24:33 +0900 (JST)
From: Taoka Fumiyoshi <fmysh@iijmio-mail.jp>
Reply-To: Taoka Fumiyoshi <fmysh@iijmio-mail.jp>
To: FreeBSD-gnats-submit@freebsd.org
Cc: Taoka Fumiyoshi <fmysh@iijmio-mail.jp>
Subject: games/kdegames3 installs some files with invalid uid and gid
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         67403
>Category:       ports
>Synopsis:       games/kdegames3 installs some files with invalid uid and gid
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kde
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun May 30 17:30:22 PDT 2004
>Closed-Date:    Mon Jun 14 12:24:23 GMT 2004
>Last-Modified:  Mon Jun 14 12:24:23 GMT 2004
>Originator:     Taoka Fumiyoshi
>Release:        FreeBSD 5.2-CURRENT i386
>Organization:
>Environment:
>Description:

	games/kdegames3 installs some file with invalid uid and gid.
	They are untared directly into
	/usr/local/share/apps/kgoldrunner/system/levels.
	However they are immediately chowned to root.root, it fails.

	FreeBSD's chown currently uses not `.' but ':' as uid:gid
	separator and their group should be not `root' but `wheel'.

	The failure is hardly noticed during `make install' because
	its output goes to /dev/null and its return code is override
	by true in a makefile.

>How-To-Repeat:
	
# make install
# ls -l /usr/local/share/apps/kgoldrunner/system/levels
total 352
-rw-r--r--  1 500  100   621 Dec  9 20:17 fred
-rw-r--r--  1 500  100   561 Jan 24  2002 level000.grl
-rw-r--r--  1 500  100   561 Jan 24  2002 level001.grl
-rw-r--r--  1 500  100   561 Jan 24  2002 level002.grl
-rw-r--r--  1 500  100   561 Jan 24  2002 level003.grl
-rw-r--r--  1 500  100   561 Jan 24  2002 level004.grl
-rw-r--r--  1 500  100   561 Jan 24  2002 level005.grl
(snip)

>Fix:

diff -uN files.orig/patch-aa files/patch-aa
--- files.orig/patch-aa	Thu Jan  1 09:00:00 1970
+++ files/patch-aa	Mon May 31 08:27:14 2004
@@ -0,0 +1,9 @@
+--- kgoldrunner/gamedata/Makefile.am Mon.orig May 31 07:55:56 2004
++++ kgoldrunner/gamedata/Makefile.am Mon May 31 07:56:16 2004
+@@ -8,6 +8,6 @@
+ 	$(mkinstalldirs) $(DESTDIR)$(gamedatadir)
+ 	pwd=`cd $(srcdir) && pwd` ;\
+ 	cd $(DESTDIR)$(gamedatadir) && tar -xf $$pwd/levels.tar ;\
+-	chown -R root.root levels 2> /dev/null || true ;\
++	chown -R root:wheel levels 2> /dev/null || true ;\
+ 	chmod 644 levels/* 2> /dev/null || true
diff -uN files.orig/patch-ab files/patch-ab
--- files.orig/patch-ab	Thu Jan  1 09:00:00 1970
+++ files/patch-ab	Mon May 31 08:27:25 2004
@@ -0,0 +1,11 @@
+--- kgoldrunner/gamedata/Makefile.in.orig	Mon May 31 08:12:02 2004
++++ kgoldrunner/gamedata/Makefile.in	Mon May 31 08:13:28 2004
+@@ -561,7 +561,7 @@
+ 	$(mkinstalldirs) $(DESTDIR)$(gamedatadir)
+ 	pwd=`cd $(srcdir) && pwd` ;\
+ 	cd $(DESTDIR)$(gamedatadir) && tar -xf $$pwd/levels.tar ;\
+-	chown -R root.root levels 2> /dev/null || true ;\
++	chown -R root:wheel levels 2> /dev/null || true ;\
+ 	chmod 644 levels/* 2> /dev/null || true 
+ # Tell versions [3.59,3.63) of GNU make to not export all variables.
+ # Otherwise a system limit (for SysV at least) may be exceeded.
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->kde 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun May 30 21:05:52 PDT 2004 
Responsible-Changed-Why:  
Over to maintainers 

http://www.freebsd.org/cgi/query-pr.cgi?pr=67403 

From: Michael Nottebrock <lofi@freebsd.org>
To: freebsd-gnats-submit@freebsd.org, fmysh@iijmio-mail.jp
Cc:  
Subject: Re: ports/67403: games/kdegames3 installs some files with invalid uid and gid
Date: Mon, 31 May 2004 16:31:51 +0200

 I have filed a bug in KDE's bugzilla about this, 
 http://bugs.kde.org/show_bug.cgi?id=82584.
 
State-Changed-From-To: open->closed 
State-Changed-By: lofi 
State-Changed-When: Mon Jun 14 12:23:53 GMT 2004 
State-Changed-Why:  
Committed, thanks! 


http://www.freebsd.org/cgi/query-pr.cgi?pr=67403 
>Unformatted:
