From bogorodskiy@inbox.ru  Mon May 24 20:58:57 2004
Return-Path: <bogorodskiy@inbox.ru>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 10DC916A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 24 May 2004 20:58:57 -0700 (PDT)
Received: from mx2.mail.ru (mx2.mail.ru [194.67.23.122])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 27FFF43D39
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 24 May 2004 20:58:56 -0700 (PDT)
	(envelope-from bogorodskiy@inbox.ru)
Received: from [194.186.150.72] (port=49199 helo=inbox.ru)
	by mx2.mail.ru with esmtp 
	id 1BST47-000Knm-00
	for FreeBSD-gnats-submit@freebsd.org; Tue, 25 May 2004 07:57:27 +0400
Message-Id: <E1BST47-000Knm-00.bogorodskiy-inbox-ru@mx2.mail.ru>
Date: Tue, 25 May 2004 07:57:27 +0400
From: Roman Bogorodskiy <bogorodskiy@inbox.ru>
Reply-To: Roman Bogorodskiy <bogorodskiy@inbox.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: benchmarks/stream: checksum update
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         67159
>Category:       ports
>Synopsis:       benchmarks/stream: checksum update
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon May 24 21:00:41 PDT 2004
>Closed-Date:    Wed Jun 09 20:00:31 GMT 2004
>Last-Modified:  Wed Jun 09 20:00:31 GMT 2004
>Originator:     Roman Bogorodskiy
>Release:        FreeBSD 5.2.1-RELEASE-p6 i386
>Organization:
>Environment:
System: FreeBSD lame.novel.ru 5.2.1-RELEASE-p6 FreeBSD 5.2.1-RELEASE-p6 #0: Tue May 18 12:31:41 MSD 2004 root@lame.novel.ru:/usr/obj/usr/src/sys/NOV i386

>Description:
	Checksum updated, port may be unmarked as BROKEN. 
>How-To-Repeat:
	
>Fix:

diff -ruN stream.bak/Makefile stream/Makefile
--- stream.bak/Makefile	Tue May 25 07:45:34 2004
+++ stream/Makefile	Tue May 25 07:52:57 2004
@@ -6,6 +6,7 @@
 
 PORTNAME=	stream
 PORTVERSION=	1.0
+PORTREVISION=	1
 CATEGORIES=	benchmarks
 MASTER_SITES=	ftp://ftp.cs.virginia.edu/pub/stream/Code/
 DISTFILES=	second_cpu.c stream_d.c
@@ -13,8 +14,6 @@
 
 MAINTAINER=	sf@slappy.org
 COMMENT=	Synthetic benchmark program that measures sustainable memory bandwidth
-
-BROKEN=		"Checksum mismatch"
 
 MAKEFILE=	${FILESDIR}/Makefile
 PLIST_FILES=	bin/stream
diff -ruN stream.bak/distinfo stream/distinfo
--- stream.bak/distinfo	Tue May 25 07:45:34 2004
+++ stream/distinfo	Tue May 25 07:47:51 2004
@@ -1,2 +1,4 @@
-MD5 (stream-1.0/second_cpu.c) = ec4d884bbe6832f21615617e54af187f
-MD5 (stream-1.0/stream_d.c) = 87e07a8a6e898d2b7f1d60324da46531
+MD5 (stream-1.0/second_cpu.c) = 65f4111f06a5f5a677925fa0ede61416
+SIZE (stream-1.0/second_cpu.c) = 287
+MD5 (stream-1.0/stream_d.c) = 76ef0d3b0c8884a130e8a723da96697b
+SIZE (stream-1.0/stream_d.c) = 5555
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback  
State-Changed-By: krion 
State-Changed-When: Tue May 25 02:20:21 PDT 2004 
State-Changed-Why:  
Asked for maintainer's feedback. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=67159 

From: Kirill Ponomarew <krion@voodoo.oberon.net>
To: sf@slappy.org
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/67159: benchmarks/stream: checksum update
Date: Tue, 25 May 2004 11:20:12 +0200

 --L6iaP+gRLNZHKoI4
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 Hi,
 
 Could you please review this PR and approve/reject it ?
 
 http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/67159
 
 -Kirill
 
 --L6iaP+gRLNZHKoI4
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.4 (FreeBSD)
 
 iD8DBQFAsw/MQC1G6a60JuURAmz7AKC3swbpBaTJ56CDmBsAkQPtG7iuowCfW3jr
 /jVQdQbqbK5bB9AMsZUydqc=
 =LfEr
 -----END PGP SIGNATURE-----
 
 --L6iaP+gRLNZHKoI4--

From: Pav Lucistnik <pav@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org, bogorodskiy@inbox.ru
Cc:  
Subject: Re: ports/67159: benchmarks/stream: checksum update
Date: Sun, 30 May 2004 11:03:46 +0200

 Here is the diff between old and new distfile:
 
 diff -ruN old/second_cpu.c new/second_cpu.c
 --- old/second_cpu.c	Tue Oct 24 22:47:59 1995
 +++ new/second_cpu.c	Tue Apr  8 17:25:14 2003
 @@ -3,7 +3,7 @@
  #include <sys/times.h>
  #include <time.h>
  
 -double second()
 +double mysecond()
  {
      long sec;
      double secx;
 diff -ruN old/stream_d.c new/stream_d.c
 --- old/stream_d.c	Wed Nov 27 13:56:30 2002
 +++ new/stream_d.c	Fri Jan 10 23:12:50 2003
 @@ -34,7 +34,7 @@
   *	   other hand, the optimizer might be too smart for me!
   *
   *         Try compiling with:
 - *               cc -O stream_d.c second.c -o stream_d -lm
 + *               cc -O stream_d.c second_wall.c -o stream_d -lm
   *
   *         This is known to work on Cray, SGI, IBM, and Sun machines.
   *
 @@ -74,7 +74,7 @@
      3 * sizeof(double) * N
      };
  
 -extern double second();
 +extern double mysecond();
  
  int
  main()
 @@ -115,10 +115,10 @@
  	printf("Your clock granularity appears to be "
  	    "less than one microsecond.\n");
  
 -    t = second();
 +    t = mysecond();
      for (j = 0; j < N; j++)
  	a[j] = 2.0E0 * a[j];
 -    t = 1.0E6 * (second() - t);
 +    t = 1.0E6 * (mysecond() - t);
  
      printf("Each test below will take on the order"
  	" of %d microseconds.\n", (int) t  );
 @@ -138,25 +138,25 @@
      scalar = 3.0;
      for (k=0; k<NTIMES; k++)
  	{
 -	times[0][k] = second();
 +	times[0][k] = mysecond();
  	for (j=0; j<N; j++)
  	    c[j] = a[j];
 -	times[0][k] = second() - times[0][k];
 +	times[0][k] = mysecond() - times[0][k];
  	
 -	times[1][k] = second();
 +	times[1][k] = mysecond();
  	for (j=0; j<N; j++)
  	    b[j] = scalar*c[j];
 -	times[1][k] = second() - times[1][k];
 +	times[1][k] = mysecond() - times[1][k];
  	
 -	times[2][k] = second();
 +	times[2][k] = mysecond();
  	for (j=0; j<N; j++)
  	    c[j] = a[j]+b[j];
 -	times[2][k] = second() - times[2][k];
 +	times[2][k] = mysecond() - times[2][k];
  	
 -	times[3][k] = second();
 +	times[3][k] = mysecond();
  	for (j=0; j<N; j++)
  	    a[j] = b[j]+scalar*c[j];
 -	times[3][k] = second() - times[3][k];
 +	times[3][k] = mysecond() - times[3][k];
  	}
      
      /*	--- SUMMARY --- */
 @@ -195,8 +195,8 @@
  /*  Collect a sequence of M unique time values from the system. */
  
      for (i = 0; i < M; i++) {
 -	t1 = second();
 -	while( ((t2=second()) - t1) < 1.0E-6 )
 +	t1 = mysecond();
 +	while( ((t2=mysecond()) - t1) < 1.0E-6 )
  	    ;
  	timesfound[i] = t1 = t2;
  	}
 
 -- 
 Pav Lucistnik <pav@oook.cz>
               <pav@FreeBSD.org>
 
 Pain clots and unformed lice pat this train.

From: Roman Bogorodskiy <bogorodskiy@inbox.ru>
To: Pav Lucistnik <pav@FreeBSD.org>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/67159: benchmarks/stream: checksum update
Date: Sun, 30 May 2004 13:10:47 +0400

 --E39vaYmALEf/7YXx
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
  Pav wrote:
 
 >dd<
 
 Looks like just s/second/mysecond/g was done. =20
 
 -Roman Bogorodskiy
 
 --E39vaYmALEf/7YXx
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.4 (FreeBSD)
 
 iQCVAwUBQLmlF4B0WzgdqspGAQLKXwQAwGdAzWIo1uKrsDHTTRXyB2qSR0VwNWLP
 gpP7t4J69AbfhXBCDPY+RXT8pCacllJa+pdKvI/ZNGMKVrzSAzeZ6ak779fVHJNA
 WRFr9Rqjvzr4tivdnSiztFFfJo54dZrw6HLYjJGwFvTeuk95JQkIjxbs1seKzidi
 KylftUofLvA=
 =IgTH
 -----END PGP SIGNATURE-----
 
 --E39vaYmALEf/7YXx--
State-Changed-From-To: feedback->closed 
State-Changed-By: pav 
State-Changed-When: Wed Jun 9 20:00:18 GMT 2004 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=67159 
>Unformatted:
