From root@ahze.ahze.net  Mon May 24 12:31:41 2004
Return-Path: <root@ahze.ahze.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7B55D16A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 24 May 2004 12:31:41 -0700 (PDT)
Received: from ahze.ahze.net (adsl-068-209-163-003.sip.clt.bellsouth.net [68.209.163.3])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 28EEC43D41
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 24 May 2004 12:31:41 -0700 (PDT)
	(envelope-from root@ahze.ahze.net)
Received: by ahze.ahze.net (Postfix, from userid 0)
	id 9299F68D8; Mon, 24 May 2004 15:32:09 -0400 (EDT)
Message-Id: <20040524193209.9299F68D8@ahze.ahze.net>
Date: Mon, 24 May 2004 15:32:09 -0400 (EDT)
From: michael johnson <ahze@ahze.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc: riggs@rrr.de
Subject: [PATCH] multimedia/mplayer: [add knob for WITH_KERN_HZ]
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         67134
>Category:       ports
>Synopsis:       [PATCH] multimedia/mplayer: [add knob for WITH_KERN_HZ]
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pav
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon May 24 12:40:21 PDT 2004
>Closed-Date:    Tue May 25 02:12:17 PDT 2004
>Last-Modified:  Tue May 25 02:12:17 PDT 2004
>Originator:     michael johnson
>Release:        FreeBSD 5.2-CURRENT i386
>Organization:
>Environment:
System: FreeBSD gentoo.ahze.net 5.2-CURRENT FreeBSD 5.2-CURRENT #45: Mon May  3 05:09:04 EDT
>Description:
- add knob for WITH_KERN_HZ
  this can be useful if you have a slower processor when using RTC. 

Port maintainer (riggs@rrr.de) is cc'd.

Generated with FreeBSD Port Tools 0.50
>How-To-Repeat:
>Fix:

--- mplayer-0.92.1_1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/multimedia/mplayer/Makefile,v
retrieving revision 1.91
diff -u -r1.91 Makefile
--- Makefile	16 Apr 2004 20:24:22 -0000	1.91
+++ Makefile	24 May 2004 19:08:08 -0000
@@ -89,6 +89,13 @@
 # defaulting to usleep() timing. This can improve cpu load as well
 # as run-time accuracy.
 #
+# WITH_KERN_HZ
+# default: 1024
+# This option allows you to control the default kern.hz when using RTC support.
+# If you have a older/slower processor you may want to lower the default level.
+# ie. 512 seems to produce better quality video on a PII 400MHz than 1024 does
+# CAUTION: lower than 512 may produce jerky video.
+#
 # Feature options:
 # These options influence, which libraries mplayer is linked to.
 # Note: The libraries are needed to play the particular files under
@@ -567,6 +574,12 @@
 .endif
 .endif
 
+.if defined(WITH_KERN_HZ)
+DEFAULT_KERN_HZ=${WITH_KERN_HZ}
+.else
+DEFAULT_KERN_HZ=1024
+.endif
+
 # "enable" build for other archs
 .if ${ARCH} == "i386"
 .if !defined(WITHOUT_RUNTIME_CPUDETECTION)
@@ -648,6 +661,9 @@
 	@${REINPLACE_CMD} -e \
 		's|rtc_fd|rtc|' \
 		${WRKSRC}/mplayer.c
+	@${REINPLACE_CMD} -e \
+		's|irqp = 1024|irqp = ${DEFAULT_KERN_HZ}|' \
+		${WRKSRC}/mplayer.c
 .endif
 
 pre-configure:
--- mplayer-0.92.1_1.patch ends here ---

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: pav 
State-Changed-When: Mon May 24 16:47:41 PDT 2004 
State-Changed-Why:  
Asked maintainer for approval. 


Responsible-Changed-From-To: freebsd-ports-bugs->pav 
Responsible-Changed-By: pav 
Responsible-Changed-When: Mon May 24 16:47:41 PDT 2004 
Responsible-Changed-Why:  
Handle. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=67134 

From: Pav Lucistnik <pav@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org, ahze@ahze.net, riggs@rrr.de
Cc:  
Subject: Re: ports/67134: [PATCH] multimedia/mplayer: [add knob for
	WITH_KERN_HZ]
Date: Tue, 25 May 2004 01:47:38 +0200

 Dear maintainer of FreeBSD port multimedia/mplayer, please take a look
 at
 
 http://www.freebsd.org/cgi/query-pr.cgi?q=67134
 
 Do you approve this patch?
 
 -- 
 Pav Lucistnik <pav@oook.cz>
               <pav@FreeBSD.org>
 
 Knight: We shall say Ny! again to you if you do not appease us.
 Arthur: All right. What do you want?
 Knight: We want... a shruberry!
State-Changed-From-To: feedback->closed 
State-Changed-By: pav 
State-Changed-When: Tue May 25 02:12:09 PDT 2004 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=67134 
>Unformatted:
