From ronald@cs.vu.nl  Thu May 20 15:27:35 2004
Return-Path: <ronald@cs.vu.nl>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 68B0416A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 20 May 2004 15:27:35 -0700 (PDT)
Received: from smtp15.wxs.nl (smtp15.wxs.nl [195.121.6.54])
	by mx1.FreeBSD.org (Postfix) with ESMTP id BB5DF43D46
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 20 May 2004 15:27:34 -0700 (PDT)
	(envelope-from ronald@cs.vu.nl)
Received: from ronald.echteman.nl
 (ip51cdc5d2.adsl-surfen.hetnet.nl [81.205.197.210])
 by smtp15.wxs.nl (iPlanet Messaging Server 5.2 HotFix 1.25 (built Mar  3
 2004)) with SMTP id <0HY100IO2ADXBJ@smtp15.wxs.nl> for
 FreeBSD-gnats-submit@freebsd.org; Fri, 21 May 2004 00:27:33 +0200 (CEST)
Received: (qmail 6752 invoked from network); Thu, 20 May 2004 22:27:33 +0000
Received: from unknown (HELO laptop.thuis.klop.ws) (192.168.1.4)
 by ronald.echteman.nl with SMTP; Thu, 20 May 2004 22:27:33 +0000
Received: (qmail 1561 invoked from network); Thu, 20 May 2004 22:27:32 +0000
Received: from unknown (HELO henk.thuis.klop.ws) (192.168.0.2)
 by 192.168.0.16 with SMTP; Thu, 20 May 2004 22:27:32 +0000
Received: (qmail 59059 invoked from network); Thu, 20 May 2004 22:27:32 +0000
Received: from localhost.thuis.klop.ws (HELO guido.thuis.klop.ws) (127.0.0.1)
 by localhost.thuis.klop.ws with SMTP; Thu, 20 May 2004 22:27:32 +0000
Message-Id: <1085092052.0@guido.thuis.klop.ws>
Date: Fri, 21 May 2004 00:27:32 +0200
From: Ronald Klop <ronald@cs.vu.nl>
To: FreeBSD gnats submit <FreeBSD-gnats-submit@freebsd.org>
Cc: ronald@cs.vu.nl
Subject: [patch] Update to new bsd.java.mk
X-Send-Pr-Version: gtk-send-pr 0.3.3
X-GNATS-Notify:

>Number:         66965
>Category:       ports
>Synopsis:       [patch] Update to new bsd.java.mk
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    glewis
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 20 15:30:15 PDT 2004
>Closed-Date:    Fri Jun 25 13:55:12 GMT 2004
>Last-Modified:  Fri Jun 25 13:55:12 GMT 2004
>Originator:     Ronald Klop
>Release:        FreeBSD 5.2-CURRENT i386
>Organization:
>Environment:


System: FreeBSD 5.2-CURRENT #19: Tue May 18 09:01:40 CEST 2004
    root@guido.thuis.klop.ws:/usr/obj/usr/src/sys/HENK



>Description:


Update to latest bsd.java.mk.
Use libtool 1.5 in stead of 1.3.
Add an option for compiling with -O3.



>How-To-Repeat:





>Fix:


--- jmp.diff begins here ---
diff -uNr0 /usr/ports/java/jmp/Makefile jmp/Makefile
--- /usr/ports/java/jmp/Makefile	Mon Apr  5 18:54:38 2004
+++ jmp/Makefile	Wed May 12 17:13:30 2004
@@ -20,0 +21 @@
+OPTIONS+=	OPTIMIZED_CFLAGS "Compile with -O3" off
@@ -31,0 +33,4 @@
+.if defined(WITH_OPTIMIZED_CFLAGS)
+CFLAGS+=	-O3
+.endif
+
@@ -36 +41 @@
-USE_LIBTOOL_VER=13
+USE_LIBTOOL_VER=15
@@ -38,2 +43,4 @@
-USE_JAVA=	1.2+
-NEED_JAVAC=	yes
+USE_JAVA=      yes
+JAVA_VERSION=  1.2+
+JAVA_OS=	native
+JAVA_BUILD=	jdk
--- jmp.diff ends here ---



>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->znerd 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu May 20 18:32:58 PDT 2004 
Responsible-Changed-Why:  
Over to maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=66965 
Responsible-Changed-From-To: znerd->glewis 
Responsible-Changed-By: glewis 
Responsible-Changed-When: Fri Jun 25 04:38:53 GMT 2004 
Responsible-Changed-Why:  
znerd is maintainer of java/jump, not java/jmp.  I'll take this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=66965 
State-Changed-From-To: open->feedback 
State-Changed-By: glewis 
State-Changed-When: Fri Jun 25 04:44:07 GMT 2004 
State-Changed-Why:  
Ronald, I have committed the first two changes from the PR (bsd.java.mk 
and libtool version).  Thanks! 

I'd like some feedback on the OPTIMIZED_CFLAGS change though.  Personally, 
I don't see that it provides anything which isn't already available in a 
very similar fashion by setting CFLAGS (on the command line, in the 
environment, in /etc/make.conf, etc).  My preference would be to keep it 
consistent with other ports, which should all support this this sort of 
change by respecting CFLAGS. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=66965 
State-Changed-From-To: feedback->closed 
State-Changed-By: glewis 
State-Changed-When: Fri Jun 25 13:54:45 GMT 2004 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=66965 
>Unformatted:
