From neuhauser@chello.cz  Tue May 18 16:56:46 2004
Return-Path: <neuhauser@chello.cz>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0CB2416A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 18 May 2004 16:56:46 -0700 (PDT)
Received: from smtp.dkm.cz (smtp.dkm.cz [62.24.64.34])
	by mx1.FreeBSD.org (Postfix) with SMTP id CF1D143D1D
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 18 May 2004 16:56:44 -0700 (PDT)
	(envelope-from neuhauser@chello.cz)
Received: (qmail 52931 invoked by uid 0); 18 May 2004 22:53:34 -0000
Received: from r3al16.mistral.cz (HELO isis.wad.cz) (213.220.229.16)
  by smtp.dkm.cz with SMTP; 18 May 2004 22:53:34 -0000
Received: by isis.wad.cz (Postfix, from userid 1001)
	id 34D0E2FDA01; Wed, 19 May 2004 00:53:34 +0200 (CEST)
Message-Id: <20040518225334.34D0E2FDA01@isis.wad.cz>
Date: Wed, 19 May 2004 00:53:34 +0200 (CEST)
From: Roman Neuhauser <neuhauser@chello.cz>
Reply-To: Roman Neuhauser <neuhauser@chello.cz>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] devel/pccts: avoid "installation successful" in the build target
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         66844
>Category:       ports
>Synopsis:       [PATCH] devel/pccts: avoid "installation successful" in the build target
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 18 17:00:42 PDT 2004
>Closed-Date:    Sun May 30 08:38:42 PDT 2004
>Last-Modified:  Sun May 30 08:38:42 PDT 2004
>Originator:     Roman Neuhauser
>Release:        FreeBSD 4.9-RELEASE-p2 i386
>Organization:
>Environment:
System: FreeBSD isis.wad.cz 4.9-RELEASE-p2 FreeBSD 4.9-RELEASE-p2 #3: Sun Mar 7 02:11:16 CET 2004 root@isis.wad.cz:/usr/obj/usr/src/sys/FREEPUPPY2_6 i386


	
>Description:
    original target prints out "PCCTS 1.33MR33 installation complete",
    and other installation-related messages. this patch avoids this
    by providing do-build target. thanks to inconsistency in software's
    makefiles, genmk is installed from a different place now.

>How-To-Repeat:
	
>Fix:

	

--- devel::pccts.do-build.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/devel/pccts/Makefile,v
retrieving revision 1.25
diff -u -r1.25 Makefile
--- Makefile	29 Jan 2004 12:50:38 -0000	1.25
+++ Makefile	18 May 2004 22:42:36 -0000
@@ -30,10 +30,15 @@
 	@${FIND} ${WRKSRC} -name "*.c" | ${XARGS} ${REINPLACE_CMD} -e \
 		's|<varargs.h>|<stdarg.h>|g'
 
+do-build:
+.for dir in antlr dlg sorcerer support/genmk
+	@(cd ${BUILD_WRKSRC}/${dir}; ${SETENV} ${MAKE_ENV} ${MAKE} ${MAKE_FLAGS} ${MAKEFILE} ${MAKE_ARGS} ${ALL_TARGET})
+.endfor
+
 do-install:
 	@ ${INSTALL_PROGRAM} ${WRKSRC}/bin/antlr ${PREFIX}/bin
 	@ ${INSTALL_PROGRAM} ${WRKSRC}/bin/dlg ${PREFIX}/bin
-	@ ${INSTALL_PROGRAM} ${WRKSRC}/bin/genmk ${PREFIX}/bin
+	@ ${INSTALL_PROGRAM} ${WRKSRC}/support/genmk/genmk ${PREFIX}/bin
 	@ ${INSTALL_PROGRAM} ${WRKSRC}/bin/sor ${PREFIX}/bin
 	@ ${INSTALL_MAN} ${WRKSRC}/antlr/antlr.1 ${PREFIX}/man/man1
 	@ ${INSTALL_MAN} ${WRKSRC}/dlg/dlg.1 ${PREFIX}/man/man1
--- devel::pccts.do-build.patch ends here ---


>Release-Note:
>Audit-Trail:

From: Volker Stolz <vs@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org, neuhauser@chello.cz
Cc:  
Subject: Re: ports/66844: [PATCH] devel/pccts: avoid "installation successful" in the build target
Date: Fri, 21 May 2004 11:11:09 +0200

 Once I again I have to disagree ;) You should simply remove the offending 
 @echo from
 the applications Makefile instead of creating an explicit do-build-target. 
 You are
 making maintenance harder, e.g. if there's an update which changes the 
 "inner" machinery
 (though I think pccts is EOL). This would also avoid touching the 
 do-install-part, right?
 
 Cheers,
    Volker

From: Roman Neuhauser <neuhauser@chello.cz>
To: Volker Stolz <vs@FreeBSD.org>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/66844: [PATCH] devel/pccts: avoid "installation successful" in the build target
Date: Fri, 21 May 2004 12:16:01 +0200

 # vs@FreeBSD.org / 2004-05-21 11:11:09 +0200:
 > Once I again I have to disagree ;) You should simply remove the
 > offending @echo from the applications Makefile instead of creating an
 > explicit do-build-target. 
 > You are making maintenance harder, e.g. if there's an update which
 > changes the "inner" machinery (though I think pccts is EOL).
 
     Would a patch like the one below please you more?
     This would clearly make maintenance harder, e. g. there's an update
     which changes the banner, and the patch doesn't apply anymore.
     Plus it's roughly 40 lines instead of 5 or 6.
 
     But this is all moot, pccts has been superceded by antlr, and
     doesn't seem to be developed any more.  See http://www.antlr.org/
 
 > This would also avoid touching the do-install-part, right?
 
     No it would not. The upstream makefile is... very unorthodox.
 
 --- makefile.orig	Fri May 21 12:06:12 2004
 +++ makefile	Fri May 21 12:06:54 2004
 @@ -20,41 +20,11 @@
  #COPT=-O2
  
  pccts:
 -	@echo " "
 -	@echo "             Welcome to PCCTS 1.33MR33 installation"
 -	@echo " "
 -	@echo "             (Version 1.33 Maintenance Release #33)" # mrxxx
 -	@echo " "
 -	@echo "                  Released 19 April 2002"
 -	@echo " "
 -	@echo "                        Featuring"
 -	@echo "         ANTLR     -- ANother Tool for Language Recognition"
 -	@echo "         DLG       -- DFA-based Lexical Analyzer Generator"
 -	@echo "         SORCERER  -- Source-to-source translator (tree walker)" 
 -	@echo " "
 -	@echo "                  http://www.antlr.org"	
 -	@echo " "
 -	@echo "             Trouble reports to tmoog@polhode.com"
 -	@echo "             Additional PCCTS 1.33 information at"
 -	@echo "                  http://www.polhode.com"
 -	@echo
 -	@echo
 -	@echo "To substitute gcc for CC to invoke compiler: make CC=gcc"
 -	@echo "If there are problems with cr and lf try: unzip -a ..."
 -	@echo
 -#
  	@if [ ! -d $(BINDIR) ] ; then mkdir $(BINDIR) ; fi
 -	@echo Making executables...
  	(cd ./antlr; $(MAKE) CC="$(CC)" COPT="$(COPT)")
 -	@echo antlr executable now in $(BINDIR)
  	(cd ./dlg; $(MAKE) CC="$(CC)" COPT="$(COPT)")
 -	@echo dlg executable now in $(BINDIR)
  	(cd ./sorcerer; $(MAKE) CC="$(CC)" COPT="$(COPT)")
 -	@echo sorcerer executable now in $(BINDIR)
  	(cd ./support/genmk; $(MAKE) CC="$(CC)" COPT="$(COPT)"; mv genmk ../../$(BINDIR))
 -	@echo genmk executable now in $(BINDIR)
 -	@echo
 -	@echo "       PCCTS 1.33MR33 installation complete"  # MRXXX
  
  clean:
  	(cd ./antlr; $(MAKE) -s clean)
 
 -- 
 FreeBSD 4.9-RELEASE-p2
 12:07PM up 4:02, 8 users, load averages: 0.00, 0.01, 0.00

From: Roman Neuhauser <neuhauser@chello.cz>
To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org
Cc:  
Subject: Re: ports/66844: [PATCH] devel/pccts: avoid "installation successful" in the build target
Date: Sat, 29 May 2004 02:58:36 +0200

 so, what's up with this one? :)

From: Pav Lucistnik <pav@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org, neuhauser@chello.cz
Cc:  
Subject: Re: ports/66844: [PATCH] devel/pccts: avoid "installation
	successful" in the build target
Date: Sun, 30 May 2004 11:46:41 +0200

 Personally I don't think this is worth effort and future maintenance
 costs. I vote for just closing this PR. What do you think, Roman?
 
 -- 
 Pav Lucistnik <pav@oook.cz>
               <pav@FreeBSD.org>
 
 You take the red pill, you stay in Wonderland, and I show you how deep
 the rabbit hole goes....

From: Roman Neuhauser <neuhauser@chello.cz>
To: Pav Lucistnik <pav@FreeBSD.org>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/66844: [PATCH] devel/pccts: avoid "installation successful" in the build target
Date: Sun, 30 May 2004 13:49:53 +0200

 --J/dobhs11T7y2rNN
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 # pav@FreeBSD.org / 2004-05-30 11:46:41 +0200:
 > Personally I don't think this is worth effort and future maintenance
 > costs. I vote for just closing this PR. What do you think, Roman?
 
     well, I don't like it being left to rot. either it's obsolete
     ballast and we jettison it or it deserves at lest minimal attention.
 
     the effort has already been expended, and given that pccts is EOL
     the only maintenance it requires is catching up with changes in
     the ports infrastructure, at least as long as it compiles.
 
     so yes, I agree we should not spend too much effort on it, but it
     has been easy so far. either deorbit it or give me maintainership,
     commit the patch, and I'll yell when it gets over my head. which
     may be soon as I have no use for it, and possess limited knowledge
     of C. or it might hum along for another few years.
 
     I don't really care what happens with the port as long as there is
     an action; I don't see leaving it as it is an option.
 
 -- 
 FreeBSD 4.9-RELEASE-p2
 1:07PM up 2 mins, 2 users, load averages: 0.07, 0.04, 0.01
 
 --J/dobhs11T7y2rNN
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="devel::pccts.MAINTAINER.patch"
 
 Index: devel/pccts/Makefile
 ===================================================================
 RCS file: /home/ncvs/ports/devel/pccts/Makefile,v
 retrieving revision 1.25
 diff -u -u -r1.25 Makefile
 --- devel/pccts/Makefile	29 Jan 2004 12:50:38 -0000	1.25
 +++ devel/pccts/Makefile	30 May 2004 11:45:37 -0000
 @@ -12,7 +12,8 @@
  MASTER_SITES=		http://www.polhode.com/
  DISTNAME=		pccts${PORTVERSION:R:S/.//}mr${PORTVERSION:E}
  
 -MAINTAINER=		ports@FreeBSD.org
 +# this port needs a maintainer, any offer accepted :)
 +MAINTAINER=		neuhauser@chello.cz
  COMMENT=	The Purdue Compiler Construction Tool Set
  
  CONFLICTS=	antlr*
 
 --J/dobhs11T7y2rNN--
State-Changed-From-To: open->closed 
State-Changed-By: pav 
State-Changed-When: Sun May 30 08:38:27 PDT 2004 
State-Changed-Why:  
Second and part of third patch applied. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=66844 
>Unformatted:
