From lth@dask.thegler.dk  Tue May 11 05:51:15 2004
Return-Path: <lth@dask.thegler.dk>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3DFEA16A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 11 May 2004 05:51:15 -0700 (PDT)
Received: from cicero2.cybercity.dk (cicero2.cybercity.dk [212.242.40.53])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 563D643D5E
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 11 May 2004 05:51:14 -0700 (PDT)
	(envelope-from lth@dask.thegler.dk)
Received: from dask.thegler.dk (port156.ds1-bav.adsl.cybercity.dk [217.157.188.161])
	by cicero2.cybercity.dk (Postfix) with ESMTP
	id 3698318FDF1; Tue, 11 May 2004 14:51:09 +0200 (CEST)
Received: by dask.thegler.dk (Postfix, from userid 1001)
	id 0CCC73EBD; Tue, 11 May 2004 14:51:09 +0200 (CEST)
Message-Id: <20040511125109.0CCC73EBD@dask.thegler.dk>
Date: Tue, 11 May 2004 14:51:09 +0200 (CEST)
From: Lars Thegler <lars@thegler.dk>
To: FreeBSD-gnats-submit@freebsd.org
Cc: cyrille.lefevre@laposte.net
Subject: [PATCH] french/plgrenouille: Fix for pre-5.6 perl
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         66525
>Category:       ports
>Synopsis:       [PATCH] french/plgrenouille: Fix for pre-5.6 perl
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 11 06:00:42 PDT 2004
>Closed-Date:    Fri May 21 07:02:07 PDT 2004
>Last-Modified:  Fri May 21 07:02:07 PDT 2004
>Originator:     Lars Thegler
>Release:        FreeBSD 4.10-BETA i386
>Organization:
>Environment:
System: FreeBSD dask.thegler.dk 4.10-BETA FreeBSD 4.10-BETA #3: Mon Apr 12 17:02:50 CEST 2004
>Description:
Fix for pre-5.6 perl

Port maintainer (cyrille.lefevre@laposte.net) is cc'd.

Generated with FreeBSD Port Tools 0.50
>How-To-Repeat:
>Fix:

--- plgrenouille-0.70.6.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/french/plgrenouille/Makefile,v
retrieving revision 1.8
diff -u -r1.8 Makefile
--- Makefile	12 Mar 2004 23:49:14 -0000	1.8
+++ Makefile	11 May 2004 12:50:18 -0000
@@ -16,7 +16,6 @@
 
 LIB_DEPENDS=	netsnmp.6:${PORTSDIR}/net-mgmt/net-snmp
 RUN_DEPENDS=	${SITE_PERL}/Net/FTP.pm:${PORTSDIR}/net/p5-Net \
-		${SITE_PERL}/Net/SNMP.pm:${PORTSDIR}/net-mgmt/p5-Net-SNMP \
 		${SITE_PERL}/${PERL_ARCH}/Time/HiRes.pm:${PORTSDIR}/devel/p5-Time-HiRes
 
 .if !defined(BATCH)
@@ -110,4 +109,12 @@
 configure-package:
 	@${SETENV} ${SCRIPTS_ENV} ${SH} ${PKGINSTALL} ${PKGNAME} POST-INSTALL
 
-.include <bsd.port.mk>
+.include <bsd.port.pre.mk>
+
+.if ${PERL_LEVEL} < 500600
+RUN_DEPENDS+=	${SITE_PERL}/Net/SNMP.pm:${PORTSDIR}/net-mgmt/p5-Net-SNMP3
+.else
+RUN_DEPENDS+=	${SITE_PERL}/Net/SNMP.pm:${PORTSDIR}/net-mgmt/p5-Net-SNMP
+.endif
+
+.include <bsd.port.post.mk>
--- plgrenouille-0.70.6.patch ends here ---

>Release-Note:
>Audit-Trail:

From: Cyrille Lefevre <cyrille.lefevre@laposte.net>
To: freebsd gnats <freebsd-gnats-submit@freebsd.org>
Cc:  
Subject: Re: ports/66525: [PATCH] french/plgrenouille: Fix for pre-5.6 perl
Date: Tue, 11 May 2004 23:24:29 +0200 (CEST)

 almost approved, except that I prefer to keep RUN_DEPENDS close.
 
 Index: Makefile
 ===================================================================
 RCS file: /home/ncvs/ports/french/plgrenouille/Makefile,v
 retrieving revision 1.8
 diff -u -I$Id.*$ -I$.+BSD.*$ -r1.8 Makefile
 --- Makefile	12 Mar 2004 23:49:14 -0000	1.8
 +++ Makefile	11 May 2004 21:23:14 -0000
 @@ -16,9 +16,15 @@
  
  LIB_DEPENDS=	netsnmp.6:${PORTSDIR}/net-mgmt/net-snmp
  RUN_DEPENDS=	${SITE_PERL}/Net/FTP.pm:${PORTSDIR}/net/p5-Net \
 -		${SITE_PERL}/Net/SNMP.pm:${PORTSDIR}/net-mgmt/p5-Net-SNMP \
  		${SITE_PERL}/${PERL_ARCH}/Time/HiRes.pm:${PORTSDIR}/devel/p5-Time-HiRes
  
 +.include <bsd.port.pre.mk>
 +.if ${PERL_LEVEL} < 500600
 +RUN_DEPENDS+=	${SITE_PERL}/Net/SNMP.pm:${PORTSDIR}/net-mgmt/p5-Net-SNMP3
 +.else
 +RUN_DEPENDS+=	${SITE_PERL}/Net/SNMP.pm:${PORTSDIR}/net-mgmt/p5-Net-SNMP
 +.endif
 +
  .if !defined(BATCH)
  IS_INTERACTIVE=	yes
  .endif
 @@ -110,4 +116,4 @@
  configure-package:
  	@${SETENV} ${SCRIPTS_ENV} ${SH} ${PKGINSTALL} ${PKGNAME} POST-INSTALL
  
 -.include <bsd.port.mk>
 +.include <bsd.port.post.mk>
 
 Cyrille Lefevre
 -- 
 mailto:cyrille.lefevre@laposte.net
State-Changed-From-To: open->closed 
State-Changed-By: clement 
State-Changed-When: Fri May 21 07:01:40 PDT 2004 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=66525 
>Unformatted:
