From jbq@anyware-tech.com  Mon May  3 10:08:41 2004
Return-Path: <jbq@anyware-tech.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D2FA316A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  3 May 2004 10:08:41 -0700 (PDT)
Received: from oxyd.caraldi.com (caraldi.com [195.137.249.52])
	by mx1.FreeBSD.org (Postfix) with ESMTP id BABDF43D41
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  3 May 2004 10:08:40 -0700 (PDT)
	(envelope-from jbq@anyware-tech.com)
Received: from anyware12.anyware (unknown [217.112.237.100])
	by oxyd.caraldi.com (Postfix) with ESMTP id 38CA922C3
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  3 May 2004 19:08:39 +0200 (CEST)
Received: by anyware12.anyware (Postfix, from userid 615)
	id EDCA16640; Mon,  3 May 2004 19:08:38 +0200 (CEST)
Message-Id: <20040503170838.EDCA16640@anyware12.anyware>
Date: Mon,  3 May 2004 19:08:38 +0200 (CEST)
From: Jean-Baptiste Quenot <jb.quenot@caraldi.com>
To: FreeBSD-gnats-submit@freebsd.org
Subject: comms/efax-gtk fails to build on RELENG_4
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         66212
>Category:       ports
>Synopsis:       comms/efax-gtk fails to build on RELENG_4
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    vs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Mon May 03 10:10:16 PDT 2004
>Closed-Date:    Sun Jun 27 13:44:56 GMT 2004
>Last-Modified:  Sun Jun 27 13:44:56 GMT 2004
>Originator:     jbq
>Release:        FreeBSD 5.2-CURRENT i386
>Organization:
>Environment:
System: FreeBSD anyware12.anyware 5.2-CURRENT FreeBSD 5.2-CURRENT #0: Fri Mar 26 17:43:44 CET 2004 jbq@anyware12.anyware:/usr/obj/usr/src/sys/ANYWARE12 i386
>Description:
Kris Kennaway reported that this ports fails to build on RELENG_4 with the following error:
prog_defs.h:86: syntax error before `('
>How-To-Repeat:
On FreeBSD 4.10, try to build comms/efax-gtk.  Thanks to Clement Laforet who
suggests to « fetch latest LiveFS snapshot on snapshots.jp.freebsd.org ».
>Fix:
Apply the following patch (removes files/patch-config and adds two new patches):
---------------------------------------8<-------------------------------
diff -ruN /usr/ports/comms/efax-gtk/files/patch-config ./files/patch-config
--- /usr/ports/comms/efax-gtk/files/patch-config	Sat Apr 17 00:54:19 2004
+++ ./files/patch-config	Thu Jan  1 01:00:00 1970
@@ -1,11 +0,0 @@
---- src/config.h.in.orig	Sun Feb 29 15:30:29 2004
-+++ src/config.h.in	Sun Feb 29 15:30:35 2004
-@@ -80,8 +80,5 @@
- /* Define to `unsigned' if <sys/types.h> does not define. */
- #undef size_t
- 
--/* Define to `unsigned int' if <sys/types.h> does not define. */
--#undef socklen_t
--
- /* Define to `signed int' if <sys/types.h> does not define. */
- #undef ssize_t
diff -ruN /usr/ports/comms/efax-gtk/files/patch-src::config.h.in ./files/patch-src::config.h.in
--- /usr/ports/comms/efax-gtk/files/patch-src::config.h.in	Thu Jan  1 01:00:00 1970
+++ ./files/patch-src::config.h.in	Mon May  3 11:51:13 2004
@@ -0,0 +1,12 @@
+--- src/config.h.in.orig	Thu Feb  5 21:37:17 2004
++++ src/config.h.in	Mon May  3 11:09:39 2004
+@@ -79,9 +79,3 @@
+ 
+ /* Define to `unsigned' if <sys/types.h> does not define. */
+ #undef size_t
+-
+-/* Define to `unsigned int' if <sys/types.h> does not define. */
+-#undef socklen_t
+-
+-/* Define to `signed int' if <sys/types.h> does not define. */
+-#undef ssize_t
diff -ruN /usr/ports/comms/efax-gtk/files/patch-src::prog_defs.h ./files/patch-src::prog_defs.h
--- /usr/ports/comms/efax-gtk/files/patch-src::prog_defs.h	Thu Jan  1 01:00:00 1970
+++ ./files/patch-src::prog_defs.h	Mon May  3 19:00:05 2004
@@ -0,0 +1,11 @@
+--- src/prog_defs.h.orig	Mon May  3 16:44:33 2004
++++ src/prog_defs.h	Mon May  3 16:44:46 2004
+@@ -9,6 +9,8 @@
+ #ifndef PROG_DEFS_H
+ #define PROG_DEFS_H
+ 
++#include <unistd.h>
++
+ #include "config.h"
+ 
+ // deal with any configuration issues arising from config.h
---------------------------------------8<-------------------------------
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->vs 
Responsible-Changed-By: vs 
Responsible-Changed-When: Mon May 3 12:21:14 PDT 2004 
Responsible-Changed-Why:  
I've got a similar fix somewhere in a drawer anyway. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=66212 

From: Volker Stolz <vs@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org, jb.quenot@caraldi.com
Cc: linimon@FreeBSD.org
Subject: Re: ports/66212: comms/efax-gtk fails to build on RELENG_4
Date: Tue, 04 May 2004 09:38:18 +0200

 I've had success with this slightly smaller patch (simply adds one 
 patch-file)
 but which I haven't been able to test on -CURRENT for lack for hardware:
 
 RCS file: files/patch-src-prog_defs.h
 diff -N files/patch-src-prog_defs.h
 --- /dev/null   1 Jan 1970 00:00:00 -0000
 +++ files/patch-src-prog_defs.h 29 Apr 2004 10:59:11 -0000
 @@ -0,0 +1,10 @@
 +--- src/prog_defs.h.orig       Thu Apr 29 12:58:26 2004
 ++++ src/prog_defs.h    Thu Apr 29 12:58:37 2004
 +@@ -10,6 +10,7 @@
 + #define PROG_DEFS_H
 +
 + #include "config.h"
 ++#include <sys/types.h>
 +
 + // deal with any configuration issues arising from config.h
 +
 
 Which one do you prefer? I'll test yours anyway.
 [Seconds later]
 It looks like you removed the patch for config.h.in and added
 a new file which includes the previously removed patch.
 I think you should simply patch the existing file (I'm cc:ing
 linimon to check if this is okay).
 
 Volker

From: Jean-Baptiste Quenot <jb.quenot@caraldi.com>
To: Volker Stolz <vs@FreeBSD.org>
Cc: freebsd-gnats-submit@FreeBSD.org, linimon@FreeBSD.org
Subject: Re: ports/66212: comms/efax-gtk fails to build on RELENG_4
Date: Tue, 4 May 2004 10:26:11 +0200

 * Volker Stolz:
 
 > ++#include <sys/types.h>
 
 AFAICT sys/types.h  contains Machine type  dependent parameters,
 the right way to fix the build is to include unistd.h.
 
 > It looks  like you removed the  patch for config.h.in and  added a new
 > file which includes the previously removed patch.
 
 It's true  that it is technically  possible to keep patch-config  as is,
 leaving  out  the  new  patch  patch-src::config.h.in.   It's  mainly  a
 rename.  But why to bother?  Things are thoroughly tested like the way I
 intended, both on RELENG_4 and RELENG_5_2.
 -- 
 Jean-Baptiste Quenot
 http://caraldi.com/jbq/
State-Changed-From-To: open->closed 
State-Changed-By: vs 
State-Changed-When: Thu May 6 04:09:32 PDT 2004 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=66212 

From: Chris Vine <chris@cvine.freeserve.co.uk>
To: freebsd-gnats-submit@FreeBSD.org, jb.quenot@caraldi.com
Cc:  
Subject: Re: ports/66212: comms/efax-gtk fails to build on RELENG_4
Date: Sat, 22 May 2004 23:43:16 +0100

 I do not understand the problem you are having with building efax-gtk, 
 but patching config.h.in is not a very satisfactory solution as it will 
 be overwritten the next time someone runs autoheader.
 
 Assuming the problem is not with autoheader/autoconf, is there anything 
 I can include in the main distribution to make the program compile in a 
 more system independent way (I am the author of efax-gtk)?
 
 Chris
 
State-Changed-From-To: closed->analyzed 
State-Changed-By: vs 
State-Changed-When: Sun May 23 00:46:44 PDT 2004 
State-Changed-Why:  
Reopen, maybe this can be solved in the original source? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=66212 
State-Changed-From-To: analyzed->closed 
State-Changed-By: thierry 
State-Changed-When: Sun Jun 27 13:43:09 GMT 2004 
State-Changed-Why:  

Superseded by PR ports/68417. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=66212 
>Unformatted:
