From root@ahze.net  Sun May  2 15:30:21 2004
Return-Path: <root@ahze.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6D63816A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  2 May 2004 15:30:21 -0700 (PDT)
Received: from ahze.ahze.net (adsl-068-209-163-003.sip.clt.bellsouth.net [68.209.163.3])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E34CA43D31
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  2 May 2004 15:30:20 -0700 (PDT)
	(envelope-from root@ahze.net)
Received: by ahze.ahze.net (Postfix, from userid 0)
	id 0B6FA65D7; Sun,  2 May 2004 18:31:19 -0400 (EDT)
Message-Id: <20040502223119.0B6FA65D7@ahze.ahze.net>
Date: Sun,  2 May 2004 18:31:19 -0400 (EDT)
From: michael johnson <ahze@ahze.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [MAINTAINER] multimedia/lsdvd: [Change DVD support]
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         66182
>Category:       ports
>Synopsis:       [MAINTAINER] multimedia/lsdvd: [Change DVD support]
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Sun May 02 15:40:21 PDT 2004
>Closed-Date:    Sun May 02 16:39:03 PDT 2004
>Last-Modified:  Sun May  2 16:40:16 PDT 2004
>Originator:     michael johnson
>Release:        FreeBSD 5.2-CURRENT i386
>Organization:
>Environment:
System: FreeBSD gentoo.ahze.net 5.2-CURRENT FreeBSD 5.2-CURRENT #43: Thu Apr 22 05:38:22 EDT 2004
>Description:
- Use default dvd device

I feel that using /dev/acd0[c] might be confusing
to people with out a ATA drive.

Generated with FreeBSD Port Tools 0.50
>How-To-Repeat:
>Fix:

--- lsdvd-0.10_1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/multimedia/lsdvd/Makefile,v
retrieving revision 1.1
diff -u -r1.1 Makefile
--- Makefile	31 Mar 2004 14:17:52 -0000	1.1
+++ Makefile	2 May 2004 22:23:11 -0000
@@ -7,6 +7,7 @@
 
 PORTNAME=	lsdvd
 PORTVERSION=	0.10
+PORTREVISION=	1
 CATEGORIES=	multimedia
 MASTER_SITES=	${MASTER_SITE_SOURCEFORGE}
 MASTER_SITE_SUBDIR=	acidrip
@@ -28,11 +29,7 @@
 .if defined(WITH_DVD_DEVICE)
 DEFAULT_DVD_DEVICE=${WITH_DVD_DEVICE}
 .else
-.if ${OSVERSION} < 500000
-DEFAULT_DVD_DEVICE=/dev/acd0c
-.else
-DEFAULT_DVD_DEVICE=/dev/acd0
-.endif
+DEFAULT_DVD_DEVICE=/dev/dvd
 .endif
 
 pre-everything::
@@ -43,7 +40,24 @@
 .endif
 
 post-patch:
+.if ${DEFAULT_DVD_DEVICE} != "/dev/dvd"
 	@${REINPLACE_CMD} -e 's|/dev/dvd|${DEFAULT_DVD_DEVICE}|' \
 		${WRKSRC}/lsdvd.c
+.endif
+
+post-install:
+.if !exists(${DEFAULT_DVD_DEVICE})
+	@${ECHO_MSG} "===>"
+	@${ECHO_MSG} "===> The default dvd device '${DEFAULT_DVD_DEVICE}' was not found"
+	@${ECHO_MSG} "===> For dvd support to work you need to"
+.if ${OSVERSION} < 500000
+	@${ECHO_MSG} "  ln -s /dev/yourDVDdev ${DEFAULT_DVD_DEVICE}"
+	@${ECHO_MSG} "=> The default DVD device for ATA is /dev/acd0c"
+.else
+	@${ECHO_MSG} "===> Edit and add the following line to /etc/devfs.conf"
+	@${ECHO_MSG} "  link yourDVDdev dvd"
+	@${ECHO_MSG} "=> The default DVD device for ATA is acd0"
+.endif
+.endif
 
 .include <bsd.port.post.mk>
--- lsdvd-0.10_1.patch ends here ---

>Release-Note:
>Audit-Trail:

From: Michael Johnson <ahze@ahze.net>
To: freebsd-ports-bugs@FreeBSD.org, FreeBSD-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: ports/66182: [MAINTAINER] multimedia/lsdvd: [Change DVD support]
Date: Sun, 2 May 2004 18:59:02 -0400

 --Apple-Mail-3-4844103
 Content-Transfer-Encoding: 7bit
 Content-Type: text/plain; charset=US-ASCII; format=flowed
 
 Should I use pkg-message since post-install won't echo that message if 
 someone installs a package??
 
 --Apple-Mail-3-4844103
 content-type: application/pgp-signature; x-mac-type=70674453;
 	name=PGP.sig
 content-description: This is a digitally signed message part
 content-disposition: inline; filename=PGP.sig
 content-transfer-encoding: 7bit
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.4 (Darwin)
 
 iD8DBQFAlX025H4WREStzy0RAqEzAJwMyYY4Ti69adbKhjjpnSX61ZdLIwCfd41N
 w8GI6+77/YlH3yTV1Fu7G2g=
 =3ZP+
 -----END PGP SIGNATURE-----
 
 --Apple-Mail-3-4844103--
 

From: Pav Lucistnik <pav@FreeBSD.org>
To: Michael Johnson <ahze@ahze.net>
Cc: freebsd-ports-bugs@FreeBSD.org, FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/66182: [MAINTAINER] multimedia/lsdvd: [Change DVD
	support]
Date: Mon, 03 May 2004 01:20:52 +0200

 V po, 03. 05. 2004 v 00:59, Michael Johnson p=ED=B9e:
 
 > Should I use pkg-message since post-install won't echo that message if=20
 > someone installs a package??
 
 If someone use package, there is no way he can affect
 DEFAULT_DVD_DEVICE. Also note that symlinking /dev/dvd will not work on
 FreeBSD 5.x
 
 Taking how marginal amount of people interested in DVD-Video playback
 own SCSI units, I'm against this patch at all. Think about the majority
 of users - ATA users - who will have to go and configure something.
 
 --=20
 Pav Lucistnik <pav@oook.cz>
               <pav@FreeBSD.org>
 
 A computer programmer is a device for turning requirements
 into undocumented features. It runs on cola, pizza and Dilbert cartoons.
   -- Bram Moolenaar
State-Changed-From-To: open->closed 
State-Changed-By: pav 
State-Changed-When: Sun May 2 16:37:49 PDT 2004 
State-Changed-Why:  
Closed with submitter's agreement. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=66182 

From: Michael Johnson <ahze@ahze.net>
To: freebsd-ports-bugs@FreeBSD.org, FreeBSD-gnats-submit@FreeBSD.org
Cc: Pav Lucistnik <pav@FreeBSD.org>
Subject: Re: ports/66182: [MAINTAINER] multimedia/lsdvd: [Change DVD support]
Date: Sun, 2 May 2004 19:35:35 -0400

 --Apple-Mail-4-7036464
 Content-Transfer-Encoding: 7bit
 Content-Type: text/plain; charset=US-ASCII; format=flowed
 
 
 On May 2, 2004, at 7:20 PM, Pav Lucistnik wrote:
 > Taking how marginal amount of people interested in DVD-Video playback
 > own SCSI units, I'm against this patch at all. Think about the majority
 > of users - ATA users - who will have to go and configure something.
 
 Yea you're right I doubt many people will be using DVD-video playback 
 on SCSI.
 So yea, please just close pr-66182 and pr-66184
 
 Cheers,
 Michael
 
 --Apple-Mail-4-7036464
 content-type: application/pgp-signature; x-mac-type=70674453;
 	name=PGP.sig
 content-description: This is a digitally signed message part
 content-disposition: inline; filename=PGP.sig
 content-transfer-encoding: 7bit
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.4 (Darwin)
 
 iD8DBQFAlYXH5H4WREStzy0RAnf6AKCGIe2icp2IJek/MqaazxAMsoaalQCdGOpi
 Tqwh0r23CwK1oUscMu4bV2o=
 =94ji
 -----END PGP SIGNATURE-----
 
 --Apple-Mail-4-7036464--
 
>Unformatted:
