From rv@arabica.esil.univ-mrs.fr  Wed Apr  7 09:51:48 2004
Return-Path: <rv@arabica.esil.univ-mrs.fr>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id C59E216A4CE; Wed,  7 Apr 2004 09:51:48 -0700 (PDT)
Received: from arabica.esil.univ-mrs.fr (arabica.esil.univ-mrs.fr [139.124.41.108])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 2E22743D1D; Wed,  7 Apr 2004 09:51:48 -0700 (PDT)
	(envelope-from rv@arabica.esil.univ-mrs.fr)
Received: from arabica.esil.univ-mrs.fr (localhost.esil.univ-mrs.fr [127.0.0.1])
	by arabica.esil.univ-mrs.fr (8.12.10/8.12.10) with ESMTP id i37GomDN068332;
	Wed, 7 Apr 2004 18:50:48 +0200 (CEST)
	(envelope-from rv@arabica.esil.univ-mrs.fr)
Received: (from rv@localhost)
	by arabica.esil.univ-mrs.fr (8.12.10/8.12.10/Submit) id i37GolsK068331;
	Wed, 7 Apr 2004 18:50:47 +0200 (CEST)
	(envelope-from rv)
Message-Id: <200404071650.i37GolsK068331@arabica.esil.univ-mrs.fr>
Date: Wed, 7 Apr 2004 18:50:47 +0200 (CEST)
From: Herve Quiroz <herve.quiroz@esil.univ-mrs.fr>
Reply-To:
To: FreeBSD-gnats-submit@freebsd.org
Cc: glewis@freebsd.org
Subject: bsd.java.mk: implement ${UNIQ} macro [PATCH]
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         65295
>Category:       ports
>Synopsis:       bsd.port.mk: implement ${UNIQ} macro [PATCH]
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    portmgr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Apr 07 10:00:37 PDT 2004
>Closed-Date:    Wed May 19 03:28:39 PDT 2004
>Last-Modified:  Wed May 19 03:28:39 PDT 2004
>Originator:     Herve Quiroz
>Release:        FreeBSD 5.2.1-RELEASE i386
>Organization:
>Environment:
System: FreeBSD arabica.esil.univ-mrs.fr 5.2.1-RELEASE FreeBSD 5.2.1-RELEASE #0: Fri Feb 27 11:36:17 CET 2004 root@arabica.esil.univ-mrs.fr:/usr/obj/usr/src/sys/ASSIMILATED i386

>Description:

We use uniq(1) in bsd.java.mk but we don't have it available as a macro.

Here comes a (rather simple) patch for bsd.port.mk...

I will provide a patch for bsd.java.mk as soon as this one gets commited.

>How-To-Repeat:

>Fix:


--- bsd.port.mk.original	Wed Apr  7 18:31:53 2004
+++ bsd.port.mk	Wed Apr  7 18:32:16 2004
@@ -962,6 +962,7 @@
 TR?=		/usr/bin/tr
 TRUE?=		true				# Shell builtin
 UNAME?=		/usr/bin/uname
+UNIQ?=		/usr/bin/uniq
 .if exists(/usr/bin/unzip)
 UNZIP_CMD?=	/usr/bin/unzip
 .else
>Release-Note:
>Audit-Trail:

From: Herve Quiroz <herve.quiroz@esil.univ-mrs.fr>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: ports/65295: bsd.java.mk: implement ${UNIQ} macro [PATCH]
Date: Wed, 7 Apr 2004 21:17:15 +0200

 Hum. I can't believe I made such a mistake. The PR synopsis should be:
 
   "bsd.port.mk: implement ${UNIQ} macro [PATCH]"
 
 [ bsd.JAVA.mk -> bsd.PORT.mk ]
 
 Hopefully, for such a trivial PR, this won't have any bad effect...
 
 Sorry again.
 
 Herve
Responsible-Changed-From-To: freebsd-ports-bugs->portmgr 
Responsible-Changed-By: clement 
Responsible-Changed-When: Wed Apr 7 12:23:24 PDT 2004 
Responsible-Changed-Why:  
And the winner is... portmgr! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=65295 

From: Kris Kennaway <kris@obsecurity.org>
To: freebsd-gnats-submit@FreeBSD.org, herve.quiroz@esil.univ-mrs.fr
Cc:  
Subject: Re: ports/65295: bsd.port.mk: implement ${UNIQ} macro [PATCH]
Date: Tue, 18 May 2004 21:00:27 -0700

 I suspect that all the variable assignments in bsd.port.mk have a 
 non-trivial impact on large tasks like 'make index', which multiply the 
 cost of setting the variable by more than 10000.  I think we should 
 avoid adding them except in cases where there's a clear need, e.g. 
 credible desire for a user to replace the command, or when the path to 
 the binary changes.
 
 Kris

From: Herve Quiroz <herve.quiroz@esil.univ-mrs.fr>
To: Kris Kennaway <kris@obsecurity.org>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/65295: bsd.port.mk: implement ${UNIQ} macro [PATCH]
Date: Wed, 19 May 2004 11:47:19 +0200

 Sorry I forgot this PR actually.
 
 We don't need uniq(1) anymore in bsd.java.mk so you may close this PR.
 
 Herve
 
 PS: And I agree with you regarding the cost of variable assignments.
 BTW, a quick grep returned to me that no other file in Mk/ uses uniq.
 
 On Tue, May 18, 2004 at 09:00:27PM -0700, Kris Kennaway wrote:
 > I suspect that all the variable assignments in bsd.port.mk have a 
 > non-trivial impact on large tasks like 'make index', which multiply the 
 > cost of setting the variable by more than 10000.  I think we should 
 > avoid adding them except in cases where there's a clear need, e.g. 
 > credible desire for a user to replace the command, or when the path to 
 > the binary changes.
 > 
 > Kris
State-Changed-From-To: open->closed 
State-Changed-By: kris 
State-Changed-When: Wed May 19 03:28:04 PDT 2004 
State-Changed-Why:  
Submitter agrees that this patch is not needed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=65295 
>Unformatted:
