From hartzell@bloop.alerce.com  Wed Mar 24 09:08:50 2004
Return-Path: <hartzell@bloop.alerce.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3874516A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 24 Mar 2004 09:08:50 -0800 (PST)
Received: from bloop.alerce.com (w092.z064001164.sjc-ca.dsl.cnc.net [64.1.164.92])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 03C4843D45
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 24 Mar 2004 09:08:50 -0800 (PST)
	(envelope-from hartzell@bloop.alerce.com)
Received: by bloop.alerce.com (Postfix, from userid 1001)
	id 200F760E7; Wed, 24 Mar 2004 17:22:46 -0800 (PST)
Message-Id: <20040325012246.200F760E7@bloop.alerce.com>
Date: Wed, 24 Mar 2004 17:22:46 -0800 (PST)
From: George Hartzell <hartzell@kestrel.alerce.com>
Reply-To: George Hartzell <hartzell@kestrel.alerce.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: maildrop port does not support Makefile.local
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         64660
>Category:       ports
>Synopsis:       maildrop port does not support Makefile.local
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    sergei
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 24 09:10:13 PST 2004
>Closed-Date:    Sun Apr 11 14:41:35 PDT 2004
>Last-Modified:  Sun Apr 11 14:41:35 PDT 2004
>Originator:     George Hartzell
>Release:        FreeBSD 5.2.1-RELEASE i386
>Organization:
>Environment:
System: FreeBSD bloop.alerce.com 5.2.1-RELEASE FreeBSD 5.2.1-RELEASE #0: Mon Mar 8 04:06:53 PST 2004 root@bloop.alerce.com:/usr/obj/usr/src/sys/BLOOP i386

>Description:
 I'm trying to build maildrop w/ mysql support, and prefer to keep
 my customizations in a Makefile.local file.  The Maildrop ports
 Makefile.local doesn't support this properly.

>How-To-Repeat:
 Create a Makefile.local that contains the line:
 WITH_MYSQL=yes
 and try to build.  The line is ignored.
>Fix:

This patch seems to get it.

(bloop)[5:22pm]maildrop>>rcsdiff -c2 Makefile
===================================================================
RCS file: Makefile,v
retrieving revision 1.1
diff -c2 -r1.1 Makefile
*** Makefile    2004/03/25 01:14:17     1.1
--- Makefile    2004/03/25 01:15:14
***************
*** 42,45 ****
--- 42,47 ----
  LDFLAGS+=     -L${LOCALBASE}/lib
  
+ .include <bsd.port.pre.mk>
+ 
  .if defined(WITH_GDBM)
  LIB_DEPENDS+=         gdbm.3:${PORTSDIR}/databases/gdb
***************
*** 113,115 ****
  .endif
  
! .include <bsd.port.mk>
--- 115,117 ----
  .endif
  
! .include <bsd.port.post.mk>


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->sergei 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Wed Mar 24 17:42:53 PST 2004 
Responsible-Changed-Why:  
Over to maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=64660 
State-Changed-From-To: open->closed 
State-Changed-By: sergei 
State-Changed-When: Sun Apr 11 14:38:58 PDT 2004 
State-Changed-Why:  
Committed, thanks! 

Note: please consider using either sysutils/penv or sysutils/portupgrade 
port for a better (IMHO) ways to store per-port configuration knobs. 
Makefile.local is not supported by most of the ports, and I do not think 
it is currently feasible to change every port in the collection  
to support including Makefile.local. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=64660 
>Unformatted:
