From oleg@pobox.com  Tue Mar 16 22:10:15 2004
Return-Path: <oleg@pobox.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 74DC316A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 16 Mar 2004 22:10:15 -0800 (PST)
Received: from mail.metnet.navy.mil (jade.metnet.navy.mil [192.16.167.28])
	by mx1.FreeBSD.org (Postfix) with SMTP id 4A22D43D3F
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 16 Mar 2004 22:10:15 -0800 (PST)
	(envelope-from oleg@pobox.com)
Received: (qmail 5477 invoked from network); 17 Mar 2004 06:10:12 -0000
Received: from smackdown1.fnmoc.navy.mil (HELO Adric.metnet.navy.mil) (152.80.48.103)
  by mail.metnet.navy.mil with SMTP; 17 Mar 2004 06:10:12 -0000
Received: by Adric.metnet.navy.mil (Postfix, from userid 760)
	id B57C0AA2F; Tue, 16 Mar 2004 22:08:49 -0800 (PST)
Message-Id: <20040317060849.B57C0AA2F@Adric.metnet.navy.mil>
Date: Tue, 16 Mar 2004 22:08:49 -0800 (PST)
From: oleg@pobox.com
Reply-To: oleg@pobox.com
To: FreeBSD-gnats-submit@freebsd.org
Subject: Maintainer port update: devel/cppadvio
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         64362
>Category:       ports
>Synopsis:       Maintainer port update: devel/cppadvio, compiling on Alpha
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Tue Mar 16 22:20:08 PST 2004
>Closed-Date:    Wed Mar 17 01:37:04 PST 2004
>Last-Modified:  Wed Mar 17 01:37:04 PST 2004
>Originator:     oleg@pobox.com
>Release:        FreeBSD 4.9-RELEASE-p1 i386
>Organization:
>Environment:
System: FreeBSD Adric 4.9-RELEASE-p1 FreeBSD 4.9-RELEASE-p1 #1: Tue Dec 30 16:04:05 PST 2003 oleg@Adric:/usr/obj/usr/src/sys/Adric i386

>Description:
CPPADVIO fails to build under Alpha:
	http://bento.freebsd.org/errorlogs/alpha-4-latest/cppadvio-2.6_1.log
Correspondingly, devel/cppadvio/Makefile was patched from version 1.7
to version 1.8 to indicate that the port "Does not compile on alpha 4.x"

Alas, I have no access to Alpha. However, I understood
the problem from the error log and am quite sure the submitted patch will
fix it. I tested that the patch doesn't break the i386 4.x port.

Again, I believe that the patch fixes the compilation problem on
Alpha, but I have no way to prove it. I would greatly appreciate it
indeed if a kind committer could try the patch on Alpha. If it works,
could you also revert devel/cppadvio/Makefile from version 1.8 to
version 1.7 (so the port would be automatically built on Alpha). The patch
does seem to work on i386, and it makes the code more portable.

Thank you!

>How-To-Repeat:
>Fix:

New file /usr/ports/devel/cppadvio/files/patch-TCPstream.cc
--- patch begins here ---
--- TCPstream-orig.cc	Tue Nov 14 19:06:44 2000
+++ TCPstream.cc	Tue Mar 16 21:34:58 2004
@@ -44,7 +44,7 @@
 {
                                 // Convertion between the host and the network
                                 // byte orders
-#if !defined(htons) && !defined(linux)
+#if !defined(htons) && !defined(linux) && !defined(_MACHINE_ENDIAN_H_)
 unsigned short htons(unsigned int data);        // For a short data item
 unsigned short ntohs(unsigned int data);        // For a short data item
 unsigned long  htonl(unsigned long data);       // For a long data item
--- patch ends here ---
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: krion 
State-Changed-When: Wed Mar 17 01:36:58 PST 2004 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=64362 
>Unformatted:
