From ap@sprouts.org  Mon Apr 27 04:49:13 1998
Received: from aw.ivm.net (root@mail.ivm.net [195.78.161.2])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id EAA21902
          for <FreeBSD-gnats-submit@freebsd.org>; Mon, 27 Apr 1998 04:49:11 -0700 (PDT)
          (envelope-from ap@sprouts.org)
Received: from sprouts.org (sprouts.org [195.78.188.129])
	by aw.ivm.net (8.8.8/8.8.8-ivm) with ESMTP id NAA29640
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 27 Apr 1998 13:49:11 +0200
Received: (from root@localhost)
          by sprouts.org (8.8.8/8.8.8) id NAA26050;
          Mon, 27 Apr 1998 13:51:59 +0200 (CEST)
          (envelope-from ap)
Message-Id: <199804271151.NAA26050@sprouts.org>
Date: Mon, 27 Apr 1998 13:51:59 +0200 (CEST)
From: root@sprouts.org
Reply-To: root@sprouts.org
To: FreeBSD-gnats-submit@freebsd.org
Subject: <Synopsis of the problem (one line)>trafshow 2.0 (port) can't be compiled
X-Send-Pr-Version: 3.2

>Number:         6430
>Category:       ports
>Synopsis:       trafshow 2.0 (port) can't be compiled
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    jseger
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Apr 27 04:50:01 PDT 1998
>Closed-Date:    Wed May 20 17:27:38 PDT 1998
>Last-Modified:  Wed May 20 17:28:04 PDT 1998
>Originator:     Charlie &
>Release:        FreeBSD 3.0-CURRENT i386
>Organization:
IVM GmbH
>Environment:

	 FreeBSD
sprouts.org 3.0-CURRENT FreeBSD 3.0-CURRENT #3: Mon Feb 16 19:30:39 CET 1998
root@sprouts.org:/usr/src/sys/compile/SPROUTS i386

latest include files (Mon Apr 27 13:49:02 CEST 1998) have been installed


>Description:

	
see how to repeat

>How-To-Repeat:

	
# cd /usr/ports/net/trafshow
# make
>Fix:
	
	
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: gnats-admin->ports 
Responsible-Changed-By: phk 
Responsible-Changed-When: Wed Apr 29 07:44:32 PDT 1998 
Responsible-Changed-Why:  
->ports 

From: Jacques Vidrine <n@nectar.com>
To: freebsd-gnats-submit@freebsd.org, root@sprouts.org
Cc:  Subject: Re: ports/6430: trafshow 2.0 (port) can't be compiled
Date: Thu, 30 Apr 1998 15:42:42 -0500

 lib/interfaces.c includes <net/if_slvar.h>, though it doesn't seem
 to need the only structure defined there (struct sl_softc).
 
 I don't think that trafshow should include this file -- at least not
 on BSD4.4lite platforms.
 
 Fix, to be applied after all other patches included in the port:
 
 --- lib/interfaces.c	Wed Apr 29 13:56:21 1998
 +++ lib/interfaces.c	Wed Apr 29 13:56:30 1998
 @@ -23,7 +23,6 @@
  #include <net/if.h>
  #include <net/slip.h>
  #include <net/if_var.h>
 -#include <net/if_slvar.h>
  #ifdef __FreeBSD__
  #include <net/if_ppp.h>
  #else
 
 Jacques Vidrine <n@nectar.com>

From: Tim Vanderhoek <ac199@hwcn.org>
To: Jacques Vidrine <n@nectar.com>
Cc: bug-followup@FreeBSd.ORG
Subject: Re: ports/6430: trafshow 2.0 (port) can't be compiled
Date: Thu, 30 Apr 1998 21:22:10 -0400 (EDT)

 On Thu, 30 Apr 1998, Jacques Vidrine wrote:
 
 >  Fix, to be applied after all other patches included in the port:
 
 No, there is already one patch to lib/interfaces.c.  Any further
 patches should be combined with that one (style guide says "two
 patches no patch one file").
 
 
 --
 Only two other people have a .sig like this one.
 

From: Jacques Vidrine <n@nectar.com>
To: ac199@hwcn.org
Cc: bug-followup@FreeBSd.ORG
Subject: Re: ports/6430: trafshow 2.0 (port) can't be compiled 
Date: Thu, 30 Apr 1998 21:14:39 -0500

 -----BEGIN PGP SIGNED MESSAGE-----
 
 
 
 Hmm, OK.  I'm off to find the style guide for next time.
 
 Meanwhile, I see a fix has been committed for the problem, though I think
 the wrong fix.
 
 lib/interfaces.c wouldn't compile because it included <net/if_slvar.h>,
 which references struct slcompress.  The distribution shouldn't have
 included <net/if_slvar.h>, at least not on BSD4.4lite. That header
 is only needed for struct sl_softc, which trafshow does not reference.
 Anyway, the name seems to indicate that it should only be included in
 kernel sources.
 
 The fix that was committed just imported all the stuff struct slcompress
 needed (<net/if_var.h>, <netinet/mbuf.h>, <net/slcompress.h>), which
 doesn't seem like the right thing.
 
 Thanks,
 
 Jacques Vidrine <n@nectar.com> 
 
 On 30 April 1998 at 21:22, Tim Vanderhoek <ac199@hwcn.org> wrote:
 > On Thu, 30 Apr 1998, Jacques Vidrine wrote:
 > 
 > >  Fix, to be applied after all other patches included in the port:
 > 
 > No, there is already one patch to lib/interfaces.c.  Any further
 > patches should be combined with that one (style guide says "two
 > patches no patch one file").
 > 
 > 
 > --
 > Only two other people have a .sig like this one.
 > 
 
 
 
 -----BEGIN PGP SIGNATURE-----
 Version: 2.6.2
 
 iQCVAwUBNUkwDjeRhT8JRySpAQFdjAQAiHQCJvHIkgzd+FvwvBq9ljqRcB1fQbSX
 DYi++9weYebT9KdibFoM42auBnAjyURsanoH0Cicfc9yCmGn3WVp/KjPylT8okee
 ytL5c5Qvms8Z/PsfAPyOUwZohRgoL/rqspfkeqMtdVnEJqwPIg1rUJAoyFSuDett
 DyosdRZGIJw=
 =3fnG
 -----END PGP SIGNATURE-----
 
Responsible-Changed-From-To: ports->jseger 
Responsible-Changed-By: steve 
Responsible-Changed-When: Sun May 3 13:29:15 PDT 1998 
Responsible-Changed-Why:  
Assign to port's maintainer. 
State-Changed-From-To: open->closed 
State-Changed-By: jseger 
State-Changed-When: Wed May 20 17:27:38 PDT 1998 
State-Changed-Why:  
I fixed this a while ago. 
>Unformatted:
 >> Checksum OK for trafshow-2.0.tgz.
 ===>  Building for trafshow-2.0
 cc -O2 -I../include -DETHER_SERVICE -c interfaces.c
 In file included from interfaces.c:26:
 /usr/include/net/if_slvar.h:69: field `sc_comp' has incomplete type
 *** Error code 1
 
 Stop.
 [...]
 #
 
