From matthias.andree@gmx.de  Wed Mar 10 03:39:38 2004
Return-Path: <matthias.andree@gmx.de>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B220616A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 10 Mar 2004 03:39:38 -0800 (PST)
Received: from mail.dt.e-technik.uni-dortmund.de (krusty.dt.E-Technik.Uni-Dortmund.DE [129.217.163.1])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E499E43D4C
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 10 Mar 2004 03:39:37 -0800 (PST)
	(envelope-from matthias.andree@gmx.de)
Received: from m2a2.dyndns.org (krusty.dt.e-technik.uni-dortmund.de [129.217.163.1])
	by mail.dt.e-technik.uni-dortmund.de (Postfix) with ESMTP id E503623A50
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 10 Mar 2004 12:39:36 +0100 (CET)
Received: from libertas.emma.line.org (libertas.emma.line.org [192.168.0.2])
	by merlin.emma.line.org (Postfix) with ESMTP id 86C45659;
	Wed, 10 Mar 2004 12:39:35 +0100 (CET)
Received: from emma by libertas.emma.line.org with local (Exim 4.30; FreeBSD)
	id 1B123j-0000br-9u; Wed, 10 Mar 2004 12:39:35 +0100
Message-Id: <E1B123j-0000br-9u@libertas.emma.line.org>
Date: Wed, 10 Mar 2004 12:39:35 +0100
From: Matthias Andree <matthias.andree@gmx.de>
Sender: Matthias Andree <matthias.andree@gmx.de>
To: FreeBSD-gnats-submit@freebsd.org
Cc: fuyuki@nigredo.org, Kris Kennaway <kris@obsecurity.org>
Subject: [PATCH] databases/qdbm: always run self-test, minor other fix
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         64037
>Category:       ports
>Synopsis:       [PATCH] databases/qdbm: always run self-test, minor other fix
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 10 03:40:21 PST 2004
>Closed-Date:    Thu Mar 11 16:02:57 PST 2004
>Last-Modified:  Thu Mar 11 16:02:57 PST 2004
>Originator:     Matthias Andree
>Release:        FreeBSD 4.9-STABLE i386
>Organization:
>Environment:
System: FreeBSD libertas.emma.line.org 4.9-STABLE FreeBSD 4.9-STABLE #89: Mon Mar  8 00:29:59 CET
>Description:
- Moved the self-test from test to post-build so it is always run.
  Rationale: A self-check problem was reported against bogofilter-qdbm on
  alpha4 by Kris Kennaway, and nobody knows whether it's QDBM's fault or
  bogofilter's. QDBM-1.8.2's "make check" fails on SPARC64 Solaris8 with a
  segmentation fault in the garbage collector.
- Switch from ; to && in order to not hide cd errors or run the make command in
  the wrong directory.

Port maintainer (fuyuki@nigredo.org) is cc'd.

Generated with FreeBSD Port Tools 0.50
>How-To-Repeat:
>Fix:

--- qdbm-1.8.2.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/databases/qdbm/Makefile /usr/home/emma/ports/databases/Makefile
--- /usr/ports/databases/qdbm/Makefile	Mon Mar  8 00:24:10 2004
+++ /usr/home/emma/ports/databases/Makefile	Wed Mar 10 12:28:47 2004
@@ -29,12 +29,10 @@
 		odeum.3 odopen.3 villa.3 vlopen.3 villa.3 vista.3
 
 post-build:
-	cd ${WRKSRC}/lab; ${MAKE} CC="${CC}" CFLAGS="${CFLAGS}" fmtcnv031127
+	cd ${WRKSRC}/lab && ${MAKE} CC="${CC}" CFLAGS="${CFLAGS}" fmtcnv031127
+	cd ${WRKSRC} && ${MAKE} check
 
 post-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/lab/fmtcnv031127 ${PREFIX}/bin
-
-test:
-	cd ${WRKSRC}; ${MAKE} check
 
 .include <bsd.port.mk>
--- qdbm-1.8.2.patch ends here ---

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback  
State-Changed-By: krion 
State-Changed-When: Wed Mar 10 08:05:06 PST 2004 
State-Changed-Why:  
Asked for maintainer's feedback. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=64037 

From: Kirill Ponomarew <krion@FreeBSD.org>
To: fuyuki@nigredo.org
Cc: FreeBSD-gnats-submit@FreeBSD.org,
	Kris Kennaway <kris@obsecurity.org>
Subject: Re: ports/64037: [PATCH] databases/qdbm: always run self-test, minor other fix
Date: Wed, 10 Mar 2004 17:05:03 +0100

 --A6Z7MKnLVMfR85kG
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 Hi,
 
 On Wed, Mar 10, 2004 at 12:39:35PM +0100, Matthias Andree wrote:
 >=20
 > >Number:         64037
 > >Category:       ports
 > >Synopsis:       [PATCH] databases/qdbm: always run self-test, minor othe=
 r fix
 > >Confidential:   no
 > >Severity:       non-critical
 > >Priority:       low
 > >Responsible:    freebsd-ports-bugs
 > >State:          open
 
 Could you please review this PR and approve/reject the changes?
 
 http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/64037
 
 -Kirill
 
 --A6Z7MKnLVMfR85kG
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.4 (FreeBSD)
 
 iD8DBQFATzyvQC1G6a60JuURAk9LAKDk/eWzZOiWXUFsVcjqUOTnBem4yQCgoIM9
 yNkOY3D5qb8fOb/jVw30XL0=
 =SdFe
 -----END PGP SIGNATURE-----
 
 --A6Z7MKnLVMfR85kG--

From: Kimura Fuyuki <fuyuki@nigredo.org>
To: krion@FreeBSD.org, fuyuki@nigredo.org,
	FreeBSD-gnats-submit@FreeBSD.org, kris@obsecurity.org
Cc:  
Subject: Re: ports/64037: [PATCH] databases/qdbm: always run self-test, minor other fix
Date: Thu, 11 Mar 2004 05:59:24 +0900

 At Wed, 10 Mar 2004 17:05:03 +0100,
 Kirill Ponomarew <krion@FreeBSD.org> wrote:
 > 
 > Could you please review this PR and approve/reject the changes?
 > 
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/64037
 
 Ok, I temporally move the contents of the test target to the
 post-build target, but don't replace ';' with '&&' since:
 
 http://lists.liquidneon.com/pipermail/kde-freebsd/2002-March/000940.html
 
 I also merged it with the update to 1.8.3.
 
 cvs diff: Diffing .
 Index: Makefile
 ===================================================================
 RCS file: /cvs/FreeBSD/ports/databases/qdbm/Makefile,v
 retrieving revision 1.16
 diff -u -r1.16 Makefile
 --- Makefile	3 Mar 2004 20:35:05 -0000	1.16
 +++ Makefile	10 Mar 2004 20:55:38 -0000
 @@ -6,10 +6,10 @@
  #
  
  PORTNAME=	qdbm
 -PORTVERSION=	1.8.2
 +PORTVERSION=	1.8.3
  CATEGORIES=	databases
  MASTER_SITES=	http://qdbm.sourceforge.net/ \
 -		${MASTER_SITE_SOURCEFORGE}
 +#		${MASTER_SITE_SOURCEFORGE}
  MASTER_SITE_SUBDIR=	${PORTNAME}
  
  MAINTAINER=	fuyuki@nigredo.org
 @@ -28,13 +28,24 @@
  MLINKS=		curia.3 cropen.3 depot.3 dpopen.3 \
  		odeum.3 odopen.3 villa.3 vlopen.3 villa.3 vista.3
  
 +OPTIONS=	PTHREAD "Enable pthread support !! USE IT WITH CARE !!" off
 +
 +.include <bsd.port.pre.mk>
 +
 +.if defined(WITH_PTHREAD)
 +USE_REINPLACE=	yes
 +CONFIGURE_ARGS+=	--enable-pthread
 +CFLAGS+=	${PTHREAD_CFLAGS}
 +
 +post-patch:
 +	${REINPLACE_CMD} -e 's|-lpthread|${PTHREAD_LIBS}|g' ${WRKSRC}/configure
 +.endif
 +
  post-build:
  	cd ${WRKSRC}/lab; ${MAKE} CC="${CC}" CFLAGS="${CFLAGS}" fmtcnv031127
 +	cd ${WRKSRC}; ${MAKE} check
  
  post-install:
  	${INSTALL_PROGRAM} ${WRKSRC}/lab/fmtcnv031127 ${PREFIX}/bin
  
 -test:
 -	cd ${WRKSRC}; ${MAKE} check
 -
 -.include <bsd.port.mk>
 +.include <bsd.port.post.mk>
 Index: distinfo
 ===================================================================
 RCS file: /cvs/FreeBSD/ports/databases/qdbm/distinfo,v
 retrieving revision 1.16
 diff -u -r1.16 distinfo
 --- distinfo	3 Mar 2004 20:35:05 -0000	1.16
 +++ distinfo	9 Mar 2004 01:41:29 -0000
 @@ -1,2 +1,2 @@
 -MD5 (qdbm-1.8.2.tar.gz) = c47c700b3c15ce4e6efdb1c13e9e8d93
 -SIZE (qdbm-1.8.2.tar.gz) = 719983
 +MD5 (qdbm-1.8.3.tar.gz) = cce6509285807b1f4bcc2d2029f8e43a
 +SIZE (qdbm-1.8.3.tar.gz) = 721962
State-Changed-From-To: feedback->closed 
State-Changed-By: pav 
State-Changed-When: Thu Mar 11 16:02:45 PST 2004 
State-Changed-Why:  
This was incorporated to ports/64123 by maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=64037 
>Unformatted:
