From danny@workstation.home.ricin.net  Mon Feb 23 11:02:21 2004
Return-Path: <danny@workstation.home.ricin.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1130316A513
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 23 Feb 2004 11:02:21 -0800 (PST)
Received: from workstation.home.ricin.net (cp464173-a.dbsch1.nb.home.nl [212.204.145.167])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 20A5843D1D
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 23 Feb 2004 11:02:20 -0800 (PST)
	(envelope-from danny@workstation.home.ricin.net)
Received: from workstation.home.ricin.net (localhost.home.ricin.net [127.0.0.1])
	by workstation.home.ricin.net (8.12.10/8.12.10) with ESMTP id i1NJ2HZ5033728
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 23 Feb 2004 20:02:18 +0100 (CET)
	(envelope-from danny@workstation.home.ricin.net)
Received: (from danny@localhost)
	by workstation.home.ricin.net (8.12.10/8.12.10/Submit) id i1NJ2Hu0033727;
	Mon, 23 Feb 2004 20:02:17 +0100 (CET)
	(envelope-from danny)
Message-Id: <200402231902.i1NJ2Hu0033727@workstation.home.ricin.net>
Date: Mon, 23 Feb 2004 20:02:17 +0100 (CET)
From: danny@ricin.com
Reply-To: danny@ricin.com
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [NEW PORT] x11-toolkits/gtk-qt-engine
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         63282
>Category:       ports
>Synopsis:       [NEW PORT] x11-toolkits/gtk-qt-engine
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Feb 23 11:10:15 PST 2004
>Closed-Date:    Sun May 30 15:18:23 PDT 2004
>Last-Modified:  Tue Jun  1 10:10:28 PDT 2004
>Originator:     
>Release:        
>Organization:
>Environment:
>Description:
 # This is a shell archive.  Save it in a file, remove anything before
 # this line, and then unpack it by entering "sh file".  Note, it may
 # create directories; files and directories will be owned by you and
 # have default permissions.
 #
 # This archive contains:
 #
 #	gtk-qt-engine
 #	gtk-qt-engine/files
 #	gtk-qt-engine/files/patch-configure
 #	gtk-qt-engine/files/patch-makefile.in
 #	gtk-qt-engine/files/patch-makefile.am
 #	gtk-qt-engine/Makefile
 #	gtk-qt-engine/distinfo
 #	gtk-qt-engine/pkg-descr
 #	gtk-qt-engine/pkg-plist
 #
 echo c - gtk-qt-engine
 mkdir -p gtk-qt-engine > /dev/null 2>&1
 echo c - gtk-qt-engine/files
 mkdir -p gtk-qt-engine/files > /dev/null 2>&1
 echo x - gtk-qt-engine/files/patch-configure
 sed 's/^X//' >gtk-qt-engine/files/patch-configure << 'END-of-gtk-qt-engine/files/patch-configure'
 X--- configure.orig	Mon Feb 23 16:15:14 2004
 X+++ configure	Mon Feb 23 16:25:13 2004
 X@@ -5737,8 +5737,10 @@
 X # Always use our own libtool.
 X LIBTOOL='$(SHELL) $(top_builddir)/libtool'
 X 
 X-# Prevent multiple expansion
 X+# We have pkg-config in /usr/local, while gtk stuff is /usr/X11R6
 X+PKG_CONFIG=/usr/local/bin/pkg-config
 X 
 X+# Prevent multiple expansion
 X 
 X 
 X 
 X@@ -5790,7 +5792,11 @@
 X      echo "*** Or see http://www.freedesktop.org/software/pkgconfig to get pkg-config."
 X   else
 X      PKG_CONFIG_MIN_VERSION=0.9.0
 X-     if $PKG_CONFIG --atleast-pkgconfig-version $PKG_CONFIG_MIN_VERSION; then
 X+     # This seems to just decide that 0.9.0 > 0.15.0 which is not helpful
 X+     #if $PKG_CONFIG --atleast-pkgconfig-version $PKG_CONFIG_MIN_VERSION; then
 X+     VER=`$PKG_CONFIG --version | sed s/"\."//g`
 X+     MINVER=090
 X+     if [ $VER -ge $MINVER ]; then
 X         echo $ac_n "checking for gtk+-2.0 >= 2.0.0""... $ac_c" 1>&6
 X echo "configure:5796: checking for gtk+-2.0 >= 2.0.0" >&5
 X 
 END-of-gtk-qt-engine/files/patch-configure
 echo x - gtk-qt-engine/files/patch-makefile.in
 sed 's/^X//' >gtk-qt-engine/files/patch-makefile.in << 'END-of-gtk-qt-engine/files/patch-makefile.in'
 X--- Makefile.in.orig	Mon Feb 23 16:14:53 2004
 X+++ Makefile.in	Mon Feb 23 16:35:40 2004
 X@@ -83,7 +83,7 @@
 X 
 X SUBDIRS = Theme
 X 
 X-QTDIR = /usr/lib/qt3
 X+QTDIR = $(PREFIX)
 X 
 X INCLUDES = $(QTENGINE_CFLAGS) -I$(QTDIR)/include/
 X 
 END-of-gtk-qt-engine/files/patch-makefile.in
 echo x - gtk-qt-engine/files/patch-makefile.am
 sed 's/^X//' >gtk-qt-engine/files/patch-makefile.am << 'END-of-gtk-qt-engine/files/patch-makefile.am'
 X--- Makefile.am.orig	Mon Feb 23 16:14:47 2004
 X+++ Makefile.am	Mon Feb 23 16:31:45 2004
 X@@ -1,6 +1,6 @@
 X SUBDIRS = Theme
 X 
 X-QTDIR = /usr/lib/qt3
 X+QTDIR = $(PREFIX)
 X 
 X INCLUDES = $(QTENGINE_CFLAGS) -I$(QTDIR)/include/
 X 
 X@@ -23,5 +23,5 @@
 X 
 X EXTRA_DIST = autogen.sh gtk-qt-engine-2.pc.in
 X 
 X-pkgconfigdir = $(libdir)/pkgconfig
 X+pkgconfigdir = /usr/local/libdata/pkgconfig
 X pkgconfig_DATA = gtk-qt-engine-2.pc
 X
 END-of-gtk-qt-engine/files/patch-makefile.am
 echo x - gtk-qt-engine/Makefile
 sed 's/^X//' >gtk-qt-engine/Makefile << 'END-of-gtk-qt-engine/Makefile'
 X# New ports collection makefile for:    gtk-qt-engine
 X# Date created:                         23 February 2004
 X# Whom:                                 Danny Pansters <danny@ricin.com>
 X#
 X# $FreeBSD$
 X#
 X
 XPORTNAME=	gtk-qt-engine
 XPORTVERSION=	0.3
 XCATEGORIES=	x11-toolkits
 XMASTER_SITES=	http://www.freedesktop.org/Software/gtk-qt/
 X
 XMAINTAINER=	ports@freebsd.org
 XCOMMENT=	The GTK-QT Theme Engine allows GTK2 to use QT widget styles
 X
 XUSE_BZIP2=	yes
 XUSE_X_PREFIX=	yes
 XUSE_GMAKE=	yes
 XUSE_LIBTOOL=	yes
 XUSE_REINPLACE=	yes
 XWANT_GNOME=	no
 XUSE_GNOME=	gtk20
 XUSE_QT_VER=	3
 X
 Xpre-build:
 X	@${REINPLACE_CMD} -e 's|/bin/sed|${SED}|g' ${WRKSRC}/libtool
 X
 Xpost-install:
 X	@${ECHO_MSG} "====================================================="
 X	@${ECHO_MSG} "NOTE: Add the following line to your ~/.gtkrc-2.0 :"
 X	@${ECHO_MSG}
 X	@${ECHO_MSG} "include \"/usr/share/themes/Qt/gtk-2.0/gtkrc\""
 X	@${ECHO_MSG}
 X	@${ECHO_MSG} "More info: http://www.freedesktop.org/Software/gtk-qt"
 X	@${ECHO_MSG} "====================================================="
 X
 X.include <bsd.port.mk>
 END-of-gtk-qt-engine/Makefile
 echo x - gtk-qt-engine/distinfo
 sed 's/^X//' >gtk-qt-engine/distinfo << 'END-of-gtk-qt-engine/distinfo'
 XMD5 (gtk-qt-engine-0.3.tar.bz2) = 0685783bec472b682366f213134a6b3c
 END-of-gtk-qt-engine/distinfo
 echo x - gtk-qt-engine/pkg-descr
 sed 's/^X//' >gtk-qt-engine/pkg-descr << 'END-of-gtk-qt-engine/pkg-descr'
 XThe GTK-QT Theme Engine allows GTK2 to use QT widget styles.
 X
 XWWW: http://www.freedesktop.org/Software/gtk-qt
 X
 XDavid Sansome <me@davidsansome.com>
 END-of-gtk-qt-engine/pkg-descr
 echo x - gtk-qt-engine/pkg-plist
 sed 's/^X//' >gtk-qt-engine/pkg-plist << 'END-of-gtk-qt-engine/pkg-plist'
 Xlib/gtk-2.0/2.2.0/engines/libqtengine.so
 Xlib/gtk-2.0/2.2.0/engines/libqtengine.la
 Xlib/pkgconfig/gtk-qt-engine-2.pc
 Xshare/themes/Qt/ICON.png
 Xshare/themes/Qt/README.html
 Xshare/themes/Qt/gtk-2.0/gtkrc
 X@dirrm share/themes/Qt/gtk-2.0
 X@dirrm share/themes/Qt
 END-of-gtk-qt-engine/pkg-plist
 exit
 
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: gnats-admin->freebsd-ports-bugs 
Responsible-Changed-By: ceri 
Responsible-Changed-When: Tue Feb 24 13:28:28 PST 2004 
Responsible-Changed-Why:  
Reassign misfiled PR. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=63282 

From: Danny Pansters <danny@ricin.com>
To: freebsd-gnats-submit@FreeBSD.org, danny@ricin.com
Cc:  
Subject: Re: ports/63282: [NEW PORT] x11-toolkits/gtk-qt-engine
Date: Thu, 26 Feb 2004 01:01:57 +0100

 As sent to author me AT davidsansome.com:
 ----------------------------------------------------------
 
 Against the 0.3 source download. I don't know if you have a FreeBSD box at 
 your hands but the PR is at 
 
 http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/63282
 
 The patches can be derived from there or once/if the port gets comitted or 
 from me if you like.
 
 It seems to work OK on FreeBSD-5.2-RELEASE and 5.2-CURRENT, I don't have 
 many GTK apps installed as I use maily KDE; tried it on gimp-1.3 and that 
 worked and tried on a wx-python/wx-gtk2 app of my own (the "OK" button looks 
 weird or has no image/text at all, most widgets seem OK, some, like 
 textfields lack the frame border when looked at with one of the Plastik 
 themes). Gimp may hang, but I doubt it's because of the engine (FreeBSD 
 recently changed pthread libs and I think that's the cause here).  Of course 
 it requires some testing on other FreeBSD versions to see if it works at all 
 there.
 
 It was a simple port. I submitted it to ports@freebsd without requesting 
 maintainership myself. This is better off with the overall KDE or Gnome 
 port/package team IMHO. If it gets into the tree I'm sure people will try it 
 and complain if it doesn't work. 
 
 Thanks for your software! Would appreciate a headsup if the major version 
 changes. I'll be happy to provide more feedback if you desire so.
 
 Best regards,
 
 Dan
 
 
 This text also sent to freebsd-gnats-submit@FreeBSD.org as follow-up to 
 ports/63282
State-Changed-From-To: open->feedback 
State-Changed-By: arved 
State-Changed-When: Thu Mar 18 09:43:11 PST 2004 
State-Changed-Why:  
Does not build on STABLE: 

gcc -DHAVE_DLFCN_H=1 -DSTDC_HEADERS=1 -I. -I. -I/usr/local/include/atk-1.0 -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/X11R6/include/gtk-2.0 -I/usr/X11R6/lib/gtk-2.0/include -I/usr/X11R6/include/pango-1.0 -I/usr/X11R6/include -I/usr/local/include/freetype2 -I/usr/local/include -I/usr/X11R6/include/ -I/usr/local/include -I/usr/X11R6/include -I/usr/X11R6/include -D_GETOPT_H -O -pipe -march=k6 -Wp,-MD,.deps/qt_theme_draw.pp -c qt_theme_draw.c        -fPIC -DPIC -o qt_theme_draw.lo 
qt_theme_draw.c: In function `draw_shadow': 
qt_theme_draw.c:302: syntax error before `*' 
qt_theme_draw.c:323: `gc1' undeclared (first use in this function) 
qt_theme_draw.c:323: (Each undeclared identifier is reported only once 
qt_theme_draw.c:323: for each function it appears in.) 
qt_theme_draw.c:323: `gc2' undeclared (first use in this function) 


http://www.freebsd.org/cgi/query-pr.cgi?pr=63282 

From: Danny Pansters <danny@ricin.com>
To: freebsd-gnats-submit@FreeBSD.org, danny@ricin.com
Cc: David Sansome <me@davidsansome.com>, ports@freebsd.org
Subject: Re: ports/63282: [NEW PORT] x11-toolkits/gtk-qt-engine
Date: Tue, 23 Mar 2004 02:12:35 +0100

 This message is also Re: [ACKNOWLEDGE AUTHOR] Submitted a FreeBSD port for 
 gtk-qt-engine
 
 On Saturday 20 March 2004 19:29, you wrote:
 > -----BEGIN PGP SIGNED MESSAGE-----
 > Hash: SHA1
 >
 > Hi Danny,
 >
 > Sorry for the late reply, I've been away this month :(
 >
 > I'm not familiar with the BSD ports system, or how things are submitted.
 > Thanks for doing it for me ;)
 
 OK, let me explain. There are port submitters who send in the makefile with 
 patches and anything needed to make the source code compile and install on 
 FreeBSD. Things like install prefix and compiler options can be specified. 
 The ports system first fetches the source code, first default preference is 
 from the authors website or FTP repository, then it checks md5 sum, then 
 extracts (bzip2, gzip, zip) source into a "work" directory. Then applies 
 patches, then configures (usually this step isn't specified) if any, then 
 builds, and installs and finally registers and optionally packs the result 
 into a binary package. 
 
 So a port maintainer or submitter mainly changes paths and stuff and other 
 small patches. Well, sometimes big ones. It works a lot like Gentoo Linux' 
 ebuilds which was inspired by *BSD ports. To browse ports please look at 
 http://www.freebsd.org/ports/index.html or http://www.freshports.org 
 
 > What happens now?  Should I notify anyone when there is a new version?
 
 Only port committers have CVS access. I don't. I recently recieved a reply 
 from the GNATS database that the port doesn't compile on FreeBSD-STABLE 
 (that's 4.9 at the time). I'm running 5.x (called -CURRENT) and the next 
 release 5.3 is slated to become the -STABLE branch. 
 
 So I'm kinda stuck and wondering if the problem was caused by other ports 
 (gtk) rather than it being a build problem with this software. 
 
 I've rebuilt gtk20 and gtk-qt-engine without any problems, including the 
 latest font changes. I have tried building the port against gcc2.95, 3.2 and 
 3.3 (the default in 5.x, I don't know about 4.x, might be 2.95 still) and all 
 worked fine. I also tried with gtk built with and without what's called the 
 "experimental menu dropshadow patch". In both cases gtk-qt-engine worked fine 
 on my 5.2-CURRENT desktop. 
 
 I will send this as feedback to the FreeBSD bug database also, this entry is 
 at http://www.freebsd.org/cgi/query-pr.cgi?pr=63282 please look there also 
 for the reported build error, perhaps it rings a bell (disclaimer: I'm not a 
 C programmer).
 
 I hope someone can provide more feedback, otherwise I'll just resubmit when we 
 arrive at FreeBSD-5.3. I took the liberty of CC'ing to ports@. This port is 
 really an asset to KDE but I don't have spare boxen to run -STABLE on.
 
 > > Thanks for your software! Would appreciate a headsup if the major version
 > > changes. I'll be happy to provide more feedback if you desire so.
 >
 > Will do :)
 
 In the port's Makefile I have set maintainer to be ports@freebsd.org (that is: 
 nobody). Not because I'd hate to be it, but rather because if this is adopted 
 it should probably be in the hands of our kde@ team I think. But I'll happily 
 submit any version bumps. 
 
 Finally some random layman's (OK, that's a bit of an understatement) 
 observations: Textfields and combo's and the like have no border. Toolbars 
 have no border. Scrollbars leave an open "non-scrollable" space at the bottom 
 or at the right. Standard OK and Cancel buttons should have no image and 
 scale normally not bigger (observed in gimp-2-pre). In the Dir menu the OK 
 button, when used in an app without icon, shows no text and after selection 
 of the dir it becomes a flattened rectangle altogether (observed in an wx-gtk 
 app of my own). Hope this helps! I looked at them using the PlastiK theme.
 
 All in all, gtk apps look a LOT better this way when one runs a KDE system. 
 Haven't observed any apparent crashes, hangs, panics or memory sinks.
 
 > David Sansome
 > -----BEGIN PGP SIGNATURE-----
 > Version: GnuPG v1.2.4 (GNU/Linux)
 >
 > iD8DBQFAXI2MBxzHzN8T1fgRAgOWAJ971B3CFmjj0YMNRI1OB9VWBsrYwwCfekrw
 > g/EVSLt9BnNl6Lfy7SfW8QU=
 > =4Gyk
 > -----END PGP SIGNATURE-----
 
 
 Greetings,
 
 Dan

From: Danny Pansters <danny@ricin.com>
To: freebsd-gnats-submit@FreeBSD.org, danny@ricin.com
Cc: Tilman Linneweh <arved@FreeBSD.org>,
	freebsd-ports-bugs@FreeBSD.org, David Sansome <me@davidsansome.com>
Subject: Re: ports/63282: [NEW PORT] x11-toolkits/gtk-qt-engine
Date: Tue, 30 Mar 2004 02:31:22 +0200

 On Thursday 18 March 2004 18:43, you wrote:
 > Synopsis: [NEW PORT] x11-toolkits/gtk-qt-engine
 >
 > State-Changed-From-To: open->feedback
 > State-Changed-By: arved
 > State-Changed-When: Thu Mar 18 09:43:11 PST 2004
 > State-Changed-Why:
 > Does not build on STABLE:
 >
 > gcc -DHAVE_DLFCN_H=1 -DSTDC_HEADERS=1 -I. -I. -I/usr/local/include/atk-1.0
 > -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include
 > -I/usr/X11R6/include/gtk-2.0 -I/usr/X11R6/lib/gtk-2.0/include
 > -I/usr/X11R6/include/pango-1.0 -I/usr/X11R6/include
 > -I/usr/local/include/freetype2 -I/usr/local/include -I/usr/X11R6/include/
 > -I/usr/local/include -I/usr/X11R6/include -I/usr/X11R6/include -D_GETOPT_H
 > -O -pipe -march=k6 -Wp,-MD,.deps/qt_theme_draw.pp -c qt_theme_draw.c       
 > -fPIC -DPIC -o qt_theme_draw.lo qt_theme_draw.c: In function `draw_shadow':
 > qt_theme_draw.c:302: syntax error before `*'
 > qt_theme_draw.c:323: `gc1' undeclared (first use in this function)
 > qt_theme_draw.c:323: (Each undeclared identifier is reported only once
 > qt_theme_draw.c:323: for each function it appears in.)
 > qt_theme_draw.c:323: `gc2' undeclared (first use in this function)
 >
 >
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=63282
 
 Author David Sansome <me AT davidsansome.com> suggested that the build error 
 might be caused by gdk not being included "whereas it is probably included by 
 default in your version of GTK". 
 
 It shouldn't make any difference if it's on -CURRENT or -STABLE anyway because 
 ports are always a HEAD. I tested with and without the patch below 
 pkg_deinstall'ing gtk and then have it be pulled in and built via this port. 
 No probs.
 
 I'm thinking that this may have been a temporary problem with the gtk port. 
 Could someone test this on -STABLE, both with and without the below patch 
 which explicitly includes gdk? I don't have a spare box to test with -STABLE.
 
 workstation# cat files/patch-qt_theme_draw.c
 --- qt_theme_draw.c.orig        Mon Feb  9 19:50:12 2004
 +++ qt_theme_draw.c     Tue Mar 30 02:09:08 2004
 @@ -1,5 +1,6 @@
  #include <math.h>
  #include <string.h>
 +#include <gdk/gdk.h>
  #include <gtk/gtkprogressbar.h>
  #include <gtk/gtkrange.h>
  #include <gtk/gtknotebook.h>
 
 Dan
 
 (CC'd to arved and David; also gnats ports/63282 -- Hope I didn't over-CC)
State-Changed-From-To: feedback->open 
State-Changed-By: arved 
State-Changed-When: Thu Apr 15 10:04:32 PDT 2004 
State-Changed-Why:  
feedback arrived 

http://www.freebsd.org/cgi/query-pr.cgi?pr=63282 
State-Changed-From-To: open->closed 
State-Changed-By: thierry 
State-Changed-When: Sun May 30 15:17:29 PDT 2004 
State-Changed-Why:  

New port added, thanks! 
(with some quirks) 


http://www.freebsd.org/cgi/query-pr.cgi?pr=63282 

From: Michael Nottebrock <lofi@freebsd.org>
To: freebsd-gnats-submit@freebsd.org, danny@ricin.com
Cc:  
Subject: Re: ports/63282: [NEW PORT] x11-toolkits/gtk-qt-engine
Date: Mon, 31 May 2004 03:45:34 +0200

 Danny: There's no way this port could have ever compiled with gcc295, not in 
 FreeBSD 5.x or elsewhere. I have hacked it into compiling by moving the 
 failing declarations, since you already contacted the author before, you 
 might want to forward files/patch-qt_theme_draw.c to him for reference (the 
 additional include is not necessary).
 
 Thierry: Don't use USE_GCC=3.x for anything which links against anything C++. 
 gcc 2.x and gcc 3.x have incompatible ABI for binaries compiled from C++ code 
 and since this engine links against Qt, this port was effectivly committed 
 broken on -STABLE (but should be fixed now).

From: Michael Nottebrock <michaelnottebrock@gmx.net>
To: danny@ricin.com
Cc: freebsd-gnats-submit@FreeBSD.org, me@davidsansome.com
Subject: Re: ports/63282: [NEW PORT] x11-toolkits/gtk-qt-engine
Date: Tue, 1 Jun 2004 02:26:04 +0200

 On Tuesday 01 June 2004 02:05, Danny Pansters wrote:
 
 > Michael, I tried again with gcc-2.95 from ports on 5.2-something. Here's
 > the result:
 >
 > Workstation# make deinstall
 > ===>  Deinstalling for x11-toolkits/gtk-qt-engine
 > ===>   Deinstalling gtk-qt-engine-0.3
 > workstation# cat Makefile | grep GCC
 > USE_GCC=        2.95
 
 [...]
 
 > gcc -DHAVE_DLFCN_H=1 -DSTDC_HEADERS=1 -I. -I. -I/usr/local/include/atk-1.0
 
 For some reason, the USE_GCC has no effect for you. The ports version of gcc 
 2.95 installs gcc295 and g++295, and those should be used here. Try make 
 CC=gcc295 CXX=295. I assure you again: The source as distributed is NOT 
 compileable with gcc 2.95. It only is with the patches in 
 files/patch-qt_theme_draw.c.
 
 > Note that qt_theme_draw only gives warnings. Could run gimp-2 fine with my
 > KDE theme on it. Anyway this bug should be reopened not closed (and not
 > accepted) if it doesn't work OK. It really builds and runs here though.
 
 It's fixed in ports for now, this PR does not need reopening. You should 
 however forward the necessary patches to the author if possible.
 
 > I'll be the first to admid that I'm not much into the guts of GTK but I'm
 > wondering if the problems observed aren't gtk things solely
 > [...]
 
 No. It's a gcc issue, gcc 2.95's parser just isn't as relaxed about 
 declarations as gcc 3.x's.
 
 -- 
    ,_,   | Michael Nottebrock               | lofi@freebsd.org
  (/^ ^\) | FreeBSD - The Power to Serve     | http://www.freebsd.org
    \u/   | K Desktop Environment on FreeBSD | http://freebsd.kde.org

From: Michael Nottebrock <lofi@freebsd.org>
To: danny@ricin.com
Cc: freebsd-gnats-submit@freebsd.org, me@davidsansome.com
Subject: Re: ports/63282: [NEW PORT] x11-toolkits/gtk-qt-engine
Date: Tue, 1 Jun 2004 03:33:21 +0200

 On Tuesday 01 June 2004 03:08, Danny Pansters wrote:
 
 > Thanks very much for your speedy reply. That would be a ports bug then, no?
 
 It seems something in your environment prevents CC/CXX from being used. Or 
 perhaps you override them in /etc/make.conf?
 
 > workstation# make CC=gcc295 CXX=295 install clean
 
 That was a typo of mine, it should be CXX=g++295 of course.
 
 > checking whether the C compiler (gcc -O -pipe ) works... yes
 > checking whether the C compiler (gcc -O -pipe ) is a cross-compiler... no
 > checking whether we are using GNU C... (cached) yes
 > checking whether gcc accepts -g... (cached) yes
 > checking for c++... (cached) c++
 > checking whether the C++ compiler (c++ -O -pipe ) works... yes
 > checking whether the C++ compiler (c++ -O -pipe ) is a cross-compiler... no
 
 [...]
 
 > gcc -DHAVE_DLFCN_H=1 -DSTDC_HEADERS=1 -I. -I. -I/usr/local/include/atk-1.0
 
 [...]
 
 > c++ -DHAVE_DLFCN_H=1 -DSTDC_HEADERS=1 -I. -I. -I/usr/local/include/atk-1.0
 
 [...]
 
 As you can see, neither the CC nor the CXX you set are being used. You should 
 see the changed compiler already in the configure script, like this:
 
 [lofi@lofi]:0:/usr/ports/x11-toolkits/gtk-qt-engine # make CC=gcc295 
 CXX=g++295
 ===>  Extracting for gtk-qt-engine-0.3
 >> Checksum OK for gtk-qt-engine-0.3.tar.bz2.
 ===>  Patching for gtk-qt-engine-0.3
 ===>  Applying FreeBSD patches for gtk-qt-engine-0.3
 ===>   gtk-qt-engine-0.3 depends on file: /usr/X11R6/bin/moc - found
 ===>   gtk-qt-engine-0.3 depends on executable: gmake - found
 ===>   gtk-qt-engine-0.3 depends on file: /usr/local/libexec/libtool13/libtool 
 - found
 ===>   gtk-qt-engine-0.3 depends on executable: pkg-config - found
 ===>   gtk-qt-engine-0.3 depends on file: /usr/local/bin/intltool-extract - 
 found
 ===>   gtk-qt-engine-0.3 depends on shared library: X11.6 - found
 ===>   gtk-qt-engine-0.3 depends on shared library: glib-2.0.400 - found
 ===>   gtk-qt-engine-0.3 depends on shared library: atk-1.0.600 - found
 ===>   gtk-qt-engine-0.3 depends on shared library: pango-1.0.399 - found
 ===>   gtk-qt-engine-0.3 depends on shared library: gtk-x11-2.0.400 - found
 ===>  Configuring for gtk-qt-engine-0.3
 creating cache ./config.cache
 checking for a BSD compatible install... /usr/bin/install -c -o root -g wheel
 checking whether build environment is sane... yes
 checking whether gmake sets ${MAKE}... yes
 checking for working aclocal-1.4... missing
 checking for working autoconf... found
 checking for working automake-1.4... missing
 checking for working autoheader... found
 checking for working makeinfo... found
 checking whether to enable maintainer-specific portions of Makefiles... no
 checking host system type... i386-unknown-freebsd5.2.1
 checking for gcc... gcc295
 checking whether the C compiler (gcc295 -O -pipe -mcpu=pentiumpro ) works... 
 yes
 checking whether the C compiler (gcc295 -O -pipe -mcpu=pentiumpro ) is a 
 cross-compiler... no
 checking whether we are using GNU C... yes
 checking whether gcc295 accepts -g... yes
 checking for c++... g++295
 checking whether the C++ compiler (g++295 -O -pipe -mcpu=pentiumpro ) works... 
 yes
 checking whether the C++ compiler (g++295 -O -pipe -mcpu=pentiumpro ) is a 
 cross-compiler... no
 
 
 > > It's fixed in ports for now, this PR does not need reopening. You should
 > > however forward the necessary patches to the author if possible.
 >
 > Perhaps the author can make out any nescessary patches. From what info I
 > can gather, I can't. I will forward this message like I did the last one as
 > you might have noticed though.
 
 Ugh, I didn't. However, the patches are in 
 http://www.freebsd.org/cgi/cvsweb.cgi/~checkout~/ports/x11-toolkits/gtk-qt-engine/files/patch-qt_theme_draw.c?rev=1.2&content-type=text/plain

From: David Sansome <me@davidsansome.com>
To: Michael Nottebrock <lofi@freebsd.org>
Cc: danny@ricin.com, freebsd-gnats-submit@freebsd.org
Subject: Re: ports/63282: [NEW PORT] x11-toolkits/gtk-qt-engine
Date: Tue, 1 Jun 2004 17:05:33 +0000

 =2D----BEGIN PGP SIGNED MESSAGE-----
 Hash: SHA1
 
 > Ugh, I didn't. However, the patches are in
 > http://www.freebsd.org/cgi/cvsweb.cgi/~checkout~/ports/x11-toolkits/gtk-q=
 t-
 >engine/files/patch-qt_theme_draw.c?rev=3D1.2&content-type=3Dtext/plain
 
 Danny, Michael,
 
 Thanks for the work you've done on this - I've applied the patch to=20
 freedesktop.org CVS.
 
 So is this all working correctly now, or is there anything else I need to d=
 o?
 
 Thanks,
 David Sansome
 =2D----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.4 (GNU/Linux)
 
 iD8DBQFAvLdfBxzHzN8T1fgRAhsMAJ9OIaGn3+vSwF0uXdLRYkxHYXPjlACgl1De
 /gXSWSre88nNvJeB0gPGvYo=3D
 =3Dw3ni
 =2D----END PGP SIGNATURE-----
>Unformatted:
