From jamie@thompson.bishopston.net  Sun Feb 22 05:10:47 2004
Return-Path: <jamie@thompson.bishopston.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id BF66116A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 22 Feb 2004 05:10:47 -0800 (PST)
Received: from mailhost1.bishopston.net (mailhost1.bishopston.net [68.147.148.236])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7AC2443D1F
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 22 Feb 2004 05:10:47 -0800 (PST)
	(envelope-from jamie@thompson.bishopston.net)
Received: from tiffany.bishopston.net (tiffany.bishopston.net [IPv6:3ffe:b80:c3c:1::1] (may be forged))
	by catflap.bishopston.net (8.12.11/8.12.11) with ESMTP id i1MDAcas067675
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 22 Feb 2004 13:10:39 GMT
	(envelope-from jamie@thompson.bishopston.net)
Received: from thompson.bishopston.net (thompson.bishopston.net [IPv6:3ffe:b80:c3c:1::100])
	by tiffany.bishopston.net (8.12.10/8.11.6) with ESMTP id i1MDAb52001164
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 22 Feb 2004 13:10:37 GMT
	(envelope-from jamie@thompson.bishopston.net)
Received: from thompson.bishopston.net (localhost [IPv6:::1])
	by thompson.bishopston.net (8.12.11/8.12.3) with ESMTP id i1MDAbwP043408
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 22 Feb 2004 13:10:37 GMT
	(envelope-from jamie@thompson.bishopston.net)
Received: (from jamie@localhost)
	by thompson.bishopston.net (8.12.11/8.12.9/Submit) id i1MDAZcs043400;
	Sun, 22 Feb 2004 13:10:35 GMT
	(envelope-from jamie)
Message-Id: <200402221310.i1MDAZcs043400@thompson.bishopston.net>
Date: Sun, 22 Feb 2004 13:10:35 GMT
From: Jamie Jones <jamie@thompson.bishopston.net>
Reply-To: Jamie Jones <jamie@thompson.bishopston.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: 'BROKEN' or 'IGNORED' ports exit their "make install" with a success status.
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         63216
>Category:       ports
>Synopsis:       [patch] 'BROKEN' or 'IGNORED' ports exit their "make install" with a success status.
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    portmgr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Feb 22 05:20:15 PST 2004
>Closed-Date:    Sat Jan 28 02:13:27 GMT 2006
>Last-Modified:  Sat Jan 28 02:13:27 GMT 2006
>Originator:     Jamie Jones
>Release:        FreeBSD 5.2-RELEASE i386
>Organization:
>Environment:
System: FreeBSD thompson.bishopston.net 5.2-RELEASE FreeBSD 5.2-RELEASE #0: Fri Jan 23 17:35:27 GMT 2004 root@thompson.bishopston.net:/usr/obj/usr/src/sys/THOMPSON i386


	
>Description:
	When attempting to install a port which fails due to being
	marked BROKEN, the make exits with a success status, meaning
	that any scripts that make a port and then delete the previous
	port on successful compile end up deleting the only installed
	working version.
>How-To-Repeat:
	cd /usr/ports/multimedia/ffmpeg  (for example)
	make clean; make && make deinstall

        Although this port is currently marked broken, and won't compile, the
	installed port is deleted as the make exitted with "success" status.

	
>Fix:
	Make ignored/broken ports exit "1" from the make

	


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->portmgr 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sun Feb 22 14:02:08 PST 2004 
Responsible-Changed-Why:  
This looks like a bsd.port.mk issue. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=63216 
State-Changed-From-To: open->suspended 
State-Changed-By: kris 
State-Changed-When: Sat Mar 20 18:27:09 PST 2004 
State-Changed-Why:  
Suspended awaiting patch 

http://www.freebsd.org/cgi/query-pr.cgi?pr=63216 
State-Changed-From-To: suspended->open 
State-Changed-By: sem 
State-Changed-When: Fri Jan 14 00:45:16 GMT 2005 
State-Changed-Why:  
A patch was reseived 

http://www.freebsd.org/cgi/query-pr.cgi?pr=63216 

From: Sergey Matveychuk <sem@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Cc: jamie@thompson.bishopston.net, kris@FreeBSD.org
Subject: Re: ports/63216: 'BROKEN' or 'IGNORED' ports exit their "make install"
 with a success status.
Date: Fri, 14 Jan 2005 03:45:20 +0300

 This is a multi-part message in MIME format.
 --------------060608010402070509050304
 Content-Type: text/plain; charset=us-ascii; format=flowed
 Content-Transfer-Encoding: 7bit
 
 The patch is easy enough.
 Does it OK for pointyhat builds?
 
 -- 
 Sem.
 
 --------------060608010402070509050304
 Content-Type: text/plain;
  name="bsd.port.mk.patch"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline;
  filename="bsd.port.mk.patch"
 
 Index: bsd.port.mk
 ===================================================================
 RCS file: /home/pcvs/ports/Mk/bsd.port.mk,v
 retrieving revision 1.505
 diff -u -r1.505 bsd.port.mk
 --- bsd.port.mk	31 Dec 2004 18:23:43 -0000	1.505
 +++ bsd.port.mk	14 Jan 2005 00:42:10 -0000
 @@ -2746,7 +2746,7 @@
  .if defined(IGNORE_SILENT)
  IGNORECMD=	${DO_NADA}
  .else
 -IGNORECMD=	${ECHO_MSG} "===>  ${PKGNAME} ${IGNORE}."
 +IGNORECMD=	${ECHO_MSG} "===>  ${PKGNAME} ${IGNORE}.";exit 1
  .endif
  
  .for target in check-sanity fetch checksum extract patch configure all build install reinstall package
 
 --------------060608010402070509050304--
State-Changed-From-To: open->analyzed 
State-Changed-By: linimon 
State-Changed-When: Sat Jan 21 20:00:42 UTC 2006 
State-Changed-Why:  
Accepted for a test build on the cluster. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=63216 
State-Changed-From-To: analyzed->closed 
State-Changed-By: linimon 
State-Changed-When: Sat Jan 28 02:13:16 UTC 2006 
State-Changed-Why:  
Committed, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=63216 
>Unformatted:
