From arundel@gmx.net  Tue Feb 10 07:14:36 2004
Return-Path: <arundel@gmx.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6BC6316A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 10 Feb 2004 07:14:36 -0800 (PST)
Received: from mail.gmx.net (pop.gmx.de [213.165.64.20])
	by mx1.FreeBSD.org (Postfix) with SMTP id 9559F43D31
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 10 Feb 2004 07:14:35 -0800 (PST)
	(envelope-from arundel@gmx.net)
Received: (qmail 31005 invoked by uid 65534); 10 Feb 2004 15:14:34 -0000
Received: from pD9FF146B.dip.t-dialin.net (EHLO freebsd-usr) (217.255.20.107)
  by mail.gmx.net (mp010) with SMTP; 10 Feb 2004 16:14:34 +0100
Received: by freebsd-usr (sSMTP sendmail emulation); Tue, 10 Feb 2004 16:14:36 +0100
Message-Id: <20040210151436.GA45855@gmx.net>
Date: Tue, 10 Feb 2004 16:14:36 +0100
From: "alexander" <arundel@gmx.net>
Reply-To: No Name <arundel@gmx.net>
To: FreeBSD-gnats-submit@freebsd.org
Subject: Maintainer update of /emulators/vba
X-Send-Pr-Version: 3.113

>Number:         62645
>Category:       ports
>Synopsis:       Maintainer update of /emulators/vba
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    linimon
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 10 07:20:16 PST 2004
>Closed-Date:    Tue Feb 17 02:06:42 PST 2004
>Last-Modified:  Tue Jul 27 14:00:51 UTC 2010
>Originator:     Alexander Best
>Release:        FreeBSD 4.9-STABLE i386
>Organization:
>Environment:
System: FreeBSD skatecity 4.9-STABLE FreeBSD 4.9-STABLE #0: Sun Feb 8 17:15:36 CET 2004 arundel@skatecity:/usr/obj/usr/src/sys/ARUNDEL i386


>Description:
	Update of /emulators/vba from 1.7 to 1.71
>How-To-Repeat:

>Fix:


--- output begins here ---
diff -ru /usr/ports/emulators/vba/Makefile /usr/ports/custom/vba/Makefile
--- /usr/ports/emulators/vba/Makefile	Sat Feb  7 06:54:44 2004
+++ /usr/ports/custom/vba/Makefile	Tue Feb 10 16:10:51 2004
@@ -5,8 +5,7 @@
 # $FreeBSD: ports/emulators/vba/Makefile,v 1.3 2004/02/04 05:20:08 marcus Exp $
 
 PORTNAME=	vba
-PORTVERSION=	1.7
-PORTREVISION=	1
+PORTVERSION=	1.7.1
 CATEGORIES=	emulators
 MASTER_SITES=	${MASTER_SITE_SOURCEFORGE}
 MASTER_SITE_SUBDIR=	${PORTNAME}
@@ -21,7 +20,6 @@
 USE_X_PREFIX=	yes
 USE_GMAKE=	yes
 GNU_CONFIGURE=	yes
-CONFIGURE_ARGS=	--without-profiling
 USE_SDL=	yes
 WRKSRC=		${WRKDIR}/VisualBoyAdvance-${PORTVERSION}
 
@@ -36,8 +34,9 @@
 .endif
 
 DATA_FILES=	${WRKSRC}/src/VisualBoyAdvance.cfg
-PROG_FILES=	${WRKSRC}/src/VisualBoyAdvance
-DOC_FILES=	${WRKSRC}/COPYING ${WRKSRC}/AUTHORS ${WRKSRC}/NEWS ${WRKSRC}/README
+PROG_FILES=	${WRKSRC}/src/VisualBoyAdvance ${WRKSRC}/src/TestEmu
+DOC_FILES=	${WRKSRC}/COPYING ${WRKSRC}/AUTHORS ${WRKSRC}/NEWS ${WRKSRC}/README \
+		${WRKSRC}/ChangeLog ${WRKSRC}/INSTALL
 
 pre-everything::
 	@${ECHO_MSG} ""
@@ -49,13 +48,13 @@
 	@${ECHO_MSG} "flag."
 	@${ECHO_MSG} ""
 
-post-extract:
-	rm -rf `find ${WRKSRC} -name '.deps'`
-
 do-install:
-	${INSTALL} -d ${TARGET_DIR} && \
-	${INSTALL_PROGRAM} ${PROG_FILES} ${TARGET_DIR} && \
-	${INSTALL_DATA} ${DATA_FILES} ${TARGET_DIR} && \
+	${INSTALL} -d ${TARGET_DIR}
+	${INSTALL_PROGRAM} ${PROG_FILES} ${TARGET_DIR}
+
+.if !exists (${PREFIX}/bin/VisualBoyAdvance.cfg)
+	${INSTALL_DATA} ${DATA_FILES} ${TARGET_DIR}
+.endif
 
 post-install:
 .ifndef(NOPORTDOCS)
diff -ru /usr/ports/emulators/vba/distinfo /usr/ports/custom/vba/distinfo
--- /usr/ports/emulators/vba/distinfo	Sat Jan 24 04:56:40 2004
+++ /usr/ports/custom/vba/distinfo	Tue Feb 10 14:12:39 2004
@@ -1 +1 @@
-MD5 (VisualBoyAdvance-src-1.7.tar.gz) = 31a8665e90e84a079ab6664842083f55
+MD5 (VisualBoyAdvance-src-1.7.1.tar.gz) = 4147eeac55ecf713397f19eae636eef3
diff -ru /usr/ports/emulators/vba/files/patch-aa /usr/ports/custom/vba/files/patch-aa
--- /usr/ports/emulators/vba/files/patch-aa	Sat Jan 24 04:56:40 2004
+++ /usr/ports/custom/vba/files/patch-aa	Tue Feb 10 14:47:30 2004
@@ -1,19 +1,11 @@
-*** src/SDL.cpp.orig	Sun Jan 11 22:20:00 2004
---- src/SDL.cpp	Sun Jan 11 22:17:23 2004
-***************
-*** 625,631 ****
-    }
-  #else
-  #define SDL_CALL_STRETCHER \
-!         asm volatile("call *%%eax"::"a" (stretcher),"S" (src),"D" (dest))
-  #endif
-  #else
-  #define SDL_CALL_STRETCHER \
---- 625,631 ----
-    }
-  #else
-  #define SDL_CALL_STRETCHER \
-! //        asm volatile("call *%%eax"::"a" (stretcher),"S" (src),"D" (dest))
-  #endif
-  #else
-  #define SDL_CALL_STRETCHER \
+--- src/SDL.cpp.orig	Sun Feb  8 14:45:01 2004
++++ src/SDL.cpp		Tue Feb 10 14:45:09 2004
+@@ -621,7 +621,7 @@
+   }
+ #else
+ #define SDL_CALL_STRETCHER \
+-        asm volatile("call *%%eax"::"a" (stretcher),"S" (src),"D" (dest))
++        asm volatile("call *%%eax" : "=a" (stretcher),"=S" (src),"=D" (dest))
+ #endif
+ #else
+ #define SDL_CALL_STRETCHER \
Only in /usr/ports/custom/vba/files: patch-ac
Only in /usr/ports/custom/vba/files: patch-ad
diff -ru /usr/ports/emulators/vba/pkg-descr /usr/ports/custom/vba/pkg-descr
--- /usr/ports/emulators/vba/pkg-descr	Fri Oct  3 15:07:59 2003
+++ /usr/ports/custom/vba/pkg-descr	Tue Feb 10 16:06:00 2004
@@ -1,21 +1,19 @@
-- configurable GB/GBA keys, including joystick support
+VisualBoyAdvance is an emulator for Nintendo's Gameboy Advance. It also
+supports emulation of the Gameboy (classic), Gameboy Pocket, Gameboy Color
+and Gameboy Advance SP.
+Some of the main features are:
+
 - option to use BIOS file
 - zip/gzip file support
-- directory selection for save state, battery and screen capture
-- fullscreen mode (selectable resolution)
-- video sizes 1x, 2x, 3x and 4x
 - graphic filters Normal, TV Mode, 2xSaI, Super 2xSaI and more
 - interframe blending support
-- same emulation core as VisualBoyAdvance: GB and GBA emulation
 - built-in ARM/THUMB assembly debugger
 - 10 save states accesible through keyboard
 - automatic battery file load/save
 - auto-fire support
-- pause, reset through keyboard
 - 16, 24 and 32 bit desktop support
 - GDB remote debugging (see below for information)
-- auto frameskipping and throttle
 - AGBPrint support for development
 - RTC support
 
-WWW:  http://vboy.emuhq.com/
+WWW: http://vba.ngemu.com/
diff -ru /usr/ports/emulators/vba/pkg-plist /usr/ports/custom/vba/pkg-plist
--- /usr/ports/emulators/vba/pkg-plist	Sat Jan 24 04:56:40 2004
+++ /usr/ports/custom/vba/pkg-plist	Tue Feb 10 15:39:24 2004
@@ -1,7 +1,9 @@
 bin/VisualBoyAdvance
-bin/VisualBoyAdvance.cfg
+bin/TestEmu
 %%PORTDOCS%%%%DOCSDIR%%/COPYING
 %%PORTDOCS%%%%DOCSDIR%%/AUTHORS
 %%PORTDOCS%%%%DOCSDIR%%/NEWS
 %%PORTDOCS%%%%DOCSDIR%%/README
+%%PORTDOCS%%%%DOCSDIR%%/ChangeLog
+%%PORTDOCS%%%%DOCSDIR%%/INSTALL
 @dirrm share/doc/vba
--- output ends here ---

>Release-Note:
>Audit-Trail:
Although this does indeed compile on 4.9, I notice in your
patchfile the following two lines:

Only in /usr/ports/custom/vba/files: patch-ac
Only in /usr/ports/custom/vba/files: patch-ad

If these patches need to be included, please use diff -ruN
in the future when submitting your patches, to pick up new
files like this.  In the meantime, I don't see any reason
to resubmit the entire diff for those two files; but could
you please append them to this PR?  Or, otherwise, advise
that the two files aren't really needed.  Thanks.
State-Changed-From-To: open->feedback 
State-Changed-By: linimon 
State-Changed-When: Fri Feb 13 14:44:52 PST 2004 
State-Changed-Why:  
Note that I've asked the submitter for feedback. 


Responsible-Changed-From-To: freebsd-ports-bugs->linimon 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Fri Feb 13 14:44:52 PST 2004 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=62645 

From: "alexander" <arundel@gmx.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:  
Subject: Re: ports/62645: Maintainer update of /emulators/vba
Date: Sat, 14 Feb 2004 14:16:28 +0100

 >Submitter-Id:	current-users
 >Originator:	Alexander Best
 >Organization:	<organization of PR author (multiple lines)>
 >Confidential:	no <FreeBSD PRs are public data>
 >Synopsis:	Re: ports/62645: Maintainer update of /emulators/vba
 >Severity:	non-critical
 >Priority:	medium
 >Category:	ports
 >Class:		maintainer-update
 >Release:	FreeBSD 4.9-STABLE i386
 >Environment:
 System: FreeBSD skatecity 4.9-STABLE FreeBSD 4.9-STABLE #0: Sun Feb 8 17:15:36 CET 2004 arundel@skatecity:/usr/obj/usr/src/sys/ARUNDEL i386
 
 >Description:
 	Maintainer update of /emulators/vba
 
 >How-To-Repeat:
 
 >Fix:
 
 --- output begins here ---
 diff -urP /usr/ports/emulators/vba/Makefile /usr/ports/custom/vba/Makefile
 --- /usr/ports/emulators/vba/Makefile	Sat Feb  7 06:54:44 2004
 +++ /usr/ports/custom/vba/Makefile	Sat Feb 14 13:56:18 2004
 @@ -5,8 +5,7 @@
  # $FreeBSD: ports/emulators/vba/Makefile,v 1.3 2004/02/04 05:20:08 marcus Exp $
  
  PORTNAME=	vba
 -PORTVERSION=	1.7
 -PORTREVISION=	1
 +PORTVERSION=	1.7.1
  CATEGORIES=	emulators
  MASTER_SITES=	${MASTER_SITE_SOURCEFORGE}
  MASTER_SITE_SUBDIR=	${PORTNAME}
 @@ -21,7 +20,6 @@
  USE_X_PREFIX=	yes
  USE_GMAKE=	yes
  GNU_CONFIGURE=	yes
 -CONFIGURE_ARGS=	--without-profiling
  USE_SDL=	yes
  WRKSRC=		${WRKDIR}/VisualBoyAdvance-${PORTVERSION}
  
 @@ -36,8 +34,8 @@
  .endif
  
  DATA_FILES=	${WRKSRC}/src/VisualBoyAdvance.cfg
 -PROG_FILES=	${WRKSRC}/src/VisualBoyAdvance
 -DOC_FILES=	${WRKSRC}/COPYING ${WRKSRC}/AUTHORS ${WRKSRC}/NEWS ${WRKSRC}/README
 +PROG_FILES=	${WRKSRC}/src/VisualBoyAdvance ${WRKSRC}/src/TestEmu
 +DOC_FILES=	COPYING AUTHORS NEWS README ChangeLog INSTALL
  
  pre-everything::
  	@${ECHO_MSG} ""
 @@ -49,18 +47,21 @@
  	@${ECHO_MSG} "flag."
  	@${ECHO_MSG} ""
  
 -post-extract:
 -	rm -rf `find ${WRKSRC} -name '.deps'`
 -
  do-install:
 -	${INSTALL} -d ${TARGET_DIR} && \
 -	${INSTALL_PROGRAM} ${PROG_FILES} ${TARGET_DIR} && \
 -	${INSTALL_DATA} ${DATA_FILES} ${TARGET_DIR} && \
 +	${INSTALL} -d ${TARGET_DIR}
 +	${INSTALL_PROGRAM} ${PROG_FILES} ${TARGET_DIR}
 +
 +.if !exists (${PREFIX}/bin/VisualBoyAdvance.cfg)
 +	${INSTALL_DATA} ${DATA_FILES} ${TARGET_DIR}
 +.endif
  
  post-install:
  .ifndef(NOPORTDOCS)
  	${MKDIR} ${DOCSDIR}
 -	${INSTALL_MAN} ${DOC_FILES} ${DOCSDIR}
 +
 +.for file in ${DOC_FILES}
 +	${INSTALL_MAN} ${WRKSRC}/${file} ${DOCSDIR}
 +.endfor
  .endif
  
  .include <bsd.port.post.mk>
 diff -urP /usr/ports/emulators/vba/distinfo /usr/ports/custom/vba/distinfo
 --- /usr/ports/emulators/vba/distinfo	Sat Jan 24 04:56:40 2004
 +++ /usr/ports/custom/vba/distinfo	Tue Feb 10 14:12:39 2004
 @@ -1 +1 @@
 -MD5 (VisualBoyAdvance-src-1.7.tar.gz) = 31a8665e90e84a079ab6664842083f55
 +MD5 (VisualBoyAdvance-src-1.7.1.tar.gz) = 4147eeac55ecf713397f19eae636eef3
 diff -urP /usr/ports/emulators/vba/files/patch-aa /usr/ports/custom/vba/files/patch-aa
 --- /usr/ports/emulators/vba/files/patch-aa	Sat Jan 24 04:56:40 2004
 +++ /usr/ports/custom/vba/files/patch-aa	Tue Feb 10 14:47:30 2004
 @@ -1,19 +1,11 @@
 -*** src/SDL.cpp.orig	Sun Jan 11 22:20:00 2004
 ---- src/SDL.cpp	Sun Jan 11 22:17:23 2004
 -***************
 -*** 625,631 ****
 -    }
 -  #else
 -  #define SDL_CALL_STRETCHER \
 -!         asm volatile("call *%%eax"::"a" (stretcher),"S" (src),"D" (dest))
 -  #endif
 -  #else
 -  #define SDL_CALL_STRETCHER \
 ---- 625,631 ----
 -    }
 -  #else
 -  #define SDL_CALL_STRETCHER \
 -! //        asm volatile("call *%%eax"::"a" (stretcher),"S" (src),"D" (dest))
 -  #endif
 -  #else
 -  #define SDL_CALL_STRETCHER \
 +--- src/SDL.cpp.orig	Sun Feb  8 14:45:01 2004
 ++++ src/SDL.cpp		Tue Feb 10 14:45:09 2004
 +@@ -621,7 +621,7 @@
 +   }
 + #else
 + #define SDL_CALL_STRETCHER \
 +-        asm volatile("call *%%eax"::"a" (stretcher),"S" (src),"D" (dest))
 ++        asm volatile("call *%%eax" : "=a" (stretcher),"=S" (src),"=D" (dest))
 + #endif
 + #else
 + #define SDL_CALL_STRETCHER \
 diff -urP /usr/ports/emulators/vba/files/patch-ac /usr/ports/custom/vba/files/patch-ac
 --- /usr/ports/emulators/vba/files/patch-ac	Thu Jan  1 01:00:00 1970
 +++ /usr/ports/custom/vba/files/patch-ac	Tue Feb 10 15:31:25 2004
 @@ -0,0 +1,11 @@
 +--- src/Makefile.am.orig	Sun Feb  1 16:00:46 2004
 ++++ src/Makefile.am		Tue Feb 10 15:03:25 2004
 +@@ -18,7 +18,7 @@
 + 	hq2x.cpp hq2x.h lq2x.h Text.cpp Text.h interp.h
 + 
 + VisualBoyAdvance_LDADD = gb/libgb.a @VBA_PROF@ @VBA_MMX@
 +-VisualBoyAdvance_LDFLAGS = `sdl-config --libs`
 ++// VisualBoyAdvance_LDFLAGS = ${SDL_CONFIG}
 + 
 + TestEmu_SOURCES = \
 + 	TestEmu.cpp 2xSaI.cpp pixel.cpp motionblur.cpp admame.cpp \
 diff -urP /usr/ports/emulators/vba/files/patch-ad /usr/ports/custom/vba/files/patch-ad
 --- /usr/ports/emulators/vba/files/patch-ad	Thu Jan  1 01:00:00 1970
 +++ /usr/ports/custom/vba/files/patch-ad	Tue Feb 10 15:31:33 2004
 @@ -0,0 +1,11 @@
 +--- src/Makefile.in.orig	Sun Feb  1 16:00:50 2004
 ++++ src/Makefile.in	Tue Feb 10 15:03:46 2004
 +@@ -157,7 +157,7 @@
 + 
 + 
 + VisualBoyAdvance_LDADD = gb/libgb.a @VBA_PROF@ @VBA_MMX@
 +-VisualBoyAdvance_LDFLAGS = `sdl-config --libs`
 ++// VisualBoyAdvance_LDFLAGS = ${SDL_CONFIG}
 + 
 + TestEmu_SOURCES = \
 + 	TestEmu.cpp 2xSaI.cpp pixel.cpp motionblur.cpp admame.cpp \
 diff -urP /usr/ports/emulators/vba/pkg-descr /usr/ports/custom/vba/pkg-descr
 --- /usr/ports/emulators/vba/pkg-descr	Fri Oct  3 15:07:59 2003
 +++ /usr/ports/custom/vba/pkg-descr	Tue Feb 10 16:06:00 2004
 @@ -1,21 +1,19 @@
 -- configurable GB/GBA keys, including joystick support
 +VisualBoyAdvance is an emulator for Nintendo's Gameboy Advance. It also
 +supports emulation of the Gameboy (classic), Gameboy Pocket, Gameboy Color
 +and Gameboy Advance SP.
 +Some of the main features are:
 +
  - option to use BIOS file
  - zip/gzip file support
 -- directory selection for save state, battery and screen capture
 -- fullscreen mode (selectable resolution)
 -- video sizes 1x, 2x, 3x and 4x
  - graphic filters Normal, TV Mode, 2xSaI, Super 2xSaI and more
  - interframe blending support
 -- same emulation core as VisualBoyAdvance: GB and GBA emulation
  - built-in ARM/THUMB assembly debugger
  - 10 save states accesible through keyboard
  - automatic battery file load/save
  - auto-fire support
 -- pause, reset through keyboard
  - 16, 24 and 32 bit desktop support
  - GDB remote debugging (see below for information)
 -- auto frameskipping and throttle
  - AGBPrint support for development
  - RTC support
  
 -WWW:  http://vboy.emuhq.com/
 +WWW: http://vba.ngemu.com/
 diff -urP /usr/ports/emulators/vba/pkg-plist /usr/ports/custom/vba/pkg-plist
 --- /usr/ports/emulators/vba/pkg-plist	Sat Jan 24 04:56:40 2004
 +++ /usr/ports/custom/vba/pkg-plist	Tue Feb 10 15:39:24 2004
 @@ -1,7 +1,9 @@
  bin/VisualBoyAdvance
 -bin/VisualBoyAdvance.cfg
 +bin/TestEmu
  %%PORTDOCS%%%%DOCSDIR%%/COPYING
  %%PORTDOCS%%%%DOCSDIR%%/AUTHORS
  %%PORTDOCS%%%%DOCSDIR%%/NEWS
  %%PORTDOCS%%%%DOCSDIR%%/README
 +%%PORTDOCS%%%%DOCSDIR%%/ChangeLog
 +%%PORTDOCS%%%%DOCSDIR%%/INSTALL
  @dirrm share/doc/vba
 --- output ends here ---
 
State-Changed-From-To: feedback->closed 
State-Changed-By: linimon 
State-Changed-When: Tue Feb 17 02:06:32 PST 2004 
State-Changed-Why:  
Committed, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=62645 
>Unformatted:
