From mat@aragorn.reaumur.absolight.net  Fri Feb  6 04:27:38 2004
Return-Path: <mat@aragorn.reaumur.absolight.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9052B16A4CE; Fri,  6 Feb 2004 04:27:38 -0800 (PST)
Received: from aragorn.reaumur.absolight.net (ATuileries-107-2-1-195.w217-128.abo.wanadoo.fr [217.128.120.195])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id CBC9443D5F; Fri,  6 Feb 2004 04:27:18 -0800 (PST)
	(envelope-from mat@aragorn.reaumur.absolight.net)
Received: by aragorn.reaumur.absolight.net (Postfix, from userid 1000)
	id 87257827A; Fri,  6 Feb 2004 13:27:14 +0100 (CET)
Message-Id: <20040206122714.87257827A@aragorn.reaumur.absolight.net>
Date: Fri,  6 Feb 2004 13:27:14 +0100 (CET)
From: Mathieu Arnold <mat@FreeBSD.org>
Reply-To: Mathieu Arnold <mat@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: mat@FreeBSD.org
Subject: devel/p5-Module-Build should use PERL_MODBUILD but can't
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         62422
>Category:       ports
>Synopsis:       [patch] devel/p5-Module-Build should use PERL_MODBUILD but can't
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    portmgr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Feb 06 04:30:10 PST 2004
>Closed-Date:    Thu Apr 01 23:35:27 PST 2004
>Last-Modified:  Thu Apr 01 23:35:27 PST 2004
>Originator:     Mathieu Arnold
>Release:        FreeBSD 4.8-RELEASE i386
>Organization:
Absolight
>Environment:
System: FreeBSD aragorn.reaumur.absolight.net 4.8-RELEASE FreeBSD 4.8-RELEASE #0: Wed Sep 3 12:54:37 CEST 2003 root@aragorn.reaumur.absolight.net:/usr/src/sys/compile/ARAGORN i386

>Description:
devel/p5-Module-Build use itself to build, and needs to use PERL_MODBUILD to
build, but it can't because using PERL_MODBUILD always adds
devel/p5-Module-Build to the dependency list.

The other way is to dupplicate the code enabled by PERL_MODBUILD in
devel/p5-Module-Build Makefile
>How-To-Repeat:
>Fix:

This tests if it's building devel/p5-Module-Build, and if it is, does not add
the dependency.

--- m-b.diff begins here ---
Index: bsd.port.mk
===================================================================
RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.484
diff -u -u -r1.484 bsd.port.mk
--- bsd.port.mk	4 Feb 2004 04:27:04 -0000	1.484
+++ bsd.port.mk	6 Feb 2004 12:21:53 -0000
@@ -1733,7 +1733,9 @@
 .if defined(PERL_MODBUILD)
 PERL_CONFIGURE=		yes
 CONFIGURE_SCRIPT?=	Build.PL
+.if ${PORTNAME} != Module-Build
 BUILD_DEPENDS+=		${SITE_PERL}/Module/Build.pm:${PORTSDIR}/devel/p5-Module-Build
+.endif
 ALL_TARGET?=
 PL_BUILD?=		Build
 CONFIGURE_ARGS+= \
--- m-b.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->portmgr 
Responsible-Changed-By: mat 
Responsible-Changed-When: Fri Feb 6 04:35:42 PST 2004 
Responsible-Changed-Why:  
portmgr territory 

http://www.freebsd.org/cgi/query-pr.cgi?pr=62422 

From: Mathieu Arnold <mat@FreeBSD.org>
To: FreeBSD-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: ports/62422: devel/p5-Module-Build should use PERL_MODBUILD
 but	can't
Date: Fri, 06 Feb 2004 14:06:13 +0100

 --==========098AC463562808DC8BE6==========
 Content-Type: text/plain; charset=us-ascii
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 
 Attached is another needed patch, as there is no Makefile created by
 Build.PL, there is no need to try to edit it.
 
 -- 
 Mathieu Arnold
 --==========098AC463562808DC8BE6==========
 Content-Type: text/plain; name="m-b.diff"
 
 Index: bsd.port.mk
 ===================================================================
 RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v
 retrieving revision 1.484
 diff -u -u -r1.484 bsd.port.mk
 --- bsd.port.mk	4 Feb 2004 04:27:04 -0000	1.484
 +++ bsd.port.mk	6 Feb 2004 12:50:22 -0000
 @@ -3350,8 +3351,10 @@
	 @cd ${CONFIGURE_WRKSRC} && \
		 ${SETENV} ${CONFIGURE_ENV} \
		 ${PERL5} ./${CONFIGURE_SCRIPT} ${CONFIGURE_ARGS}
 +.if !defined(PERL_MODBUILD)
	 @cd ${CONFIGURE_WRKSRC} && \
		 ${PERL5} -pi -e 's/ doc_(perl|site|\$$\(INSTALLDIRS\))_install$$//' Makefile
 +.endif
  .endif
  .if defined(USE_IMAKE)
	 @(cd ${CONFIGURE_WRKSRC}; ${SETENV} ${MAKE_ENV} ${XMKMF})
 
 --==========098AC463562808DC8BE6==========
 Content-Type: text/plain; charset=us-ascii
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 _______________________________________________
 freebsd-ports-bugs@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
 To unsubscribe, send any mail to "freebsd-ports-bugs-unsubscribe@freebsd.org"
 
 --==========098AC463562808DC8BE6==========--
 
State-Changed-From-To: open->analyzed 
State-Changed-By: kris 
State-Changed-When: Sat Mar 20 18:22:52 PST 2004 
State-Changed-Why:  
Will be tested on the next bento 4-exp run 

http://www.freebsd.org/cgi/query-pr.cgi?pr=62422 

From: Mathieu Arnold <mat@FreeBSD.org>
To: Kris Kennaway <kris@FreeBSD.org>, portmgr@FreeBSD.org,
	gnats <freebsd-gnats-submit@FreeBSD.org>
Cc:  
Subject: Re: ports/62422: [patch] devel/p5-Module-Build should use
 PERL_MODBUILD but can't
Date: Sun, 21 Mar 2004 07:08:29 +0100

 --==========EBF68C409680DA378888==========
 Content-Type: text/plain; charset=us-ascii
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 +-Le 20/03/2004 18:23 -0800, Kris Kennaway a dit :
 | Synopsis: [patch] devel/p5-Module-Build should use PERL_MODBUILD but can't
 | 
 | State-Changed-From-To: open->analyzed
 | State-Changed-By: kris
 | State-Changed-When: Sat Mar 20 18:22:52 PST 2004
 | State-Changed-Why: 
 | Will be tested on the next bento 4-exp run
 | 
 | http://www.freebsd.org/cgi/query-pr.cgi?pr=62422
 | 
 
 Just to be sure all is taken, there are two different pieces of patch in
 this, and they address two different matters, both are needed :-)
 
 If you need to test this for real on the 4-exp run, you'd want to patch the
 ports/devel/p5-Module-Build/Makefile, remove everything after MAN3 until
 .include bsd.port.pre and replace PERL_CONFIGURE with PERL_MODBUILD
 
 -- 
 Mathieu Arnold
 --==========EBF68C409680DA378888==========
 Content-Type: application/pgp-signature
 Content-Transfer-Encoding: 7bit
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.4 (MingW32)
 
 iQEVAwUBQF0xYFvROjYJ63c1AQIKOQf+Lu9RZAUk5qbMJZV28Zp3CY6ScazjJ6UR
 lt25SbtUftK8Wc+oKD3VGK+SfKz8+M+oVoz3wXvMDD3bTXvt8/RVsg8YMWaxG1ZG
 OaJunv5CrvvycBMnaCB8ATusdvtkYVFdX/jQAhydDzKr2B+Mt7iWz2xVTKT+jDMS
 s9HLHomXakAaEtjleQK7n90aX93YBk8y4brnvvKDMJ0XoK9GCU3QlyYurQL7xBV3
 P7SmitkhA+Tm94oF+hhgi74bnKT1OaGs6CZd2ql9g8WQ2xA2vvGnnrBCcIBx6egR
 1coAYjFErwZ+ErhOB0OxYJIatSOGBIL2J6BXRvFPB8vTfgaCkLOqcg==
 =lcX4
 -----END PGP SIGNATURE-----
 
 --==========EBF68C409680DA378888==========--
 
State-Changed-From-To: analyzed->closed 
State-Changed-By: kris 
State-Changed-When: Thu Apr 1 23:35:21 PST 2004 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=62422 
>Unformatted:
