From girgen@smtp.chello.se  Sun Dec  7 14:52:32 2003
Return-Path: <girgen@smtp.chello.se>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D0FEB16A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  7 Dec 2003 14:52:32 -0800 (PST)
Received: from amsfep14-int.chello.nl (amsfep14-int.chello.nl [213.46.243.22])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8D98F43FE0
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  7 Dec 2003 14:52:30 -0800 (PST)
	(envelope-from girgen@smtp.chello.se)
Received: from palle.girgensohn.se ([213.89.138.245])
          by amsfep14-int.chello.nl
          (InterMail vM.5.01.06.05 201-253-122-130-105-20030824) with ESMTP
          id <20031207225228.QVNP4408.amsfep14-int.chello.nl@palle.girgensohn.se>;
          Sun, 7 Dec 2003 23:52:28 +0100
Received: from palle.girgensohn.se (localhost [127.0.0.1])
	by palle.girgensohn.se (8.12.9p2/8.12.9) with ESMTP id hB7MqSHU070954;
	Sun, 7 Dec 2003 23:52:28 +0100 (CET)
	(envelope-from girgen@palle.girgensohn.se)
Received: (from girgen@localhost)
	by palle.girgensohn.se (8.12.9p2/8.12.9/Submit) id hB7MqR9r070953;
	Sun, 7 Dec 2003 23:52:27 +0100 (CET)
	(envelope-from girgen)
Message-Id: <200312072252.hB7MqR9r070953@palle.girgensohn.se>
Date: Sun, 7 Dec 2003 23:52:27 +0100 (CET)
From: Palle Girgensohn <girgen@pingpong.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc: Dirk Meyer <dirk.meyer@dinoex.sub.org>
Subject: [MAINTAINER] databases/postgresql-libpq++: unbreak header file
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         60027
>Category:       ports
>Synopsis:       [MAINTAINER] databases/postgresql-libpq++: unbreak header file
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    dinoex
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Sun Dec 07 15:00:16 PST 2003
>Closed-Date:    Mon Dec 08 21:44:21 CET 2003
>Last-Modified:  Mon Dec 08 21:44:21 CET 2003
>Originator:     Palle Girgensohn
>Release:        FreeBSD 4.9-RELEASE i386
>Organization:
Ping Pong AB
>Environment:
System: FreeBSD palle.girgensohn.se 4.9-RELEASE FreeBSD 4.9-RELEASE #6: Tue Nov  4 22:56:29 CET
>Description:
DLLIMPORT is not defined anywhere, but is expected in
pgconnection.h. This breaks building stuff using this library, and at
least ports/dns/powerdns is marked broken for this reason.

libpq++ is not really updated much anymore, so I don't expect any new
releas really. I checked the web site, and there was a discussion
about this (not quite accurate, though, does not really apply to
postgresql-7.4):
<http://gborg.postgresql.org/project/libpqpp/bugs/bugupdate.php?410>

Pointed out by: Dirk Meyer <dirk.meyer@dinoex.sub.org>

Generated with FreeBSD Port Tools 0.50
>How-To-Repeat:
>Fix:

remove BROKEN line in dns/powerdns/Makefile :

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/dns/powerdns/Makefile,v
retrieving revision 1.19
diff -u -r1.19 Makefile
--- Makefile	5 Dec 2003 21:22:18 -0000	1.19
+++ Makefile	7 Dec 2003 22:35:37 -0000
@@ -36,7 +36,6 @@
 .endif
 
 .if defined(WITH_POSTGRESQL_DRIVER) && !defined(WITHOUT_POSTGRESQL_DRIVER)
-BROKEN=		does not compile with postgresql 7.4
 LIB_DEPENDS=	pq[+][+].4:${PORTSDIR}/databases/postgresql-libpq++
 CONFIGURE_ARGS+=	--enable-pgsql
 CONFIGURE_MODULES+=	"gpgsql"

----------

And add this patch to databases/postgresql-libpq++, and don't forget
to cvs add the patch file

--- /dev/null	Sun Dec  7 23:36:20 2003
+++ files/patch-pgconnection_h	Sun Dec  7 23:37:22 2003
@@ -0,0 +1,13 @@
+--- pgconnection.h.orig Wed Nov 27 05:46:08 2002
++++ pgconnection.h      Sun Dec  7 23:15:54 2003
+@@ -21,6 +21,10 @@
+ #ifndef PGCONNECTION_H
+ #define PGCONNECTION_H
+ 
++#ifndef DLLIMPORT
++#define DLLIMPORT
++#endif
++
+ #ifdef HAVE_CXX_STRING_HEADER
+ #include <string>
+ #endif
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/databases/postgresql-libpq++/Makefile,v
retrieving revision 1.3
diff -u -r1.3 Makefile
--- Makefile	3 Sep 2003 08:06:18 -0000	1.3
+++ Makefile	7 Dec 2003 22:38:31 -0000
@@ -7,6 +7,7 @@
 
 PORTNAME=	libpq++
 PORTVERSION=	4.0
+PORTREVISION=	1
 CATEGORIES=	databases
 MASTER_SITES=	ftp://gborg.postgresql.org/pub/libpqpp/stable/
 PKGNAMEPREFIX=	postgresql-
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->dinoex 
Responsible-Changed-By: dinoex 
Responsible-Changed-When: Mon Dec 8 04:52:00 CET 2003 
Responsible-Changed-Why:  
I will take care of it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=60027 
State-Changed-From-To: open->closed 
State-Changed-By: dinoex 
State-Changed-When: Mon Dec 8 21:44:00 CET 2003 
State-Changed-Why:  
committed, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=60027 
>Unformatted:
