From jeh@vaio2.int.thehousleys.net  Wed Nov 19 18:25:14 2003
Return-Path: <jeh@vaio2.int.thehousleys.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5B85416A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 19 Nov 2003 18:25:14 -0800 (PST)
Received: from vaio2.int.thehousleys.net (frenchknot.ne.client2.attbi.com [24.62.54.49])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3C5AC43F3F
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 19 Nov 2003 18:25:13 -0800 (PST)
	(envelope-from jeh@vaio2.int.thehousleys.net)
Received: from vaio2.int.thehousleys.net (localhost [127.0.0.1])
	by vaio2.int.thehousleys.net (8.12.9p2/8.12.9) with ESMTP id hAK12BBc076405
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 19 Nov 2003 20:02:11 -0500 (EST)
	(envelope-from jeh@vaio2.int.thehousleys.net)
Received: (from jeh@localhost)
	by vaio2.int.thehousleys.net (8.12.9p2/8.12.9/Submit) id hAK12BYA076404;
	Wed, 19 Nov 2003 20:02:11 -0500 (EST)
	(envelope-from jeh)
Message-Id: <200311200102.hAK12BYA076404@vaio2.int.thehousleys.net>
Date: Wed, 19 Nov 2003 20:02:11 -0500 (EST)
From: James Housley <jeh@vaio2.int.thehousleys.net>
Reply-To: James Housley <jeh@vaio2.int.thehousleys.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: The ports system doesn't or can't honor NO_CPU_CFLAGS
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         59493
>Category:       ports
>Synopsis:       The ports system doesn't or can't honor NO_CPU_CFLAGS
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    portmgr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Nov 19 18:30:14 PST 2003
>Closed-Date:    Tue Jan 20 11:14:42 PST 2004
>Last-Modified:  Tue Jan 20 11:14:42 PST 2004
>Originator:     James Housley
>Release:        FreeBSD 4.9-RELEASE i386
>Organization:
>Environment:
System: FreeBSD vaio2.int.thehousleys.net 4.9-RELEASE FreeBSD 4.9-RELEASE #20: Mon Oct 27 08:48:54 EST 2003 root@cat.int.thehousleys.net:/usr/obj/usr/src/sys/VAIOKERNEL i386


	
>Description:
	It is not possible to set NO_CPU_CFLAGS in a ports makefile
	and not have -mcpu or -march in the CFLAGS if NO_CPU_CFLAGS 
	is not specified in /etc/make.conf.  I believe this is 
	becuase they have already been added before the ports makefile
	and Mk/* files are parsed.
>How-To-Repeat:
	
>Fix:

	

--- diff.txt begins here ---
Index: bsd.port.mk
===================================================================
RCS file: /usr/FREEBSD_CVS/ports/Mk/bsd.port.mk,v
retrieving revision 1.473
diff -u -r1.473 bsd.port.mk
--- bsd.port.mk	8 Nov 2003 03:22:08 -0000	1.473
+++ bsd.port.mk	20 Nov 2003 00:56:56 -0000
@@ -1179,6 +1179,10 @@
 
 PLIST_SUB+=	OSREL=${OSREL} PREFIX=%D LOCALBASE=${LOCALBASE} X11BASE=${X11BASE}
 
+.if defined(NO_CPU_CFLAGS)
+CFLAGS:=	${CFLAGS:C/${_CPUCFLAGS}//}
+.endif
+
 .if defined(NOPORTDOCS)
 PLIST_SUB+=	        PORTDOCS="@comment "
 .else
--- diff.txt ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->portmgr 
Responsible-Changed-By: jeh 
Responsible-Changed-When: Wed Nov 19 18:31:54 PST 2003 
Responsible-Changed-Why:  
Over to portmgr since it is for bsd.port.mk 

http://www.freebsd.org/cgi/query-pr.cgi?pr=59493 

From: Clement Laforet <sheepkiller@cultdeadsheep.org>
To: James Housley <jeh@vaio2.int.thehousleys.net>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/59493: The ports system doesn't or can't honor
 NO_CPU_CFLAGS
Date: Thu, 20 Nov 2003 03:41:23 +0100

 > +.if defined(NO_CPU_CFLAGS)
 > +CFLAGS:=	${CFLAGS:C/${_CPUCFLAGS}//}
 > +.endif
 > +
 
 you should use something like WITHOUT_CPU_CFLAGS to avoid confusion...
 
 my 2 cents...
 clem
State-Changed-From-To: open->analyzed 
State-Changed-By: marcus 
State-Changed-When: Tue Jan 13 20:09:55 PST 2004 
State-Changed-Why:  
This is currently being tested on bento (with WITHOUT_CPU_CFLAGS). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=59493 
State-Changed-From-To: analyzed->closed 
State-Changed-By: marcus 
State-Changed-When: Tue Jan 20 11:14:30 PST 2004 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=59493 
>Unformatted:
