From undo@undo.chillt.de  Tue Nov 18 00:05:28 2003
Return-Path: <undo@undo.chillt.de>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id EB41616A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 18 Nov 2003 00:05:28 -0800 (PST)
Received: from pollux.chillt.de (dsl-213-023-189-031.arcor-ip.net [213.23.189.31])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 524EA43FDD
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 18 Nov 2003 00:05:27 -0800 (PST)
	(envelope-from undo@undo.chillt.de)
Received: from undo.chillt.de (localhost.chillt.de [127.0.0.1])
	by pollux.chillt.de (8.12.6p3/8.12.3) with ESMTP id hAI87pTh018627
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 18 Nov 2003 09:07:53 +0100 (CET)
	(envelope-from undo@undo.chillt.de)
Received: (from undo@localhost)
	by undo.chillt.de (8.12.10/8.12.10/Submit) id hAI85cB5008477;
	Tue, 18 Nov 2003 21:05:38 +1300 (NZDT)
	(envelope-from undo)
Message-Id: <200311180805.hAI85cB5008477@undo.chillt.de>
Date: Tue, 18 Nov 2003 21:05:38 +1300 (NZDT)
From: Bartosz Fabianowski <bartosz@fabianowski.de>
Reply-To: Bartosz Fabianowski <bartosz@fabianowski.de>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] multimedia/libxine ac3 decoding broken
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         59410
>Category:       ports
>Synopsis:       [PATCH] multimedia/libxine ac3 decoding broken
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    nobutaka
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Nov 18 00:10:04 PST 2003
>Closed-Date:    Wed Nov 26 07:26:16 PST 2003
>Last-Modified:  Wed Nov 26 07:26:16 PST 2003
>Originator:     Bartosz Fabianowski
>Release:        FreeBSD 4.9-STABLE i386
>Organization:
>Environment:
System: FreeBSD undo.chillt.de 4.9-STABLE FreeBSD 4.9-STABLE #1: Sat Nov 1 15:49:21 NZDT 2003 root@undo.chillt.de:/usr/obj/usr/src/sys/UNDO i386

>Description:
The patch file patch-src:liba52:Makefile.in in the port multimedia/libxine is a bit too aggressive on Makefile.in and removes two entries necessary for ac3 decoding in xine to work. The following patch restores those entries and thus, fixes ac3 decoding in xine (and kaffeine). This can be verified by playing a DVD with ac3 sound.

>How-To-Repeat:
Play a DVD with ac3 sound - sound is missing. Alternatively, start xine with a high verbosity level - the ac3 decoder plug-in will fail to load due to an unresolved symbol.

>Fix:
Apply the attached patch to patch-src:liba52:Makefile.in.

--- patch:patch-src:liba52:Makefile.in begins here ---
--- patch-src:liba52:Makefile.in.orig	Tue Nov 18 02:24:41 2003
+++ patch-src:liba52:Makefile.in	Tue Nov 18 02:25:24 2003
@@ -1,18 +1,16 @@
 --- src/liba52/Makefile.in.orig	Sun Nov  9 11:41:01 2003
 +++ src/liba52/Makefile.in	Sun Nov  9 11:46:09 2003
-@@ -254,26 +254,12 @@
- 
+@@ -255,25 +255,13 @@
  lib_LTLIBRARIES = xineplug_decode_a52.la
  
--xineplug_decode_a52_la_SOURCES = \
+ xineplug_decode_a52_la_SOURCES = \
 -	bitstream.c \
 -	bit_allocate.c \
--	crc.c \
+ 	crc.c \
 -	downmix.c \
 -	imdct.c \
 -	parse.c \
--	xine_decoder.c
-+xineplug_decode_a52_la_SOURCES = xine_decoder.c
+ 	xine_decoder.c
  
  
 -xineplug_decode_a52_la_LIBADD = $(XINE_LIB)
@@ -29,13 +27,13 @@
  mkinstalldirs = $(SHELL) $(top_srcdir)/mkinstalldirs
  CONFIG_HEADER = $(top_builddir)/config.h
  CONFIG_CLEAN_FILES =
-@@ -281,8 +267,7 @@
+@@ -281,8 +269,7 @@
  
  xineplug_decode_a52_la_DEPENDENCIES = \
  	$(top_builddir)/src/xine-engine/libxine.la
 -am_xineplug_decode_a52_la_OBJECTS = bitstream.lo bit_allocate.lo crc.lo \
 -	downmix.lo imdct.lo parse.lo xine_decoder.lo
-+am_xineplug_decode_a52_la_OBJECTS = xine_decoder.lo
++am_xineplug_decode_a52_la_OBJECTS = crc.lo xine_decoder.lo
  xineplug_decode_a52_la_OBJECTS = $(am_xineplug_decode_a52_la_OBJECTS)
  
  DEFS = @DEFS@
--- patch:patch-src:liba52:Makefile.in ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->nobutaka 
Responsible-Changed-By: pav 
Responsible-Changed-When: Tue Nov 18 01:00:22 PST 2003 
Responsible-Changed-Why:  
Over to maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=59410 
State-Changed-From-To: open->closed 
State-Changed-By: nobutaka 
State-Changed-When: Wed Nov 26 07:25:37 PST 2003 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=59410 
>Unformatted:
