From kirk@gopher.honeypot.net  Sat Nov 15 20:20:34 2003
Return-Path: <kirk@gopher.honeypot.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4273516A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 15 Nov 2003 20:20:34 -0800 (PST)
Received: from kanga.honeypot.net (kanga.honeypot.net [208.162.254.122])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A44C843F75
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 15 Nov 2003 20:20:32 -0800 (PST)
	(envelope-from kirk@gopher.honeypot.net)
Received: from gopher.honeypot.net (gopher.honeypot.net [10.0.5.2])
	by kanga.honeypot.net (8.12.10/8.12.10) with ESMTP id hAG4KSEX033664
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 15 Nov 2003 22:20:31 -0600 (CST)
	(envelope-from kirk@gopher.honeypot.net)
Received: (from root@localhost)
	by gopher.honeypot.net (8.12.9/8.12.9/Submit) id hAG4KSjp009959;
	Sat, 15 Nov 2003 22:20:28 -0600 (CST)
	(envelope-from kirk)
Message-Id: <200311160420.hAG4KSjp009959@gopher.honeypot.net>
Date: Sat, 15 Nov 2003 22:20:28 -0600 (CST)
From: Kirk Strauser <kirk@strauser.com>
Reply-To: Kirk Strauser <kirk@strauser.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: The misc/amanda-client port is not upgradable since the last commit.
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         59316
>Category:       ports
>Synopsis:       The misc/amanda-client port is not upgradable since the last commit.
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    jeh
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Sat Nov 15 20:30:16 PST 2003
>Closed-Date:    Sun Nov 16 04:32:39 PST 2003
>Last-Modified:  Sun Nov 16 04:32:39 PST 2003
>Originator:     Kirk Strauser <kirk@strauser.com>
>Release:        FreeBSD 4.9-PRERELEASE alpha
>Organization:
The Strauser Group
>Environment:
System: FreeBSD gopher.honeypot.net 4.9-PRERELEASE FreeBSD 4.9-PRERELEASE #0: Fri Sep 12 09:22:21 CDT 2003 root@gopher.honeypot.net:/usr/obj/usr/src/sys/GOPHER alpha


	
>Description:
The fix for the ports/59302 bug report caused some easily-fixable breakage.

A problem listed in that report was that "the server also complains about a
missing /etc/amandates file.", and the commited fix was to
"${MKDIR} /etc/amandates".  Unfortunately, that was supposed to be a file,
not a directory.  Changing that line to "${TOUCH} /etc/amandates" solves
both problems.

Note that this only affects misc/amanda-client and not misc/amanda-server.
	
>How-To-Repeat:
Attempt to portupgrade the misc/amanda-client port.  If the port is already
installed it fails with this message:

    /bin/mkdir -p /usr/local/var/amanda/gnutar-lists
    /usr/sbin/chown operator:operator /usr/local/var/amanda/gnutar-lists
    /bin/mkdir -p /etc/amandates
    mkdir: /etc/amandates: File exists
    *** Error code 1
    
    Stop in /usr/ports/misc/amanda-client.
    *** Error code 1
    
    Stop in /usr/ports/misc/amanda-client.

If the port is not already installed, I think it would complete the
(incorrect) without printing any error messages, but I have not tested
this.
	
>Fix:
	

--- diff begins here ---
diff -urN /usr/ports/misc/amanda-server/Makefile misc/amanda-server/Makefile
--- /usr/ports/misc/amanda-server/Makefile	Sat Nov 15 21:46:25 2003
+++ misc/amanda-server/Makefile	Sat Nov 15 20:51:38 2003
@@ -187,7 +187,7 @@
 		${PREFIX}/share/examples/amanda
 	${MKDIR} ${PREFIX}/var/amanda/gnutar-lists
 	${CHOWN} operator:operator ${PREFIX}/var/amanda/gnutar-lists
-	${MKDIR} /etc/amandates
+	${TOUCH} /etc/amandates
 	${CHOWN} operator:operator /etc/amandates
 
 .if defined (AMANDA_SERVER)
--- diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->jeh 
Responsible-Changed-By: eik 
Responsible-Changed-When: Sun Nov 16 05:58:51 CET 2003 
Responsible-Changed-Why:  
over to the maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=59316 
State-Changed-From-To: open->closed 
State-Changed-By: jeh 
State-Changed-When: Sun Nov 16 04:32:14 PST 2003 
State-Changed-Why:  
Commited, thanks for finding my mistake 

http://www.freebsd.org/cgi/query-pr.cgi?pr=59316 
>Unformatted:
