From michaelnottebrock@gmx.net  Sat Nov 15 12:48:02 2003
Return-Path: <michaelnottebrock@gmx.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DBC0116A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 15 Nov 2003 12:48:02 -0800 (PST)
Received: from meitner.wh.uni-dortmund.de (meitner.wh.Uni-Dortmund.DE [129.217.129.133])
	by mx1.FreeBSD.org (Postfix) with ESMTP id AA35B43F3F
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 15 Nov 2003 12:48:01 -0800 (PST)
	(envelope-from michaelnottebrock@gmx.net)
Received: from lofi.dyndns.org (pc2-105.intern.meitner [10.3.12.105])
	by meitner.wh.uni-dortmund.de (Postfix) with ESMTP
	id 333381675C2; Sat, 15 Nov 2003 21:48:00 +0100 (CET)
Received: from kiste.my.domain (kiste.my.domain [192.168.8.4])
	by lofi.dyndns.org (8.12.9p1/8.12.9) with ESMTP id hAFKlwog031498
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Sat, 15 Nov 2003 21:47:59 +0100 (CET)
	(envelope-from michaelnottebrock@gmx.net)
Received: from kiste.my.domain (localhost [127.0.0.1])
	by kiste.my.domain (8.12.9p2/8.12.9) with ESMTP id hAFKlv5F041379;
	Sat, 15 Nov 2003 21:47:57 +0100 (CET)
	(envelope-from lofi@kiste.my.domain)
Received: (from lofi@localhost)
	by kiste.my.domain (8.12.9p2/8.12.9/Submit) id hAFKll79041373;
	Sat, 15 Nov 2003 21:47:47 +0100 (CET)
	(envelope-from lofi)
Message-Id: <200311152047.hAFKll79041373@kiste.my.domain>
Date: Sat, 15 Nov 2003 21:47:47 +0100 (CET)
From: Michael Nottebrock <lofi@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: flynn@energyhq.es.eu.org
Subject: [patch] multimedia/beep-media-player doesn't compile.
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         59308
>Category:       ports
>Synopsis:       [patch] multimedia/beep-media-player doesn't compile.
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    lofi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Nov 15 12:50:08 PST 2003
>Closed-Date:    Sun Nov 16 10:01:30 PST 2003
>Last-Modified:  Sun Nov 16 10:01:30 PST 2003
>Originator:     Michael Nottebrock
>Release:        FreeBSD 4.9-RELEASE i386
>Organization:
>Environment:
System: FreeBSD kiste 4.9-RELEASE FreeBSD 4.9-RELEASE #0: Mon Nov 10 19:57:19 CET 2003 lofi@vm-kiste:/usr/obj/usr/src/sys/KISTE i386


	
>Description:
	multimedia/beep-media-player bails during link stage on an unknown symbol
	"gtk_treeview_get_row_data" in main.c. I believe the line was left in due to
	an oversight, a similar function call is commented out in the same source file
	earlier.
	>How-To-Repeat:
	<code/input/activities to reproduce the problem (multiple lines)>
>How-To-Repeat:
>Fix:

	

--- beep-media-player.diff begins here ---
Index: files/patch-beep::main.c
===================================================================
RCS file: /home/pcvs/ports/multimedia/beep-media-player/files/patch-beep::main.c,v
retrieving revision 1.1
diff -u -r1.1 patch-beep::main.c
--- files/patch-beep::main.c	15 Nov 2003 02:24:06 -0000	1.1
+++ files/patch-beep::main.c	15 Nov 2003 20:41:53 -0000
@@ -1,5 +1,14 @@
---- beep/main.c.orig	Fri Nov 14 05:29:27 2003
-+++ beep/main.c	Fri Nov 14 05:30:06 2003
+--- beep/main.c.orig	Sat Nov 15 21:33:27 2003
++++ beep/main.c	Sat Nov 15 21:35:22 2003
+@@ -1634,7 +1634,7 @@
+ 
+ 	if (treeview->selection)
+ 	{
+-		pos = gtk_treeview_get_row_data(treeview, GPOINTER_TO_INT(treeview->selection->data));
++//		pos = gtk_treeview_get_row_data(treeview, GPOINTER_TO_INT(treeview->selection->data));
+ 		playlist_queue_position(*pos);
+ 		gtk_widget_set(GTK_WIDGET(widget), "label", playlist_is_position_queued(*pos) ? "Unqueue" : "Queue", NULL);
+ 	}	
 @@ -2030,11 +2030,12 @@
  		
  
--- beep-media-player.diff ends here ---


>Release-Note:
>Audit-Trail:

From: Miguel Mendez <flynn@energyhq.es.eu.org>
To: Michael Nottebrock <michaelnottebrock@gmx.net>
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: ports/59308: [patch] multimedia/beep-media-player doesn't
 compile.
Date: Sun, 16 Nov 2003 17:47:52 +0100

 Dixitur illum
 Michael Nottebrock <michaelnottebrock@gmx.net> scribere:
 
 > On Sunday 16 November 2003 13:26, Miguel Mendez wrote:
 > > Dixitur illum
 > > Michael Nottebrock <lofi@freebsd.org> scribere:
 > >
 > > Is this with the 1.0.0-pre5 version? 
 > 
 > Yes.
 
 Ok, unfortunately I don't have any RELENG_4 box to test it but, if
 you've tested it go ahead and commit.
 
 Cheers,
 -- 
 	Miguel Mendez <flynn@energyhq.es.eu.org>
 	http://www.energyhq.es.eu.org
Responsible-Changed-From-To: freebsd-ports-bugs->mich  
Responsible-Changed-By: krion 
Responsible-Changed-When: Sun Nov 16 08:55:01 PST 2003 
Responsible-Changed-Why:  
Over to originator  

http://www.freebsd.org/cgi/query-pr.cgi?pr=59308 
Responsible-Changed-From-To: mich->lofi  
Responsible-Changed-By: krion 
Responsible-Changed-When: Sun Nov 16 08:55:57 PST 2003 
Responsible-Changed-Why:  
Wrong person, lofi was originator. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=59308 

From: Simon Barner <barner@in.tum.de>
To: Michael Nottebrock <lofi@freebsd.org>
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: ports/59308: [patch] multimedia/beep-media-player doesn't compile.
Date: Sun, 16 Nov 2003 18:38:48 +0100

 --1UWUbFP1cBYEclgG
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 > 	multimedia/beep-media-player bails during link stage on an unknown symbol
 > 	"gtk_treeview_get_row_data" in main.c. I believe the line was left in due to
 > 	an oversight, a similar function call is commented out in the same source file
 > 	earlier.
 
 Strange, I cannot reproduce this on my -STABLE system. I deleted and
 re-CVSup-ed ports/multimedia/beep*, just to be certain that I don't have
 uncommited local changes here.
 
 Perhaps you should try the same?
 
 Simon
 
 --1UWUbFP1cBYEclgG
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: Digital signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.3 (FreeBSD)
 
 iD8DBQE/t7YnCkn+/eutqCoRAltSAKDOeLwEOfH1+9LtHfUKwQRiW8U6IQCfa8Oq
 zBl7J3Nio9EoEDCdy4UhaKw=
 =okgD
 -----END PGP SIGNATURE-----
 
 --1UWUbFP1cBYEclgG--
State-Changed-From-To: open->closed 
State-Changed-By: lofi 
State-Changed-When: Sun Nov 16 10:01:04 PST 2003 
State-Changed-Why:  
Committed, thanks for reviewing! 


http://www.freebsd.org/cgi/query-pr.cgi?pr=59308 
>Unformatted:
