From lee@homer.easthighschool.net  Tue Nov 11 15:48:09 2003
Return-Path: <lee@homer.easthighschool.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6392916A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 11 Nov 2003 15:48:09 -0800 (PST)
Received: from relay01.roc.ny.frontiernet.net (relay01.roc.ny.frontiernet.net [66.133.131.34])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 35DD743FB1
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 11 Nov 2003 15:48:08 -0800 (PST)
	(envelope-from lee@homer.easthighschool.net)
Received: (qmail 21274 invoked from network); 11 Nov 2003 23:48:07 -0000
Received: from unknown (HELO homer) ([208.186.59.185])
          (envelope-sender <lee@homer.easthighschool.net>)
          by relay01.roc.ny.frontiernet.net (FrontierMTA 2.3.6) with SMTP
          for <FreeBSD-gnats-submit@freebsd.org>; 11 Nov 2003 23:48:07 -0000
Received: from homer.easthighschool.net (208-186-59-185.nrp3feld.roc.ny.frontiernet.net [127.0.0.1])
	by homer (8.12.10/8.12.10) with ESMTP id hABNrJUv088479
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 11 Nov 2003 18:53:20 -0500 (EST)
	(envelope-from lee@homer.easthighschool.net)
Received: (from lee@localhost)
	by homer.easthighschool.net (8.12.10/8.12.10/Submit) id hABNrJ8c088478;
	Tue, 11 Nov 2003 18:53:19 -0500 (EST)
	(envelope-from lee)
Message-Id: <200311112353.hABNrJ8c088478@homer.easthighschool.net>
Date: Tue, 11 Nov 2003 18:53:19 -0500 (EST)
From: Lee Harr <lee@homer.easthighschool.net>
Reply-To: Lee Harr <missive@hotmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: xgalaga no keyboard control under kde
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         59195
>Category:       ports
>Synopsis:       xgalaga no keyboard control under kde
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pav
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Nov 11 15:50:19 PST 2003
>Closed-Date:    Sat Nov 15 16:42:22 PST 2003
>Last-Modified:  Sat Nov 15 16:42:22 PST 2003
>Originator:     Lee Harr
>Release:        FreeBSD 4.9-STABLE i386
>Organization:
>Environment:
System: FreeBSD homer.easthighschool.net 4.9-STABLE FreeBSD 4.9-STABLE #2: Thu Oct 30 23:32:22 EST 2003 lee@homer:/mnt2/obj/mnt2/src/sys/HOMER i386
KDE-3.1.4

	
>Description:
Running xgalaga when in KDE there is no keyboard control
(and also no way to get mouse control to work, since the
keyboard does not work).

Works fine under twm.


	
>How-To-Repeat:
Log in to KDE, run xgalaga. Space bar should fire, but it does not.


	
>Fix:
The key values are being passed back in to xgalaga 256 higher
than it expects. This patch corrects the problem, so that the
game runs correctly under both kde and twm:

--- main.c.orig Mon May 11 02:52:59 1998
+++ main.c      Mon Nov 10 23:10:55 2003
@@ -779,6 +779,7 @@
     if(gameOver) {
         while(W_EventsPending()) {
             W_NextEvent(&wev);
+            if (wev.key >= 256) wev.key -= 256;

            if(gameOver)
              mouseControl = 1;
@@ -826,6 +827,7 @@

     while(W_EventsPending()) {
         W_NextEvent(&wev);
+        if (wev.key >= 256) wev.key -= 256;

         switch(wev.type) {
         case W_EV_KEY_OFF:



	


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->pav 
Responsible-Changed-By: pav 
Responsible-Changed-When: Sat Nov 15 10:37:21 PST 2003 
Responsible-Changed-Why:  
I'll take this one. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=59195 
State-Changed-From-To: open->closed 
State-Changed-By: pav 
State-Changed-When: Sat Nov 15 16:41:57 PST 2003 
State-Changed-Why:  
Committed, thanks. Good catch! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=59195 
>Unformatted:
