From sa264@cam.ac.uk  Tue Oct 21 09:16:31 2003
Return-Path: <sa264@cam.ac.uk>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B78FA16A4B3
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 21 Oct 2003 09:16:31 -0700 (PDT)
Received: from rose.csi.cam.ac.uk (rose.csi.cam.ac.uk [131.111.8.13])
	by mx1.FreeBSD.org (Postfix) with ESMTP id BF7EE43FBD
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 21 Oct 2003 09:16:30 -0700 (PDT)
	(envelope-from sa264@cam.ac.uk)
Received: from m218-3.phy.cam.ac.uk ([131.111.79.217])
	by rose.csi.cam.ac.uk with esmtp (Exim 4.20)
	id 1ABzB8-00006l-K6; Tue, 21 Oct 2003 17:16:14 +0100
Received: from sa264 by m218-3.phy.cam.ac.uk with local (Exim 4.24; FreeBSD 4.9)
	id 1ABzB8-0002LG-Fs; Tue, 21 Oct 2003 17:16:14 +0100
Message-Id: <E1ABzB8-0002LG-Fs@m218-3.phy.cam.ac.uk>
Date: Tue, 21 Oct 2003 17:16:14 +0100
From: AMAKAWA Shuhei <sa264@cam.ac.uk>
Sender: AMAKAWA Shuhei <sa264@cam.ac.uk>
Reply-To: AMAKAWA Shuhei <sa264@cam.ac.uk>
To: FreeBSD-gnats-submit@freebsd.org
Cc: sa264@cam.ac.uk
Subject: [supersedes ports/58142] Make science/mpb actually useful
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         58337
>Category:       ports
>Synopsis:       [supersedes ports/58142] Make science/mpb actually useful
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 21 09:20:08 PDT 2003
>Closed-Date:    Sat Dec 06 17:12:44 PST 2003
>Last-Modified:  Sat Dec 06 17:12:44 PST 2003
>Originator:     AMAKAWA Shuhei
>Release:        FreeBSD 4.9-RC i386
>Organization:
>Environment:
System: FreeBSD m218-3.phy.cam.ac.uk 4.9-RC FreeBSD 4.9-RC #1: Fri Oct 17 00:12:38 BST 2003 sa264@m218-3.phy.cam.ac.uk:/usr/obj/usr/src/sys/KERNCONF i386


	
>Description:

Make science/mpb has been pretty much useless because it wasn't
correctly linked with hdf5 as it appears in the Makefile.  Now this
is properly done by linking pthread lib too, which is required by
hdf5.  Also, correctly link with ATLAS version of LAPACK.

Please close ports/58142.

>How-To-Repeat:
	
>Fix:

	


diff -uNr /usr/ports/science/mpb/Makefile mpb/Makefile
--- /usr/ports/science/mpb/Makefile	Wed May  7 22:00:42 2003
+++ mpb/Makefile	Tue Oct 21 11:50:23 2003
@@ -14,19 +14,23 @@
 MAINTAINER=	ports@FreeBSD.org
 COMMENT=	MIT Photonic-Bands
 
+USE_REINPLACE=	yes
 BUILD_DEPENDS=	${LOCALBASE}/lib/libctl.a:${PORTSDIR}/science/libctl \
 		bash:${PORTSDIR}/shells/bash2
-LIB_DEPENDS=	blas.1:${PORTSDIR}/math/blas \
-		lapack.3:${PORTSDIR}/math/lapack \
-		atlas.1:${PORTSDIR}/math/atlas \
+LIB_DEPENDS=	atlas.1:${PORTSDIR}/math/atlas \
 		fftw.2:${PORTSDIR}/math/fftw \
 		hdf5.0:${PORTSDIR}/graphics/hdf5 \
 		guile.15:${PORTSDIR}/lang/guile
 
 GNU_CONFIGURE=	yes
-CONFIGURE_ENV=	CPPFLAGS="${CXXFLAGS} -I${LOCALBASE}/include" \
+CONFIGURE_ENV=	CPPFLAGS="${CPPFLAGS} -I${LOCALBASE}/include" \
 		LDFLAGS="-L${LOCALBASE}/lib"
+CONFIGURE_ARGS+=	--with-lapack=-lalapack
 
 MAN1=	mpb.1 mpb-data.1 mpb-split.1
+
+post-patch:
+	@${REINPLACE_CMD} -e 's|-lhdf5 |-lhdf5 ${PTHREAD_LIBS} |g' \
+		${WRKSRC}/configure
 
 .include <bsd.port.mk>
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: pav 
State-Changed-When: Sat Dec 6 17:12:36 PST 2003 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=58337 
>Unformatted:
