From root@helo.liwing.de  Sun Oct  5 01:22:18 2003
Return-Path: <root@helo.liwing.de>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4B42916A4BF; Sun,  5 Oct 2003 01:22:01 -0700 (PDT)
Received: from helo.liwing.de (helo.liwing.de [213.70.188.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 220F143FE9; Sun,  5 Oct 2003 01:22:00 -0700 (PDT)
	(envelope-from root@helo.liwing.de)
Received: from helo.liwing.de (localhost.liwing.de [127.0.0.1])
	by helo.liwing.de (8.12.9p2/8.12.9) with ESMTP id h958LAUn030769;
	Sun, 5 Oct 2003 08:21:10 GMT
	(envelope-from root@helo.liwing.de)
Received: (from root@localhost)
	by helo.liwing.de (8.12.9p2/8.12.9/Submit) id h958L76M030768;
	Sun, 5 Oct 2003 08:21:07 GMT
	(envelope-from root)
Message-Id: <200310050821.h958L76M030768@helo.liwing.de>
Date: Sun, 5 Oct 2003 08:21:07 GMT
From: Jens Rehsack <rehsack@liwing.de>
Reply-To: Jens Rehsack <rehsack@liwing.de>
To: FreeBSD-gnats-submit@freebsd.org
Cc: Jens Rehsack <rehsack@liwing.de>,
	Alex Dupre <sysadmin@alexdupre.com>, nork@freebsd.org,
	Oliver Eikemeier <eikemeier@fillmore-labs.com>
Subject: [PATCH] Fix port bug found by Oliver Eikmeier in PR ports/57502
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         57601
>Category:       ports
>Synopsis:       [PATCH] Fix port bug found by Oliver Eikmeier in PR ports/57502
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Oct 05 01:30:29 PDT 2003
>Closed-Date:    Sun Nov 16 04:59:54 PST 2003
>Last-Modified:  Sun Nov 16 04:59:54 PST 2003
>Originator:     Jens Rehsack
>Release:        FreeBSD 5.1-CURRENT i386
>Organization:
LiWing IT-Services
>Environment:
System: FreeBSD statler 5.1-CURRENT FreeBSD 5.1-CURRENT #0: Thu Oct 2 19:33:40 GMT 2003 root@statler:/usr/obj/usr/src/sys/STATLER i386


	
>Description:
	Move the .include <bsd.port.pre.mk> down as far as possible :-)
>How-To-Repeat:
	
>Fix:

	

--- patch-include-bsd.port.pre.mk begins here ---
--- lang/php4/Makefile.orig	Sun Oct  5 07:59:49 2003
+++ lang/php4/Makefile	Sun Oct  5 08:02:43 2003
@@ -142,12 +142,6 @@
 IS_INTERACTIVE=	yes
 .endif
 
-.include <bsd.port.pre.mk>
-
-.if ${OSVERSION} < 400014 || defined(WITHOUT_IPV6)
-CONFIGURE_ARGS+=--disable-ipv6
-.endif
-
 .if !defined(WITHOUT_APACHE)
 .if exists(${LOCALBASE}/include/apache2/apr.h)
 WITH_APACHE2=	yes
@@ -439,15 +433,6 @@
 CONFIGURE_ARGS+=--with-ldap=${LOCALBASE}
 .endif
 
-.if defined(WITH_OPENSSL) || defined(WITH_OPENSSL_DEP)
-.include "${PORTSDIR}/Mk/bsd.openssl.mk"
-CONFIGURE_ARGS+=--with-openssl-dir=${OPENSSLBASE}
-.endif
-
-.if defined(WITH_OPENSSL)
-CONFIGURE_ARGS+=--with-openssl=${OPENSSLBASE}
-.endif
-
 .if defined(WITH_ORACLE)
 BUILD_DEPENDS+=	${LOCALBASE}/oracle7/lib/libcore3.a:${PORTSDIR}/databases/oracle7-client
 RUN_DEPENDS+=	${LOCALBASE}/oracle7/lib/libcore3.a:${PORTSDIR}/databases/oracle7-client
@@ -579,6 +564,21 @@
 
 .if defined(WITH_ZLIB)
 CONFIGURE_ARGS+=--with-zlib=yes
+.endif
+
+.include <bsd.port.pre.mk>
+
+.if ${OSVERSION} < 400014 || defined(WITHOUT_IPV6)
+CONFIGURE_ARGS+=--disable-ipv6
+.endif
+
+.if defined(WITH_OPENSSL) || defined(WITH_OPENSSL_DEP)
+.include "${PORTSDIR}/Mk/bsd.openssl.mk"
+CONFIGURE_ARGS+=--with-openssl-dir=${OPENSSLBASE}
+.endif
+
+.if defined(WITH_OPENSSL)
+CONFIGURE_ARGS+=--with-openssl=${OPENSSLBASE}
 .endif
 
 pre-patch:
--- lang/php5/Makefile.orig	Sun Oct  5 08:10:55 2003
+++ lang/php5/Makefile	Sun Oct  5 08:12:11 2003
@@ -140,12 +140,6 @@
 IS_INTERACTIVE=	yes
 .endif
 
-.include <bsd.port.pre.mk>
-
-.if ${OSVERSION} < 400014 || defined(WITHOUT_IPV6)
-CONFIGURE_ARGS+=--disable-ipv6
-.endif
-
 .if !defined(WITHOUT_APACHE)
 .if exists(${LOCALBASE}/include/apache2/apr.h)
 WITH_APACHE2=	yes
@@ -421,15 +415,6 @@
 CONFIGURE_ARGS+=--with-ldap=${LOCALBASE}
 .endif
 
-.if defined(WITH_OPENSSL) || defined(WITH_OPENSSL_DEP)
-.include "${PORTSDIR}/Mk/bsd.openssl.mk"
-CONFIGURE_ARGS+=--with-openssl-dir=${OPENSSLBASE}
-.endif
-
-.if defined(WITH_OPENSSL)
-CONFIGURE_ARGS+=--with-openssl=${OPENSSLBASE}
-.endif
-
 .if defined(WITH_ORACLE)
 BUILD_DEPENDS+=	${LOCALBASE}/oracle7/lib/libcore3.a:${PORTSDIR}/databases/oracle7-client
 RUN_DEPENDS+=	${LOCALBASE}/oracle7/lib/libcore3.a:${PORTSDIR}/databases/oracle7-client
@@ -566,6 +551,21 @@
 
 .if defined(WITH_ZLIB)
 CONFIGURE_ARGS+=--with-zlib
+.endif
+
+.include <bsd.port.pre.mk>
+
+.if ${OSVERSION} < 400014 || defined(WITHOUT_IPV6)
+CONFIGURE_ARGS+=--disable-ipv6
+.endif
+
+.if defined(WITH_OPENSSL) || defined(WITH_OPENSSL_DEP)
+.include "${PORTSDIR}/Mk/bsd.openssl.mk"
+CONFIGURE_ARGS+=--with-openssl-dir=${OPENSSLBASE}
+.endif
+
+.if defined(WITH_OPENSSL)
+CONFIGURE_ARGS+=--with-openssl=${OPENSSLBASE}
 .endif
 
 pre-patch:
--- patch-include-bsd.port.pre.mk ends here ---


>Release-Note:
>Audit-Trail:

From: Jens Rehsack <rehsack@liwing.de>
To: freebsd-gnats-submit@FreeBSD.org, rehsack@liwing.de
Cc: Alex Dupre <sysadmin@alexdupre.com>,
	Oliver Eikemeier <eikemeier@fillmore-labs.com>, nork@freebsd.org
Subject: Re: ports/57601: [PATCH] Fix port bug found by Oliver Eikmeier in
 PR ports/57502
Date: Sun, 05 Oct 2003 11:32:15 +0000

 Alex Dupre wrote:
  > This doesn't seem correct to me...I'm working on it.
 
 Can you tell me, why?
 
 IP6-Checking must be after include bsd.port.pre.mk as
 well as include $PORTSDIR/security/openssl/...
 
 All others seems not to need an include.
 
 If you can point me your oppinion more detailed,
 I can make it next time better :-)
 
 Best regards,
 Jens
 

From: Alex Dupre <sysadmin@alexdupre.com>
To: Jens Rehsack <rehsack@liwing.de>
Cc: freebsd-gnats-submit@FreeBSD.org,
	Oliver Eikemeier <eikemeier@fillmore-labs.com>, <nork@FreeBSD.org>
Subject: Re: ports/57601: [PATCH] Fix port bug found by Oliver Eikmeier in PR ports/57502
Date: Sun, 5 Oct 2003 13:53:19 +0200

 Sunday, October 5, 2003, 1:32:15 PM, you wrote:
 
 JR> Can you tell me, why?
 
 ipv6/bzip2/ncurses checks must be after include.port.pre.mk
 apache2 check must be after include.port.pre.mk
 use_openldap/use_mysql must be before include.port.pre.mk
 openssl can be before (use_openssl) or after (include
 $PORTSDIR/Mk/bsd.openssl.mk)
 
 -- 
 Alex Dupre                             sysadmin@alexdupre.com
 http://www.alexdupre.com/              alex@sm.FreeBSD.org
 
 Today's excuse: We are currently trying a new concept of using a live mouse.  Unfortunately, one has yet to survive being hooked up to the computer.....please bear with us.
 
 
State-Changed-From-To: open->feedback 
State-Changed-By: eik 
State-Changed-When: Sat Nov 15 09:57:58 PST 2003 
State-Changed-Why:  
May be closed? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=57601 

From: Oliver Eikemeier <eikemeier@fillmore-labs.com>
To: freebsd-gnats-submit@FreeBSD.org, rehsack@liwing.de
Cc:  
Subject: Re: ports/57601: [PATCH] Fix port bug found by Oliver Eikmeier in
 PR ports/57502
Date: Sat, 15 Nov 2003 18:51:43 +0100

 The requirement on USE_OPENLDAP have been relaxed
 due to the commit of PR 57529.
 
 Any objections to close this PR?
 

From: Jens Rehsack <rehsack@liwing.de>
To: freebsd-gnats-submit@FreeBSD.org, rehsack@liwing.de,
	Oliver Eikemeier <eik@FreeBSD.org>
Cc:  
Subject: Re: ports/57601: [PATCH] Fix port bug found by Oliver Eikmeier in
 PR ports/57502
Date: Sun, 16 Nov 2003 11:11:18 +0000

 > Synopsis: [PATCH] Fix port bug found by Oliver Eikmeier in PR ports/57502
 > 
 > State-Changed-From-To: open->feedback
 > State-Changed-By: eik
 > State-Changed-When: Sat Nov 15 09:57:58 PST 2003
 > State-Changed-Why: 
 > May be closed?
 
 Yes. I thought it was already, because lang/php4 uses ldap fine
 since some time. Thanks for notifying :-)
 
 Regards,
 Jens
 
State-Changed-From-To: feedback->closed 
State-Changed-By: eik 
State-Changed-When: Sun Nov 16 13:59:21 CET 2003 
State-Changed-Why:  
Fixed by the commit of PR 57529. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=57601 
>Unformatted:
