From eikemeier@fillmore-labs.com  Thu Oct  2 09:31:58 2003
Return-Path: <eikemeier@fillmore-labs.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3116D16A4B3
	for <FreeBSD-gnats-submit@FreeBSD.org>; Thu,  2 Oct 2003 09:31:58 -0700 (PDT)
Received: from mx2.fillmore-labs.com (lima.fillmore-labs.com [62.138.193.83])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2CDE443FE1
	for <FreeBSD-gnats-submit@FreeBSD.org>; Thu,  2 Oct 2003 09:31:57 -0700 (PDT)
	(envelope-from eikemeier@fillmore-labs.com)
Received: from pd958a54a.dip.t-dialin.net
	([217.88.165.74] helo=fillmore-labs.com ident=qs2p64pq3ido6doe)
	by mx2.fillmore-labs.com with asmtp (TLSv1:AES256-SHA:256)
	(Exim 4.24; FreeBSD 4.9)
	id 1A56Mu-00054s-05
	for FreeBSD-gnats-submit@FreeBSD.org; Thu, 02 Oct 2003 18:31:56 +0200
Message-Id: <3F7C52F9.40201@fillmore-labs.com>
Date: Thu, 02 Oct 2003 18:31:53 +0200
From: Oliver Eikemeier <eikemeier@fillmore-labs.com>
To: FreeBSD-gnats-submit@FreeBSD.org
Subject: ports that define USE_* too late

>Number:         57502
>Category:       ports
>Synopsis:       ports that define USE_* too late
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    tmclaugh
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Oct 02 09:40:18 PDT 2003
>Closed-Date:    Fri Apr 18 02:31:02 UTC 2008
>Last-Modified:  Fri Apr 18 02:40:02 UTC 2008
>Originator:     Oliver Eikemeier
>Release:        FreeBSD 4.8-STABLE i386
>Organization:
Fillmore Labs - http://www.fillmore-labs.com
>Environment:
System: FreeBSD nuuk.fillmore-labs.com 4.8-STABLE

>Description:

Multiple ports define USE_* variables that are tested in bsd.port.pre.mk
*after* they include bsd.port.pre.mk, which results in that that directive
being ignored. The proposed patch in PR 57496 will (purposely) break these
ports.

The following ports are affected:

* USE_IMAKE:

desmo@bandwidth.org
- x11-clocks/xalarm

jmz@FreeBSD.org
- x11/xgrab


* USE_OPENSSL:

arved@FreeBSD.org
- irc/bitchx

clive@FreeBSD.org
- chinese/bitchx

DougB@FreeBSD.org
- dns/bind9 (PR 57495)

jim@FreeBSD.org
- irc/xchat

jylefort@brutele.be
- mail/sylpheed-gtk2

knu@FreeBSD.org
- japanese/xchat

marcus@FreeBSD.org
- net/net-snmp4

oliver@FreeBSD.org
- mail/sylpheed

sheepkiller@cultdeadsheep.org
- dns/bind9-sdb-mysql

sysadmin@alexdupre.com
- databases/mysql40-client
- databases/mysql40-server
- databases/mysql41-client
- databases/mysql41-server


* USE_OPENLDAP:

asa@gascom.ru   
- lang/php4-nms

gnome@FreeBSD.org
- databases/libgda2

sysadmin@alexdupre.com
- lang/php4
- lang/php4-cli
- lang/php5
- lang/php5-cli
- www/mod_php4 (PR 57491)
- www/mod_php5
- www/php4-cgi
- www/php5-cgi

thierry@pompo.net
- lang/php4-horde


* USE_X_PREFIX:

3d@freebsd.org
- games/linux-q3ademo

cyrille.lefevre@laposte.net
- textproc/docbook-to-man

goto@snowy.to
- irc/ircatlite

jeremy@external.org
- sysutils/ipsc

ports@FreeBSD.org
- x11-toolkits/viewklass


>How-To-Repeat:
>Fix:

move .include <bsd.port.pre.mk> down as far as possible, or move the
respective USE_* definition up.


>Release-Note:
>Audit-Trail:

From: Clement Laforet <sheepkiller@cultdeadsheep.org>
To: FreeBSD-gnats-submit@FreeBSD.org,
	Oliver Eikemeier <eikemeier@fillmore-labs.com>
Cc:  
Subject: Re: ports/57502: ports that define USE_* too late
Date: Thu, 2 Oct 2003 18:54:32 +0200

 On Thu, 02 Oct 2003 18:31:53 +0200
 Oliver Eikemeier <eikemeier@fillmore-labs.com> wrote:
 
 
 Hi Oliver !!
 
 Thank you for the notification :)
 Great job too :)
 
 I'll fix it tomorrow,
 
 regards,
 clem

From: Doug Barton <DougB@FreeBSD.org>
To: FreeBSD-gnats-submit@FreeBSD.org,
	Oliver Eikemeier <eikemeier@fillmore-labs.com>
Cc: FreeBSD Ports <ports@freebsd.org>
Subject: Re: ports/57502: ports that define USE_* too late
Date: Thu, 2 Oct 2003 12:21:30 -0700 (PDT)

 On Thu, 2 Oct 2003, Oliver Eikemeier wrote:
 
 > * USE_OPENSSL:
 >
 > DougB@FreeBSD.org
 > - dns/bind9 (PR 57495)
 
 Fixed.
 
 -- 
 
     This .signature sanitized for your protection
 

From: Oliver Eikemeier <eikemeier@fillmore-labs.com>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: ports/57502: ports that define USE_* too late
Date: Fri, 03 Oct 2003 14:56:06 +0200

 A patch that for bsd.port.mk that fixes the ports
 listed under USE_OPENLDAP is in PR 57529.
 

From: Oliver Eikemeier <eikemeier@fillmore-labs.com>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: ports/57502: ports that define USE_* too late
Date: Fri, 03 Oct 2003 15:07:05 +0200

 Oliver Eikemeier wrote:
 
 > A patch that for bsd.port.mk that fixes the ports
 > listed under USE_OPENLDAP is in PR 57529.
 
 Strong am I with the Source, but not that strong...
 

From: Oliver Eikemeier <eikemeier@fillmore-labs.com>
To: FreeBSD-gnats-submit@FreeBSD.org
Cc: 3d@freebsd.org, avleeuwen@piwebs.com,
	brueffer@phoenix-systems.de, cyrille.lefevre@laposte.net,
	desmo@bandwidth.org, gnome@FreeBSD.org, goto@snowy.to,
	jeremy@external.org, jim@FreeBSD.org, jmz@FreeBSD.org,
	jylefort@brutele.be, kris@FreeBSD.org, lofi@freebsd.org,
	obrien@FreeBSD.org, ports@FreeBSD.org, sysadmin@alexdupre.com
Subject: Re: ports/57502: ports that define USE_* too late
Date: Sun, 09 Nov 2003 14:32:07 +0100

 Multiple ports define USE_* variables that are tested in bsd.port.pre.mk
 *after* they include bsd.port.pre.mk, which results in that that directive
 being ignored. Updated list (now that we have portlint support ;-):
 
 3d@freebsd.org
 - games/linux-q3ademo (USE_X_PREFIX)
 
 avleeuwen@piwebs.com
 - audio/yammi (USE_KDELIBS_VER)
 
 brueffer@phoenix-systems.de
 - net/simicq (USE_OPENSSL, USE_KDELIBS_VER)
 
 cyrille.lefevre@laposte.net
 textproc/docbook-to-man (USE_IMAKE, USE_X_PREFIX)
 
 desmo@bandwidth.org
 x11-clocks/xalarm (USE_IMAKE, broken by kris@ in an efford to break it only on 5.x :) )
 
 gnome@FreeBSD.org
 - irc/xchat2 (USE_PYTHON)
 
 goto@snowy.to
 - irc/ircatlite (USE_X_PREFIX, broken by kris@ in an efford to break it only on 5.x :) )
 
 jeremy@external.org
 - sysutils/ipsc (USE_X_PREFIX)
 
 jim@FreeBSD.org
 - irc/xchat (USE_OPENSSL, USE_PYTHON)
 
 jmz@FreeBSD.org
 - games/qix (USE_X_PREFIX)
 - x11/xgrab (USE_IMAKE)
 
 jylefort@brutele.be
 - mail/sylpheed-gtk2 (USE_OPENSSL)
 
 lofi@freebsd.org
 - security/pinentry (USE_QT_VER)
 
 obrien@FreeBSD.org
 - editors/vim (USE_PYTHON, USE_RUBY)
 
 ports@FreeBSD.org
 - databases/mdbtools (USE_X_PREFIX)
 - x11-toolkits/viewklass (USE_X_PREFIX)
 
 sysadmin@alexdupre.com
 - databases/mysql41-server (USE_OPENSSL)
 

From: Jean-Marc Zucconi <jmz@FreeBSD.org>
To: Oliver Eikemeier <eikemeier@fillmore-labs.com>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/57502: ports that define USE_* too late
Date: Sun, 9 Nov 2003 11:07:41 -0800 (PST)

 >>>>> Oliver Eikemeier writes:
 
  > Multiple ports define USE_* variables that are tested in bsd.port.pre.mk
  > *after* they include bsd.port.pre.mk, which results in that that directive
  > being ignored. Updated list (now that we have portlint support ;-):
 
  > - games/qix (USE_X_PREFIX)
 
 Not in this case.
 
 Jean-Marc
 
 -- 
 Jean-Marc Zucconi -- PGP Key: finger jmz@FreeBSD.org [KeyID: 400B38E9]

From: Oliver Eikemeier <eikemeier@fillmore-labs.com>
To: Jean-Marc Zucconi <jmz@FreeBSD.org>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/57502: ports that define USE_* too late
Date: Mon, 10 Nov 2003 01:54:34 +0100

 Jean-Marc Zucconi wrote:
 
 >>>>>>Oliver Eikemeier writes:
 > 
 >  > Multiple ports define USE_* variables that are tested in bsd.port.pre.mk
 >  > *after* they include bsd.port.pre.mk, which results in that that directive
 >  > being ignored. Updated list (now that we have portlint support ;-):
 > 
 >  > - games/qix (USE_X_PREFIX)
 > 
 > Not in this case.
 
 Sorry, you're right. Do you think we should try to fix portlint? Or would you prefer:
 
 .if defined(WITHOUT_X11)
 MAKE_ARGS=	NO_X11=yes
 .else
 USE_X_PREFIX=	yes
 PLIST=		pkg-plist.x11
 .endif
 
 .include <bsd.port.pre.mk>
 
 just in case?
 
 
Responsible-Changed-From-To: freebsd-ports-bugs->eik  
Responsible-Changed-By: krion 
Responsible-Changed-When: Sun Nov 16 07:56:02 PST 2003 
Responsible-Changed-Why:  
Submitter is now committer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=57502 

From: Florent Thoumie <flz@xbsd.org>
To: cyrille.lefevre@laposte.net, freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: ports/57502: ports that define USE_* too late
Date: Mon, 06 Jun 2005 00:04:53 +0200

 --=-6GRUfhG6YDVa8jmgPI3K
 Content-Type: text/plain
 Content-Transfer-Encoding: quoted-printable
 
 	Your docbook-to-man port is still not corrected.
 
 	USE_IMAKE implies USE_X_PREFIX, so the latter can be removed.
 
 	USE_IMAKE should be set before bsd.port.pre.mk inclusion.
 
 	In general, non-conditional variable assignments should be
 	done before its inclusion.
 
 	Do you agree with these changes ?
 
 --=20
 Florent Thoumie
 flz@xbsd.org
 
 --=-6GRUfhG6YDVa8jmgPI3K
 Content-Type: application/pgp-signature; name=signature.asc
 Content-Description: This is a digitally signed message part
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.1 (FreeBSD)
 
 iD8DBQBCo3cFMxEkbVFH3PQRAlo+AJ4pjaZXR8FIf/2gSsrXIyfIZ2ilywCeIOvQ
 ojQ8eObJhk/iMsBd2O0gfxw=
 =iBwK
 -----END PGP SIGNATURE-----
 
 --=-6GRUfhG6YDVa8jmgPI3K--
 
State-Changed-From-To: open->suspended 
State-Changed-By: linimon 
State-Changed-When: Mon Jul 18 03:58:58 GMT 2005 
State-Changed-Why:  
With bugmeister hat on, reassign from inactive committer. 

The infrastructure problem that eik noted is now something that's checked 
for in portlint (see ports/57496) but I have not checked to see if all 
the ports that were oringally cited by this PR have been closed.  I'll 
mark this suspended in case someone wants to do the detective work. 


Responsible-Changed-From-To: eik->freebsd-ports-bugs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Mon Jul 18 03:58:58 GMT 2005 
Responsible-Changed-Why:  

http://www.freebsd.org/cgi/query-pr.cgi?pr=57502 
State-Changed-From-To: suspended->open 
State-Changed-By: tmclaugh 
State-Changed-When: Tue Feb 6 02:14:37 UTC 2007 
State-Changed-Why:  
All the ports listed in this PR except textproc/docbook-to-man are fine 
today.  Now I just need to figure out what the hell is going on in that one 
remaining port.  Global and local variables, huh? 


Responsible-Changed-From-To: freebsd-ports-bugs->tmclaugh 
Responsible-Changed-By: tmclaugh 
Responsible-Changed-When: Tue Feb 6 02:14:37 UTC 2007 
Responsible-Changed-Why:  
All the ports listed in this PR except textproc/docbook-to-man are fine 
today.  Now I just need to figure out what the hell is going on in that one 
remaining port.  Global and local variables, huh? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=57502 

From: Tom McLaughlin <tmclaugh@sdf.lonestar.org>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/57502: ports that define USE_* too late
Date: Sun, 04 Nov 2007 17:03:57 -0500

 --=-fnqLShVWMGJTEVQ+DsMa
 Content-Type: text/plain
 Content-Transfer-Encoding: 7bit
 
 Attached patch is the final fix needed to close this PR.  Will commit
 after ports freeze is over.
 
 --=-fnqLShVWMGJTEVQ+DsMa
 Content-Disposition: attachment; filename=docbook-to-man.diff
 Content-Type: text/x-patch; name=docbook-to-man.diff; charset=UTF-8
 Content-Transfer-Encoding: 7bit
 
 Index: Makefile
 ===================================================================
 RCS file: /ncvs/ports/textproc/docbook-to-man/Makefile,v
 retrieving revision 1.12
 diff -u -r1.12 Makefile
 --- Makefile	19 May 2007 20:23:50 -0000	1.12
 +++ Makefile	3 Nov 2007 23:15:53 -0000
 @@ -15,18 +15,8 @@
  MAINTAINER=	ports@FreeBSD.org
  COMMENT=	A DocBook SGML DTD into nroff/troff -man macros converter
  
 -.include <bsd.port.pre.mk>
 -
  # Global variables
  #
 -
 -# There are two ports that satisfy the nsgmls requirement.
 -# Jade is preferred.
 -
 -.if ${MACHINE_ARCH} == "alpha"
 -WITH_OPENJADE=	yes
 -.endif
 -
  .if defined(WITH_OPENJADE)
  RUN_DEPENDS=	onsgmls:${PORTSDIR}/textproc/openjade
  .else
 @@ -37,12 +27,21 @@
  USE_IMAKE=	yes
  PREFIX?=	${LOCALBASE}
  USE_XLIB=	yes
 -XFREE86_HTML_MAN= no
 +XFREE86_HTML_MAN=	no
  
  MAN1=	oinstant.1
  
 +.include <bsd.port.pre.mk>
 +
  # Local variables
  #
 +
 +# There are two ports that satisfy the nsgmls requirement.
 +# Jade is preferred.
 +
 +.if ${ARCH} == "alpha"
 +WITH_OPENJADE=	yes
 +.endif
  
  .if defined(WITH_OPENJADE)
  NSGMLS=		onsgmls
 
 --=-fnqLShVWMGJTEVQ+DsMa--
 
State-Changed-From-To: open->closed 
State-Changed-By: tmclaugh 
State-Changed-When: Fri Apr 18 02:00:36 UTC 2008 
State-Changed-Why:  
Committed final patch. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=57502 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/57502: commit references a PR
Date: Fri, 18 Apr 2008 02:30:23 +0000 (UTC)

 tmclaugh    2008-04-18 02:30:16 UTC
 
   FreeBSD ports repository
 
   Modified files:
     textproc/docbook-to-man Makefile 
   Log:
   - pet portlint
   
   PR:             57502
   
   Revision  Changes    Path
   1.13      +10 -11    ports/textproc/docbook-to-man/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
