From supraexpress@globaleyes.net  Mon Sep  8 21:17:24 2003
Return-Path: <supraexpress@globaleyes.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4708616A4BF
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  8 Sep 2003 21:17:24 -0700 (PDT)
Received: from 253-2.ip.ll.net (253-2.ip.ll.net [209.131.253.2])
	by mx1.FreeBSD.org (Postfix) with ESMTP id BBB2E43FA3
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  8 Sep 2003 21:17:22 -0700 (PDT)
	(envelope-from supraexpress@globaleyes.net)
Received: from freebsd2.localnet10 (localhost [127.0.0.1])
	by freebsd2.localnet10 (8.12.9/8.12.9) with ESMTP id h887nNW6003535
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 8 Sep 2003 02:49:23 -0500 (CDT)
Received: (from root@localhost)
	by freebsd2.localnet10 (8.12.9/8.12.9/Submit) id h887nNDW003534;
	Mon, 8 Sep 2003 02:49:23 -0500 (CDT)
Message-Id: <200309080749.h887nNDW003534@freebsd2.localnet10>
Date: Mon, 8 Sep 2003 02:49:23 -0500 (CDT)
From: nospam@freebsd2.localnet10
Reply-To: supraexpress@globaleyes.net
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: tcptraceroute.c compile fails with: missing terminating " character
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         56620
>Category:       ports
>Synopsis:       tcptraceroute.c compile fails with: missing terminating " character
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Sep 08 21:20:12 PDT 2003
>Closed-Date:    Tue Oct 07 16:12:37 PDT 2003
>Last-Modified:  Tue Oct 07 16:12:37 PDT 2003
>Originator:     none
>Release:        FreeBSD 5.1-CURRENT i386
>Organization:
>Environment:


	
>Description:
	tcptraceroute.c:394:11: missing terminating " character
	tcptraceroute.c: In function `usage':
	tcptraceroute.c:395: error: `l' undeclared (first use in this function)
	tcptraceroute.c:395: error: (Each undeclared identifier is reported only once
	tcptraceroute.c:395: error: for each function it appears in.)
	tcptraceroute.c:395: error: `packet' undeclared (first use in this function)
	tcptraceroute.c:395: error: syntax error before "length"
	tcptraceroute.c:397: error: stray '\' in program
	tcptraceroute.c:397: error: stray '\' in program
	tcptraceroute.c:397:70: missing terminating " character
	tcptraceroute.c:1185:41: missing terminating " character
	tcptraceroute.c: In function `initcapture':
	tcptraceroute.c:1186: error: `tcp' undeclared (first use in this function)
	tcptraceroute.c:1186: error: syntax error before "and"
	tcptraceroute.c:1187:69: missing terminating " character
	*** Error code 1
	 
	 Stop in /usr/ports/net/tcptraceroute/work/tcptraceroute-1.4.

	
>How-To-Repeat:
	
>Fix:

*** tcptraceroute.c.orig	Tue Jul 30 16:51:27 2002
--- tcptraceroute.c	Mon Sep  8 02:42:30 2003
***************
*** 391,399 ****
  void usage(void)
  {
  	printf("\n%s\n%s\n", VERSION, BANNER);
!     fatal("Usage: %s [-nNFSAE] [-i <interface>] [-f <first ttl>]
!        [-l <packet length>] [-q <number of queries>] [-t <tos>]
!        [-m <max ttl>] [-pP] <source port>] [-s <source address>]
         [-w <wait time>] <host> [destination port] [packet length]\n\n", name);
  }
  
--- 391,399 ----
  void usage(void)
  {
  	printf("\n%s\n%s\n", VERSION, BANNER);
!     fatal("Usage: %s [-nNFSAE] [-i <interface>] [-f <first ttl>] \
!        [-l <packet length>] [-q <number of queries>] [-t <tos>] \
!        [-m <max ttl>] [-pP] <source port>] [-s <source address>] \
         [-w <wait time>] <host> [destination port] [packet length]\n\n", name);
  }
  
***************
*** 1182,1189 ****
  	if (! (pcap = pcap_open_live(device, offset + SNAPLEN, 0, 10, errbuf)))
  		fatal("pcap_open_live failed: %s", errbuf);
  
! 	safe_snprintf(filter, TEXTSIZE, "
! 		(tcp and src host %s and src port %d and dst host %s)
  		or ((icmp[0] == 11 or icmp[0] == 3) and dst host %s)",
  			iptos(dst_ip), dst_prt, iptos(src_ip), iptos(src_ip));
  
--- 1182,1189 ----
  	if (! (pcap = pcap_open_live(device, offset + SNAPLEN, 0, 10, errbuf)))
  		fatal("pcap_open_live failed: %s", errbuf);
  
! 	safe_snprintf(filter, TEXTSIZE, " \
! 		(tcp and src host %s and src port %d and dst host %s) \
  		or ((icmp[0] == 11 or icmp[0] == 3) and dst host %s)",
  			iptos(dst_ip), dst_prt, iptos(src_ip), iptos(src_ip));
  
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: edwin 
State-Changed-When: Tue Oct 7 16:12:35 PDT 2003 
State-Changed-Why:  
Commited, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=56620 
>Unformatted:
