From sheepkiller@cultdeadsheep.org  Sun Aug 31 15:58:54 2003
Return-Path: <sheepkiller@cultdeadsheep.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DE8BA16A4BF
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 31 Aug 2003 15:58:54 -0700 (PDT)
Received: from cultdeadsheep.org (charon.cultdeadsheep.org [80.65.226.72])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5342243FEC
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 31 Aug 2003 15:58:52 -0700 (PDT)
	(envelope-from sheepkiller@cultdeadsheep.org)
Received: (qmail 14241 invoked from network); 31 Aug 2003 22:58:51 -0000
Received: from unknown (HELO lucifer.cultdeadsheep.org) (192.168.0.2)
  by goofy.cultdeadsheep.org with SMTP; 31 Aug 2003 22:58:51 -0000
Received: by lucifer.cultdeadsheep.org (sSMTP sendmail emulation); Mon,  1 Sep 2003 00:57:54 +0200
Message-Id: <20030831225852.5342243FEC@mx1.FreeBSD.org>
Date: Mon,  1 Sep 2003 00:57:54 +0200
From: Clement Laforet <sheepkiller@cultdeadsheep.org>
Reply-To: Clement Laforet <sheepkiller@cultdeadsheep.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: Clement Laforet <sheepkiller@cultdeadsheep.org>
Subject: [patch] databases/mysql{323,40,41}-server: fix possible infinite loop if USE_MYSQL is accidently defined
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         56252
>Category:       ports
>Synopsis:       [patch] databases/mysql{323,40,41}-server: fix possible infinite loop if USE_MYSQL is accidently defined
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    roam
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Aug 31 16:00:35 PDT 2003
>Closed-Date:    Fri Oct 03 09:10:33 PDT 2003
>Last-Modified:  Fri Oct 03 09:10:33 PDT 2003
>Originator:     Clement Laforet
>Release:        FreeBSD 5.1-CURRENT i386
>Organization:
cotds.org
>Environment:
System: FreeBSD lucifer.cultdeadsheep.org 5.1-CURRENT FreeBSD 5.1-CURRENT #0: Sun Aug 24 15:37:26 CEST 2003 root@lucifer.cultdeadsheep.org:/usr/obj/usr/src/sys/LUCIFER i386

	
>Description:
	When USE_MYSQL is defined out of a port, it can cause infinite loop.
	These patches (read "copy and paste"), obtained from openldap and gmake ports,
	avoid infinite loops which can kill your system.

>How-To-Repeat:
	On a fresh system:
	# cd /usr/ports/devel/libtool13
	# echo "USE_MYSQL=I_wanna_see_my_freebsd_box_out_of_memory" >> /etc/make.conf
	# make all-depends-list
	Wait a couple of minutes until all your memory is exhausted.

>Fix:

mysql323-server
-------------------------------
--- mysql323-server/Makefile.orig	Mon Sep  1 00:27:54 2003
+++ mysql323-server/Makefile	Mon Sep  1 00:28:11 2003
@@ -39,6 +39,10 @@
 		--program-prefix='' \
 		--with-innodb
 
+.ifdef USE_MYSQL
+.error You have `USE_MYSQL' variable defined either in environment or in make(1) arguments. Please undefine and try again.
+.endif
+
 .include <bsd.port.pre.mk>
 
 .if ${MACHINE_ARCH} == "i386"

mysql40-server
-------------------------------
--- mysql40-server/Makefile.orig	Mon Sep  1 00:33:32 2003
+++ mysql40-server/Makefile	Mon Sep  1 00:33:40 2003
@@ -46,6 +46,10 @@
 		--with-comment='FreeBSD port: ${PKGNAME}' \
 		--enable-thread-safe-client
 
+.ifdef USE_MYSQL
+.error You have `USE_MYSQL' variable defined either in environment or in make(1) arguments. Please undefine and try again.
+.endif
+
 .include <bsd.port.pre.mk>
 
 .if ${MACHINE_ARCH} == "i386"

mysql41-server
-------------------------------
--- mysql41-server/Makefile.orig	Mon Sep  1 00:24:47 2003
+++ mysql41-server/Makefile	Mon Sep  1 00:26:31 2003
@@ -48,6 +48,10 @@
 		--with-comment='FreeBSD port: ${PKGNAME}' \
 		--enable-thread-safe-client
 
+.ifdef USE_MYSQL
+.error You have `USE_MYSQL' variable defined either in environment or in make(1) arguments. Please undefine and try again.
+.endif
+
 .include <bsd.port.pre.mk>
 
 .if ${MACHINE_ARCH} == "i386"
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->roam 
Responsible-Changed-By: roam 
Responsible-Changed-When: Tue Sep 23 07:02:06 PDT 2003 
Responsible-Changed-Why:  
I'll take care of this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=56252 
State-Changed-From-To: open->closed 
State-Changed-By: roam 
State-Changed-When: Fri Oct 3 09:10:22 PDT 2003 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=56252 
>Unformatted:
