From
Return-Path: <lth@dask.thegler.dk>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1419A16A4BF
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 29 Aug 2003 15:43:06 -0700 (PDT)
Received: from dask.thegler.dk (dask.thegler.dk [212.242.93.12])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 81D9D43F93
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 29 Aug 2003 15:43:05 -0700 (PDT)
	(envelope-from lth@dask.thegler.dk)
Received: by dask.thegler.dk (Postfix, from userid 1001)
	id D15C83E55; Sat, 30 Aug 2003 00:43:03 +0200 (CEST)
Message-Id: <20030829224303.D15C83E55@dask.thegler.dk>
Date: Sat, 30 Aug 2003 00:43:03 +0200 (CEST)
From: Lars Thegler <lars@thegler.dk>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] textproc/p5-XML-SimpleObject: fix bento build error
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         56163
>Category:       ports
>Synopsis:       [PATCH] textproc/p5-XML-SimpleObject: fix bento build error
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug 29 15:50:11 PDT 2003
>Closed-Date:    Tue Sep 02 06:00:30 PDT 2003
>Last-Modified:  Tue Sep 02 06:00:30 PDT 2003
>Originator:     Lars Thegler
>Release:        FreeBSD 4.8-STABLE i386
>Organization:
>Environment:
System: FreeBSD dask.thegler.dk 4.8-STABLE FreeBSD 4.8-STABLE #9: Tue Jul 29 01:39:22 CEST 2003
>Description:
- Fix bento build error (mark IGNORE for perl < 5.6)
- Make portlint happy

Generated with FreeBSD Port Tools 0.26
>How-To-Repeat:
>Fix:

--- p5-XML-SimpleObject-0.53.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/textproc/p5-XML-SimpleObject/Makefile /usr/home/lth/ports/textproc/p5-XML-SimpleObject/Makefile
--- /usr/ports/textproc/p5-XML-SimpleObject/Makefile	Wed Jun 25 07:04:14 2003
+++ /usr/home/lth/ports/textproc/p5-XML-SimpleObject/Makefile	Sat Aug 30 00:36:11 2003
@@ -12,16 +12,21 @@
 MASTER_SITE_SUBDIR=	XML
 PKGNAMEPREFIX=	p5-
 
-WRKSRC?=	${WRKDIR}/${PORTNAME}${PORTVERSION}
-
 MAINTAINER=	ports@FreeBSD.org
 COMMENT=	API for accessing the structure of an XML document
 
-BUILD_DEPENDS=	${LOCALBASE}/lib/perl5/site_perl/${PERL_VER}/${PERL_ARCH}/XML/Parser.pm:${PORTSDIR}/textproc/p5-XML-Parser
+BUILD_DEPENDS=	${SITE_PERL}/${PERL_ARCH}/XML/Parser.pm:${PORTSDIR}/textproc/p5-XML-Parser
+
+WRKSRC=		${WRKDIR}/${PORTNAME}${PORTVERSION}
 
 PERL_CONFIGURE=	YES
 
 MAN3=		XML::SimpleObject.3
-MANPREFIX=	${PREFIX}/lib/perl5/${PERL_VERSION}
 
-.include <bsd.port.mk>
+.include <bsd.port.pre.mk>
+
+.if ${PERL_LEVEL} < 500600
+IGNORE=		Port requires perl 5.6.x or later. Install lang/perl5 then try again
+.endif
+
+.include <bsd.port.post.mk>
diff -ruN --exclude=CVS /usr/ports/textproc/p5-XML-SimpleObject/files/patch-Makefile.PL /usr/home/lth/ports/textproc/p5-XML-SimpleObject/files/patch-Makefile.PL
--- /usr/ports/textproc/p5-XML-SimpleObject/files/patch-Makefile.PL	Thu Jan  1 01:00:00 1970
+++ /usr/home/lth/ports/textproc/p5-XML-SimpleObject/files/patch-Makefile.PL	Sat Aug 30 00:34:42 2003
@@ -0,0 +1,8 @@
+--- Makefile.PL.orig	Sat Aug 30 00:34:00 2003
++++ Makefile.PL	Sat Aug 30 00:32:16 2003
+@@ -10,4 +10,5 @@
+ WriteMakefile(
+     'NAME'	=> 'XML::SimpleObject',
+     'VERSION_FROM' => 'SimpleObject.pm', # finds $VERSION
++    'DIR' => [],
+ );
--- p5-XML-SimpleObject-0.53.patch ends here ---

>Release-Note:
>Audit-Trail:

From: Foxfair Hu <foxfair@drago.fomokka.net>
To: freebsd-gnats-submit@FreeBSD.org, lars@thegler.dk
Cc:  
Subject: Re: ports/56163: [PATCH] textproc/p5-XML-SimpleObject: fix bento build error
Date: Tue, 2 Sep 2003 17:05:13 +0800

 --4Ckj6UjgE2iN1+kY
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 Hello Lars,
 
   I have a similar patch for this problem, which also passed portlint
 check and do the right thing on the fly. How about this one? I'll create
 a slave port for XML::SimpleObject::LibXML separately:
 
 
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D
 diff -ruN /usr/ports/textproc/p5-XML-SimpleObject/Makefile ./Makefile
 --- /usr/ports/textproc/p5-XML-SimpleObject/Makefile	Mon Aug 25 17:34:15 20=
 03
 +++ ./Makefile	Tue Sep  2 16:57:17 2003
 @@ -7,19 +7,21 @@
 =20
  PORTNAME=3D	XML-SimpleObject
  PORTVERSION=3D	0.53
 +PORTREVISION=3D	1
  CATEGORIES=3D	textproc perl5
  MASTER_SITES=3D	${MASTER_SITE_PERL_CPAN}
  MASTER_SITE_SUBDIR=3D	XML
  PKGNAMEPREFIX=3D	p5-
 =20
 -WRKSRC?=3D	${WRKDIR}/${PORTNAME}${PORTVERSION}
 -
  MAINTAINER=3D	ports@FreeBSD.org
  COMMENT=3D	API for accessing the structure of an XML document
 =20
 -BUILD_DEPENDS=3D	${LOCALBASE}/lib/perl5/site_perl/${PERL_VER}/${PERL_ARCH}=
 /XML/Parser.pm:${PORTSDIR}/textproc/p5-XML-Parser
 +BUILD_DEPENDS=3D	${SITE_PERL}/${PERL_ARCH}/XML/Parser.pm:${PORTSDIR}/textp=
 roc/p5-XML-Parser
 +
 +WRKSRC?=3D        ${WRKDIR}/${PORTNAME}${PORTVERSION}
 =20
  PERL_CONFIGURE=3D	YES
 +CONFIGURE_ARGS+=3D	DIR=3D'Enhanced'
 =20
  MAN3=3D		XML::SimpleObject.3
  MANPREFIX=3D	${PREFIX}/lib/perl5/${PERL_VERSION}
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D
 
 
 foxfair
 
 
 --4Ckj6UjgE2iN1+kY
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.3 (FreeBSD)
 
 iD8DBQE/VF1J1VNL1U6bylkRAhKjAJ9Bx2Ox9DiAgCyr1pg39OWtIybx3gCcDqFi
 lgmQLCLOKIzFEGMpJ3YWfFM=
 =aRTq
 -----END PGP SIGNATURE-----
 
 --4Ckj6UjgE2iN1+kY--

From: "Lars Thegler" <lars@thegler.dk>
To: <foxfair@FreeBSD.org>, <freebsd-gnats-submit@FreeBSD.org>
Cc:  
Subject: Re: ports/56163: [PATCH] textproc/p5-XML-SimpleObject: fix bento build error
Date: Tue, 2 Sep 2003 11:34:48 +0200

 >I have a similar patch for this problem, which also passed portlint
 >check and do the right thing on the fly. How about this one?
 
 I agree - much neater.
 
 But if you add "CONFIGURE_ARGS+= DIR='Enhanced'", won't you have to fix the
 pkg-plist as well?
 
 >I'll create a slave port for XML::SimpleObject::LibXML separately:
 
 I noticed that the author has made a separate module for
 XML::SimpleObject::LibXML. Maybe you should port that, instead of making it
 a slave of this port.
 
 By the way, is the PORTREVISION bump really needed? Exisisting installations
 will work anyway, won't they? Or is this to force bento to upgrade?
 
 /Lars
 

From: Foxfair Hu <foxfair@drago.fomokka.net>
To: Lars Thegler <lars@thegler.dk>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/56163: [PATCH] textproc/p5-XML-SimpleObject: fix bento build error
Date: Tue, 2 Sep 2003 18:07:20 +0800

 --Fba/0zbH8Xs+Fj9o
 Content-Type: multipart/mixed; boundary="wac7ysb48OaltWcw"
 Content-Disposition: inline
 
 
 --wac7ysb48OaltWcw
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On Tue, Sep 02, 2003 at 11:34:48AM +0200, Lars Thegler wrote:
 >=20
 > I agree - much neater.
 >=20
 > But if you add "CONFIGURE_ARGS+=3D DIR=3D'Enhanced'", won't you have to f=
 ix the
 > pkg-plist as well?
 >=20
 
   Ah, my bad. Forgot the pkgplsit one. Here is my full patch in the end
 of this email.
 
 > >I'll create a slave port for XML::SimpleObject::LibXML separately:
 >=20
 > I noticed that the author has made a separate module for
 > XML::SimpleObject::LibXML. Maybe you should port that, instead of making =
 it
 > a slave of this port.
 >=20
 
   Actually XML::SimpleObject::LibXML is included in XML::SimpleObject.
 And they use the same package file in CPAN. You can see a LibXML/ sub=20
 directory after you extract it.
 
 >=20
 > By the way, is the PORTREVISION bump really needed? Exisisting installati=
 ons
 > will work anyway, won't they? Or is this to force bento to upgrade?
 >=20
 > /Lars
 
   IMHO yes, I use PORTREVISION change to indicate a functional update of
 Makefile in ports build environment. Otherwise we have to talk about the
 rev number in CVS, too painful to me. :)
 
   Since there will be a pkg-plist change too, so bump PORTREVISION
 is also needed.
 
 foxfair
 
 
 --wac7ysb48OaltWcw
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="patch.p5-XML-SimpleObject"
 Content-Transfer-Encoding: quoted-printable
 
 diff -ruN /usr/ports/textproc/p5-XML-SimpleObject/Makefile ./Makefile
 --- /usr/ports/textproc/p5-XML-SimpleObject/Makefile	Mon Aug 25 17:34:15 20=
 03
 +++ ./Makefile	Tue Sep  2 17:52:55 2003
 @@ -7,19 +7,21 @@
 =20
  PORTNAME=3D	XML-SimpleObject
  PORTVERSION=3D	0.53
 +PORTREVISION=3D	1
  CATEGORIES=3D	textproc perl5
  MASTER_SITES=3D	${MASTER_SITE_PERL_CPAN}
  MASTER_SITE_SUBDIR=3D	XML
  PKGNAMEPREFIX=3D	p5-
 =20
 -WRKSRC?=3D	${WRKDIR}/${PORTNAME}${PORTVERSION}
 -
  MAINTAINER=3D	ports@FreeBSD.org
  COMMENT=3D	API for accessing the structure of an XML document
 =20
 -BUILD_DEPENDS=3D	${LOCALBASE}/lib/perl5/site_perl/${PERL_VER}/${PERL_ARCH}=
 /XML/Parser.pm:${PORTSDIR}/textproc/p5-XML-Parser
 +BUILD_DEPENDS=3D	${SITE_PERL}/${PERL_ARCH}/XML/Parser.pm:${PORTSDIR}/textp=
 roc/p5-XML-Parser
 +
 +WRKSRC?=3D        ${WRKDIR}/${PORTNAME}${PORTVERSION}
 =20
  PERL_CONFIGURE=3D	YES
 +CONFIGURE_ARGS+=3D	DIR=3D'Enhanced'
 =20
  MAN3=3D		XML::SimpleObject.3
  MANPREFIX=3D	${PREFIX}/lib/perl5/${PERL_VERSION}
 diff -ruN /usr/ports/textproc/p5-XML-SimpleObject/pkg-plist ./pkg-plist
 --- /usr/ports/textproc/p5-XML-SimpleObject/pkg-plist	Mon Aug 25 17:34:15 2=
 003
 +++ ./pkg-plist	Tue Sep  2 17:51:29 2003
 @@ -1,6 +1,8 @@
  %%SITE_PERL%%/%%PERL_ARCH%%/auto/XML/SimpleObject/.packlist
  %%SITE_PERL%%/XML/SimpleObject.pm
 +%%SITE_PERL%%/XML/SimpleObject/Enhanced.pm
  %%SITE_PERL%%/XML/ex.pl
 +@dirrm %%SITE_PERL%%/XML/SimpleObject
  @dirrm %%SITE_PERL%%/%%PERL_ARCH%%/auto/XML/SimpleObject
  @unexec rmdir %D/%%SITE_PERL%%/%%PERL_ARCH%%/auto/XML 2>/dev/null || true
  @unexec rmdir %D/%%SITE_PERL%%/XML 2>/dev/null || true
 
 --wac7ysb48OaltWcw--
 
 --Fba/0zbH8Xs+Fj9o
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.3 (FreeBSD)
 
 iD8DBQE/VGvY1VNL1U6bylkRAuBgAJ44q9Oz/GCP6jkXsSeJSRL23RXHnwCgjSTN
 NibhCm5BIOGDBHh2Z5XM/cc=
 =wpxN
 -----END PGP SIGNATURE-----
 
 --Fba/0zbH8Xs+Fj9o--

From: "Lars Thegler" <lars@thegler.dk>
To: <foxfair@FreeBSD.org>
Cc: <freebsd-gnats-submit@FreeBSD.org>
Subject: Re: ports/56163: [PATCH] textproc/p5-XML-SimpleObject: fix bento build error
Date: Tue, 2 Sep 2003 12:55:17 +0200

 Foxfair Hu <foxfair@drago.fomokka.net> wrote:
 >   Actually XML::SimpleObject::LibXML is included in XML::SimpleObject.
 > And they use the same package file in CPAN. You can see a LibXML/ sub
 > directory after you extract it.
 
 I'm not sure I understand what you mean about "the same package file in
 CPAN". In CPAN, the $VERSIONs of LibXML.pm are not the same:
 
 DBRIAN/XML-SimpleObject-0.53/LibXML/LibXML.pm  0.53
 DBRIAN/XML-SimpleObject-LibXML-0.59/LibXML.pm  0.59
 
 The diff between those two versions seems to be non-trivial - if you want to
 provide XML::SimpleObject::LibXML, I suggest you do that by porting
 XML-SimpleObject-LibXML-0.59 rather that taking the LibXML.pm from
 XML-SimpleObject-0.53. It seems the original author has created a bit of a
 version mess here, but there is no need for us porters to continue that
 tradition :)
 
 >   Since there will be a pkg-plist change too, so bump PORTREVISION
 > is also needed.
 
 Fine by me! Commit at will :)
 
 /Lars
 
State-Changed-From-To: open->closed 
State-Changed-By: foxfair 
State-Changed-When: Tue Sep 2 05:54:51 PDT 2003 
State-Changed-Why:  
Committed a similar fix, thanks! 


http://www.freebsd.org/cgi/query-pr.cgi?pr=56163 
>Unformatted:
