From tobez@tobez.org  Thu Aug 28 14:11:29 2003
Return-Path: <tobez@tobez.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D97CA16A4BF
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 28 Aug 2003 14:11:29 -0700 (PDT)
Received: from heechee.tobez.org (heechee.tobez.org [217.157.39.226])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5D30C43FEC
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 28 Aug 2003 14:11:28 -0700 (PDT)
	(envelope-from tobez@tobez.org)
Received: by heechee.tobez.org (Postfix, from userid 1001)
	id B7CD9175CF; Thu, 28 Aug 2003 23:11:24 +0200 (CEST)
Message-Id: <20030828211124.GK34739@heechee.tobez.org>
Date: Thu, 28 Aug 2003 23:11:24 +0200
From: Anton Berezin <tobez@freebsd.org>
To: Fernan Aguero <fernan@iib.unsam.edu.ar>,
	FreeBSD-gnats-submit@freebsd.org
In-Reply-To: <20030828210450.GI34739@heechee.tobez.org>
Subject: Re: devel/p5-IPC-RUN checks for IO/Handle.pm in the wrong place?
References: <200308282100.h7SL0riP003479@pi.iib.unsam.edu.ar> <20030828210450.GI34739@heechee.tobez.org>

>Number:         56104
>Category:       ports
>Synopsis:       Re: devel/p5-IPC-RUN checks for IO/Handle.pm in the wrong place?
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    ceri
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Aug 28 14:20:21 PDT 2003
>Closed-Date:    Thu Sep 18 13:01:22 PDT 2003
>Last-Modified:  Thu Sep 18 13:01:22 PDT 2003
>Originator:     Anton Berezin
>Release:        
>Organization:
>Environment:
>Description:
 On Thu, Aug 28, 2003 at 11:04:50PM +0200, Anton Berezin wrote:
 > On Thu, Aug 28, 2003 at 06:00:53PM -0300, Fernan Aguero wrote:
 > > >Description:
 > > 	While trying to build p5-IPC-Run, the installation fails.
 > > 
 > > 	The problem is that IO/Handle.pm is looked in
 > > 	${SITE_PERL}/${PERL_ARCH}/IO/Handle.pm
 > > 
 > > 	When the search fails (Handle.pm not found) the port tries to
 > > 	then build and install devel/p5-IO. However p5-IO exits as a
 > > 	result of a check on the installed Perl version ("This module is
 > > 	already included in perl 5.6.x and later...")
 > > 
 > > 	This breaks the installation of ports that depend on p5-IPC-Run.
 > > 
 > > 	I have perl 5.6.1 installed and IO/Handle.pm is at 
 > > 	/usr/local/lib/perl5/5.6.1/mach/IO/Handle.pm
 > > 	and not at
 > > 	/usr/local/lib/perl5/site_perl/5.6.1/mach/IO/Handle.pm
 > > 	where the p5-IPC-Run Makefile is looking.
 > > 	
 > > >How-To-Repeat:
 > > 	If you don't have p5-IO installed, and have a Perl > 5.6.0 try
 > > 	installing p5-IPC-Run and see it failing even though
 > > 	IO/Handle.pm is present in the system.
 > > >Fix:
 > 
 > Does this patch fixes the problem?
 > 
 > Index: Makefile
 > ===================================================================
 > RCS file: /home/ncvs/ports/devel/p5-IPC-Run/Makefile,v
 > retrieving revision 1.3
 > diff -u -r1.3 Makefile
 > --- Makefile	7 Mar 2003 06:00:57 -0000	1.3
 > +++ Makefile	28 Aug 2003 21:03:56 -0000
 > @@ -7,6 +7,7 @@
 >  
 >  PORTNAME=	IPC-Run
 >  PORTVERSION=	0.74
 > +PORTREVISION=	1
 >  CATEGORIES=	devel perl5
 >  MASTER_SITES=	${MASTER_SITE_PERL_CPAN}
 >  MASTER_SITE_SUBDIR=	IPC
 > @@ -16,7 +17,6 @@
 >  COMMENT=	IPC::Run - Run subprocesses with piping and redirection
 >  
 >  BUILD_DEPENDS=	${SITE_PERL}/${PERL_ARCH}/Time/HiRes.pm:${PORTSDIR}/devel/p5-Time-HiRes \
 > -		${SITE_PERL}/${PERL_ARCH}/IO/Handle.pm:${PORTSDIR}/devel/p5-IO \
 >  		${SITE_PERL}/${PERL_ARCH}/IO/Tty.pm:${PORTSDIR}/devel/p5-IO-Tty
 >  RUN_DEPENDS=	${BUILD_DEPENDS}
 >  
 > @@ -26,5 +26,12 @@
 >  MAN3=	IPC::Run.3 IPC::Run::IO.3 IPC::Run::Timer.3 IPC::Run::Debug.3\
 >  	IPC::Run::Win32IO.3 IPC::Run::Win32Helper.3 IPC::Run::Win32Pump.3
 >  MANPREFIX=	${PREFIX}/lib/perl5/${PERL_VERSION}
 > +
 > +.include <bsd.port.pre.mk>
 > +
 > +.if ${PERL_LEVEL} < 500600
 > +BUILD_DEPENDS+=	${SITE_PERL}/${PERL_ARCH}/IO/Handle.pm:${PORTSDIR}/devel/p5-IO
 > +RUN_DEPENDS+=	${SITE_PERL}/${PERL_ARCH}/IO/Handle.pm:${PORTSDIR}/devel/p5-IO
 > +.endif
 >  
 >  .include <bsd.port.mk>
              Oooops.
 
 Er, the corrected verion:
 
 Index: Makefile
 ===================================================================
 RCS file: /home/ncvs/ports/devel/p5-IPC-Run/Makefile,v
 retrieving revision 1.3
 diff -u -r1.3 Makefile
 --- Makefile	7 Mar 2003 06:00:57 -0000	1.3
 +++ Makefile	28 Aug 2003 21:10:57 -0000
 @@ -7,6 +7,7 @@
  
  PORTNAME=	IPC-Run
  PORTVERSION=	0.74
 +PORTREVISION=	1
  CATEGORIES=	devel perl5
  MASTER_SITES=	${MASTER_SITE_PERL_CPAN}
  MASTER_SITE_SUBDIR=	IPC
 @@ -16,7 +17,6 @@
  COMMENT=	IPC::Run - Run subprocesses with piping and redirection
  
  BUILD_DEPENDS=	${SITE_PERL}/${PERL_ARCH}/Time/HiRes.pm:${PORTSDIR}/devel/p5-Time-HiRes \
 -		${SITE_PERL}/${PERL_ARCH}/IO/Handle.pm:${PORTSDIR}/devel/p5-IO \
  		${SITE_PERL}/${PERL_ARCH}/IO/Tty.pm:${PORTSDIR}/devel/p5-IO-Tty
  RUN_DEPENDS=	${BUILD_DEPENDS}
  
 @@ -27,4 +27,11 @@
  	IPC::Run::Win32IO.3 IPC::Run::Win32Helper.3 IPC::Run::Win32Pump.3
  MANPREFIX=	${PREFIX}/lib/perl5/${PERL_VERSION}
  
 -.include <bsd.port.mk>
 +.include <bsd.port.pre.mk>
 +
 +.if ${PERL_LEVEL} < 500600
 +BUILD_DEPENDS+=	${SITE_PERL}/${PERL_ARCH}/IO/Handle.pm:${PORTSDIR}/devel/p5-IO
 +RUN_DEPENDS+=	${SITE_PERL}/${PERL_ARCH}/IO/Handle.pm:${PORTSDIR}/devel/p5-IO
 +.endif
 +
 +.include <bsd.port.post.mk>
 
 -- 
 If I did know the future of Perl, and if I told you, you'd probably run
 away screaming.  -- Larry Wall
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: ceri 
State-Changed-When: Thu Sep 18 13:00:58 PDT 2003 
State-Changed-Why:  
Misfiled followup to ports/56101 [content migrated]. 


Responsible-Changed-From-To: gnats-admin->ceri 
Responsible-Changed-By: ceri 
Responsible-Changed-When: Thu Sep 18 13:00:58 PDT 2003 
Responsible-Changed-Why:  

Take from gnats-admin. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=56104 
>Unformatted:
