From root@knight.volant.org  Fri Aug 15 10:49:06 2003
Return-Path: <root@knight.volant.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8261937B404
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 15 Aug 2003 10:49:06 -0700 (PDT)
Received: from knight.volant.org (knight.volant.org [207.111.218.254])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 066B743F3F
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 15 Aug 2003 10:49:06 -0700 (PDT)
	(envelope-from root@knight.volant.org)
Received: from root by knight.volant.org with local (Exim 4.12)
	id 19nih3-000LFQ-00
	for FreeBSD-gnats-submit@freebsd.org; Fri, 15 Aug 2003 10:48:53 -0700
Message-Id: <E19nih3-000LFQ-00@knight.volant.org>
Date: Fri, 15 Aug 2003 10:48:53 -0700
From: Pat Lashley <patl+freebsd@volant.org>
Reply-To: Pat Lashley <patl+freebsd@volant.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Clamav port package build fails on 5.x when NO_SENDMAIL is set
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         55611
>Category:       ports
>Synopsis:       Clamav port package build fails on 5.x when NO_SENDMAIL is set
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug 15 10:50:13 PDT 2003
>Closed-Date:    Sat Feb 28 07:07:06 PST 2004
>Last-Modified:  Fri Mar 26 09:40:09 PST 2004
>Originator:     Pat Lashley
>Release:        FreeBSD 4.8-RC i386
>Organization:
Henry Davis Consulting
>Environment:
FreeBSD ports.local.volant.org 5.1-RELEASE-p2 FreeBSD 5.1-RELEASE-p2 #1: Tue Aug 12 21:55:46 PDT 2003     broot@quick.volant.org:/usr/obj/usr/src/sys/QUICK  i386

>Description:
        When building the clamav port on FreeBSD 5.x, the Makefile will
        add options to build a milter for sendmail.  If sendmail is not
        installed, the milter build fails.  The clamav installation
        does succeed without this file; but 'make package' fails because
        it can't find sbin/clamav-milter.
>How-To-Repeat:
        Build or install a FreeBSD 5.x system without sendmail.
        cd /usr/ports/security/clamav ; make package
>Fix:
        The following patch adds a check for the NO_SENDMAIL make.conf
        option to the OS version test.  When NO_SENMAIL is set, it will
        not try to build the milter.
                                                                                
--- Makefile.~1~        Tue Jul  8 01:15:55 2003
+++ Makefile    Wed Aug 13 18:37:23 2003
@@ -38,7 +38,7 @@
  
 .include <bsd.port.pre.mk>
  
-.if ${OSVERSION} > 500000
+.if ${OSVERSION} > 500000  &&  ! defined(NO_SENDMAIL)
 CONFIGURE_ARGS+=--enable-milter
 PLIST_SUB+=    CLAMAV-MILTER:=""
 .else
 
>Release-Note:
>Audit-Trail:

From: TERAMOTO Masahiro <markun@onohara.to>
To: freebsd-gnats-submit@FreeBSD.org, patl+freebsd@volant.org
Cc:  
Subject: Re: ports/55611: Clamav port package build fails on 5.x when NO_SENDMAIL is set
Date: Sun, 02 Nov 2003 15:48:17 +0900

 Thank you for patch.
 
 I make patch (merge ports/58036). Please commit.
 http://www.freebsd.org/cgi/query-pr.cgi?pr=58036
 
 
 Index: Makefile
 ===================================================================
 RCS file: /home/repository/FreeBSD/ncvs/ports/security/clamav/Makefile,v
 retrieving revision 1.12
 diff -u -r1.12 Makefile
 --- Makefile	25 Oct 2003 20:52:32 -0000	1.12
 +++ Makefile	2 Nov 2003 06:42:45 -0000
 @@ -7,7 +7,7 @@
  
  PORTNAME=	clamav
  PORTVERSION=	0.60
 -PORTREVISION=	4
 +PORTREVISION=	5
  CATEGORIES=	security
  MASTER_SITES=	${MASTER_SITE_SOURCEFORGE}
  MASTER_SITE_SUBDIR=	clamav
 @@ -40,6 +40,8 @@
  MAN5=		clamav.conf.5
  MAN8=		clamd.8
  
 +CONFLICTS=	clamav-devel-*
 +
  CLAMD_SOCKET?=	/var/run/clamav/clamd
  
  CONFLICTS=	clamav-devel-*
 @@ -73,7 +75,7 @@
  LDFLAGS+=	-lcipher
  .endif
  
 -.if defined(WITH_MILTER)
 +.if defined(WITH_MILTER) && ! defined(NO_SENDMAIL)
  USE_GETOPT_LONG=	yes
  CONFIGURE_ARGS+=	--enable-milter
  PLIST_SUB+=	CLAMAV-MILTER=""
 
 
 -- 
 TERAMOTO Masahiro
    markun@onohara.to
 

From: TERAMOTO Masahiro <markun@onohara.to>
To: freebsd-gnats-submit@FreeBSD.org, patl@onohara.to,
	freebsd@volant.org
Cc:  
Subject: Re: ports/55611: Clamav port package build fails on 5.x when NO_SENDMAIL is set
Date: Sun, 02 Nov 2003 18:48:43 +0900

 sorry ports/58036 is closed.
 
 Index: Makefile
 ===================================================================
 RCS file: /home/repository/FreeBSD/ncvs/ports/security/clamav/Makefile,v
 retrieving revision 1.12
 diff -u -r1.12 Makefile
 --- Makefile	25 Oct 2003 20:52:32 -0000	1.12
 +++ Makefile	2 Nov 2003 09:47:43 -0000
 @@ -7,7 +7,7 @@
  
  PORTNAME=	clamav
  PORTVERSION=	0.60
 -PORTREVISION=	4
 +PORTREVISION=	5
  CATEGORIES=	security
  MASTER_SITES=	${MASTER_SITE_SOURCEFORGE}
  MASTER_SITE_SUBDIR=	clamav
 @@ -73,7 +73,7 @@
  LDFLAGS+=	-lcipher
  .endif
  
 -.if defined(WITH_MILTER)
 +.if defined(WITH_MILTER) && ! defined(NO_SENDMAIL)
  USE_GETOPT_LONG=	yes
  CONFIGURE_ARGS+=	--enable-milter
  PLIST_SUB+=	CLAMAV-MILTER=""
 
 
 -- 
 TERAMOTO Masahiro($B;{K\(B $B>;90(B)
    markun@onohara.to
 
State-Changed-From-To: open->feedback 
State-Changed-By: petef 
State-Changed-When: Sat Dec 20 21:52:22 CST 2003 
State-Changed-Why:  
Shouldn't we set a PLIST_SUB and modify pkg-plist if we're not 
going to build the milter? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=55611 
State-Changed-From-To: feedback->closed 
State-Changed-By: pav 
State-Changed-When: Sat Feb 28 07:06:50 PST 2004 
State-Changed-Why:  
I merged maintainer's patch into CVS tree. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=55611 

From: Alex Vasylenko <lxv@omut.org>
To: freebsd-gnats-submit@FreeBSD.org
Cc: patl+freebsd@volant.org, TERAMOTO Masahiro <markun@onohara.to>
Subject: Re: ports/55611: Clamav port package build fails on 5.x when NO_SENDMAIL
 is set
Date: Fri, 26 Mar 2004 12:31:51 -0500

 Please consider reopening the PR ports/55611 and reverting the change 
 made to ports/security/clamav/Makefile in rev 1.22 for the following 
 reasons:
 
 - presence/absence of sendmail in the base system (which is what 
 NO_SENDMAIL controls) should not alter the build of clamav (sendmail can 
 be installed from a port);
 - configure script for clamav contains code that in case of missing 
 libmilter will disregard --enable-milter configure argument and refrain 
 from building clamav-milter;
 - as the port is, clamav-milter can't be built on a system with 
 NO_SENDMAIL and a sendmail installed from ports.
 
 thanks,
 --
 Alex.
>Unformatted:
