From mhsin@mhsin.org  Mon Aug 11 12:40:41 2003
Return-Path: <mhsin@mhsin.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 341A337B401
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 11 Aug 2003 12:40:41 -0700 (PDT)
Received: from Ada.mhsin.org (mhsin.csie.ntu.edu.tw [140.112.31.186])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D284543FBF
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 11 Aug 2003 12:40:39 -0700 (PDT)
	(envelope-from mhsin@mhsin.org)
Received: by Ada.mhsin.org (Postfix, from userid 1701)
	id 57723FF19; Tue, 12 Aug 2003 03:40:34 +0800 (CST)
Message-Id: <20030811194034.57723FF19@Ada.mhsin.org>
Date: Tue, 12 Aug 2003 03:40:34 +0800 (CST)
From: Michael Hsin <mhsin@mhsin.org>
Reply-To: Michael Hsin <mhsin@mhsin.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] devel/arm-elf-gcc295 fails to build on -stable.
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         55475
>Category:       ports
>Synopsis:       [PATCH] devel/arm-elf-gcc295 fails to build on -stable.
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    gerald
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Aug 11 12:50:17 PDT 2003
>Closed-Date:    Tue Sep 23 02:08:37 PDT 2003
>Last-Modified:  Tue Sep 23 02:08:37 PDT 2003
>Originator:     Michael Hsin
>Release:        FreeBSD 4.6-STABLE i386
>Organization:
NTU CSIE
>Environment:
System: FreeBSD b.mhsin.org 4.6-STABLE FreeBSD 4.6-STABLE #3: Sat Mar 8 23:05:37 CST 2003 root@b.mhsin.org:/usr/obj/usr/src/sys/Ada i386


	
>Description:
	devel/arm-elf-gcc295 fails to build and install on -stable.
	(This port has been already marked as BROKEN on -current.)
>How-To-Repeat:
	Just try to build this port on a -stable machine. It will fail to
	configure libiberty(and some other libraries).
	Trying to install it also fails. The sed_inplace utility does not
	take '\n' as newline.
>Fix:
	The patch below:

--- Makefile.orig	Tue Aug 12 01:43:11 2003
+++ Makefile	Tue Aug 12 03:09:29 2003
@@ -58,9 +58,11 @@
 post-configure:
 	${REINPLACE_CMD} -Ee 's,^(TARGET_CONFIGDIRS\s*=),\1#,' \
 	    ${WRKSRC}/Makefile
-	${REINPLACE_CMD} -Ee 's,^(install-info:),\1\ndonot-\1,; \
-	    s,\$$\(bindir\)/(\$$\(DEMANGLER_CROSS_NAME\)),./\1,' \
+	${PERL} -i -ne 's/^(install-info:)/\1\ndonot-\1/; print' ${WRKSRC}/gcc/Makefile
+	${REINPLACE_CMD} -Ee 's,\$$\(bindir\)/(\$$\(DEMANGLER_CROSS_NAME\)),./\1,' \
 	    ${WRKSRC}/gcc/Makefile
+	${REINPLACE_CMD} -Ee 's/^(TARGET_CONFIGDIRS =)/\1#/' \
+	    ${WRKSRC}/Makefile
 
 post-install:
 	@${MV} ${PREFIX}/bin/cpp ${PREFIX}/bin/${PKGNAMEPREFIX}cpp


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gerald 
Responsible-Changed-By: gerald 
Responsible-Changed-When: Sun Sep 21 05:33:10 PDT 2003 
Responsible-Changed-Why:  
I'm going to take care of this and have already contacted this port's 
maintainer to get approval for the patch.  (In general, filing a PR with 
a fix is most appreciated, but also pinging the port's maintainer is even 
better. ;-) ) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=55475 
State-Changed-From-To: open->closed 
State-Changed-By: gerald 
State-Changed-When: Tue Sep 23 02:05:14 PDT 2003 
State-Changed-Why:  
Tested and applied (in time for 4.9-RELEASE), thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=55475 
>Unformatted:
